> On 2010-06-09 16:27:04, Robbert van Beek wrote:
> > /trunk/classes/google/data.php, lines 401-402
> > <http://dev.covide.nl/rb/r/922/diff/2/?file=7122#file7122line401>
> >
> > hm, is this going to work? Seeing as how the original passes true as a string, and you now pass a boolean. what's it for, anyway?
>
> Daan Aikema wrote:
> Well, thats because of the revert earlier. In EventQuery.php on line 398 it says } elseif( $value == 'true' | $value == 'false' ) {. So in text form, not in boolean form.
still, I'm not convinced it's needed for this change. Do you agree?
- Robbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://dev.covide.nl/rb/r/922/#review1278
-----------------------------------------------------------
On 2010-06-04 13:53:59, Daan Aikema wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://dev.covide.nl/rb/r/922/
> -----------------------------------------------------------
>
> (Updated 2010-06-04 13:53:59)
>
>
> Review request for Covide Developers.
>
>
> Summary
> -------
>
> When google calendar synchronizes, it also gets events that happened in the past.
>
>
> This addresses bug 798.
> http://dev.covide.nl/trac/ticket/798
>
>
> Diffs
> -----
>
> /trunk/classes/google/data.php 7657
>
> Diff: http://dev.covide.nl/rb/r/922/diff
>
>
> Testing
> -------
>
> Now it gets the events ordered by starttime in descending sorting order. Now you won't see the events today when you have more then 1000 events in the future, but not even bill gates has that much events (i hope for him)
>
>
> Thanks,
>
> Daan
>
>
|