Thanks for report and fix. I know this isn't the -quality list, and
maybe a devel can figure what the incorrect symptoms were,
but there seems no information here that a non-devel could test
the fix from. I think generally we could always aim to state
symptoms being fixed in the commit log (and of course refer to
a Bugzilla bug if there is one).
Gale
| From Al Dimond <businessmanprogrammersteve@...>
| Mon, 12 Apr 2010 09:35:10 -0600
| Subject: [Audacity-devel] Labels doesn't move correctly in new Trunc Silence version
> On Sunday 11 April 2010 11:12:33 Nikolay Kovtun wrote:
> >
> > In new Trunc Silence version by Al Dimond I observe, that linking
> > labels are move incorrectly. After few changes it seems to work
> > fine, but I'm afraid that I could change some important code. It
> > will be good if Al could review this.
> >
>
> Thanks for finding this. The problem is that parameters were reversed
> in the call to Track::SyncAdjust(); Track::SyncAdjust() was correct,
> and I think LabelTrack::SplitCut() was wrong (but apparently it's
> almost never used). Should all be fixed now.
>
> - Al
>
> > Index: LabelTrack.cpp
> >
> ===================================================================
> > --- LabelTrack.cpp (revision 10401)
> > +++ LabelTrack.cpp (working copy)
> > @@ -2181,6 +2181,9 @@
> > mLabels[i]->t -= (t1 - t0);
> > mLabels[i]->t1 -= (t1 - t0);
> > }
> > + else if (mLabels[i]->t1 > t1) {
> > + mLabels[i]->t1 -= (t1 - t0);
> > + }
> > }
> > ((LabelTrack *) (*dest))->mClipLen = (t1 - t0);
> >
> > Index: Track.cpp
> >
> ===================================================================
> > --- Track.cpp (revision 10401)
> > +++ Track.cpp (working copy)
> > @@ -240,7 +240,7 @@
> > Track *tmp;
> > bool ret;
> >
> > - ret = Cut(oldT1, GetEndTime(), &tmp);
> > + ret = Cut(oldT1, newT1, &tmp);
> > if (!ret) return false;
> >
> > ret = Paste(newT1, tmp);
|
