On Wed, Jun 11, 2008 at 04:22:57AM +0000, Elliot Metsger wrote:
> Does anyone have any objections to extracting superclass from the
> PostGres and Oracle browse DAOs? That would remove a lot of code
> duplication and allow additional database implementations to be done
> more easily and less error prone.
This probably makes sense (though I've not actually looked at the code).
The difference between the Oracle & Postgres DAO code was so slight that
when I wrote all the DAOs (excluding for browse, those are from Graham
and Richard J) I didn't even write separate DAOs for Oracle, and I just
left in the conditionals that were there originally. Thus, even though
they're all in *.dao.postgres they should still work for both. It
wasn't obvious how to break these out into separate packages / classes
without duplicating a lot of code, so I didn't bother. There is a case
for just calling them 'RDBMS' DAOs rather than Postgres, Oracle, etc,
but that wouldn't be very modular.
James Rutherford | Hewlett-Packard Limited registered Office:
Research Engineer | Cain Road,
HP Labs | Bracknell,
Bristol, UK | Berks
+44 117 312 7066 | RG12 1HN.
james.rutherford@... | Registered No: 690597 England
The contents of this message and any attachments to it are confidential
and may be legally privileged. If you have received this message in
error, you should delete it from your system immediately and advise the
sender. To any recipient of this message within HP, unless otherwise
stated you should consider this message and attachments as "HP