--- Comment #3 from Carlo Bramini <carlo.bramix@...> 2008-03-13 19:10:22 UTC ---
Hello. Thank you for your feedback.
My coding time is about 99.9% done on Windows platform so, please excuse me if
I probably made an incomplete patch.
For this reason, I made the mistake of making an hand-written function for
comparing pthread_t objects; now I have fixed it by using pthread_equal() as
you suggested me.
About the fix that I made to the source into libcdio, I understand that it
could be wrong, since I cannot compile for freebsd. I wonder that you are
telling me that the arpa/inet.h just need to be included before freebsd.h.
If it is like that, then it should be easy to fix.
When you talk about "not directly applicable except on Windows", I must say
that I have not understood very well what you mean.
I guess that you are talking about the #ifdef _MSC_VER line into xine.h, before
the inclusion of sys/time.h. Actually, I did not find another way for making it
working. Personally, I also did not see it as a big trouble since it makes a
difference only when you compile under Microsoft Visual C, and only with this
compiler and I also saw the same magic macro used elsewhere in the sources.
But probably I'm not just informed about the coding styles you are using.
I also believe that adding malloc.h is not a big trouble too, hopefully the
presence of HAVE_MALLOC_H made everything simple to me, because it already
existed and it was generated at configure time.
I also removed the type casting to alloca(), as it has been suggested to me.
I will also follow your suggestion and I will split this patch into separate
Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.