Hi,
Good find. I checked in a change that makes sure there is an object
passed in before looking to see of the object knows where its root
is.
Thanks
Eric
>>> Pierre Lorenzon <pollock.nageoire@...> seems to think that:
>
>Hi Eric,
>
>I downloaded the last cvs version and it seems to solve the bug
>I mentioned : indeed using memq instead of member seems to be a
>good idea !
>
>But now another bug seems to appear ! You modified
>implementation of the ede-parent-project method at line 1494
>of ede.el file. Sure, argument obj is optional in this method
>hence you might call it without any argument at line 854 in
>the ede-new method. However your new implementation of
>ede-parent-project method calls ede-project-root
>unconditionally on obj (at line 1498) and if obj is nil it
>produces an error since this generic method might not be called
>without any argument !
>
>What should we do ?
>
>Regards
>
>Pierre
>
>> I finally looked into it today, and found that the code that
>> identifies if a target is in a project used equal, instead of eq. I
>> changed that, and my version of the bug was fixed.
>
> OK !
>
>>
>> If I understand your problem, your dilemma seems to revolve around
>> the idea that in EDE, a source file can belong to only one
>> target.
>
>½Not exactely : the probelm is not that a source file has to
>belong to one or more targets but that two different soucre
>files have the same name (without the directory part) and that
>caused the bug I mentioned : anyway it is solved by testing if
>objects are really eq and only their content is equal !
>
>
>>
>> I'm not sure sure of this guess. If you could download the latest
>> ede.el from CVS which fixes my bug (which I described above) and try
>> again to see if it is resolved or not.
>
> Yes it solves the bug ; but as I said above a new problem has
> appered ...
>
>
>
>>
>> If not, and the bug you describe throws an error, a good step is to
>> do this:
>>
>> M-x toggle-debug-on-error RET
>
> debug-on-error is always on in my emacs when I am developping
> something !
>
> Regards
>
>Pierre
>
--
Eric Ludlam: zappo@..., eric@...
Home: http://www.ludlam.net Siege: http://www.siege-engine.com
Emacs: http://cedet.sourceforge.net GNU: http://www.gnu.org
|