On Friday 25 May 2007 00:43, Oscar Bonilla wrote:
> I have a better patch that doesn't break XP :)
If you'd care to post it on the patch tracker:
we'd really appreciate it. Thanks.
> What are GNU coding standards?
> What don't you like about the patch?
You've written what you call a `ChangeSet', giving quite a detailed
description of the rationale behind your changes. I'd prefer to see
most, if not all, of that detail moved into the actual source files, in
the form of comments in appropriate places. The `ChangeLog' may then
include a very brief comment -- as brief as maybe just the first one or
two sentences of your present `ChangeSet' description; this should be
followed by an itemised list of the files touched by your patch, with a
brief but complete description of the changes made. The format we use
for this is formalised by the above GCS, and may be seen by reviewing
the actual ChangeLog file: