On Fri, Sep 23, 2005 at 02:16:57PM +0000, Emmanuel Dreyfus wrote:
> Log Message:
> Correctly initialize NAT-T VID so that we don't free unallocated space
I don't understant what have been fixed....
> if (iph1->rmconf->nat_traversal)
> plist = isakmp_plist_append_natt_vids(plist, vid_natt);
> - else
> - vid_natt=NULL;
The "old way": declare the vid_natt, then: if nat_traversal, the first
thing which will be done by isakmp_plist_append_natt_vids() is to set
up to NULL all values.
If there is no nat_t, set up the first entry of the array to NULL
(which is enough to break the free loop at the end).
Why is this "better" to do the "new way" ????