On Mon, Oct 25, 2004 at 05:45:51PM +1000, David Sitsky wrote:
> Does it make more sense for you to define a custom CVS module which
> consists of just these "branched files", and then to use this in the
> module argument in the create topic screen? That way, you only need to
> see diffs for files you are really interested in.
I think that'd complicate things more than adding the checkbox would.
My goal is to make it as painless as possible for our users...
I think I was a bit unclear in my needs, the review case I was
discussing is changes between the HEAD rev and the branch. This would
be used both for review prior to updating long-lived branches with
HEAD changes, and review prior to reeling development branches back
into the HEAD.
In the short-term I've changed the default to have '-f' but I don't
want too keep it that way for the reasons you mentioned.
As to the automated review generation, I decided that a scheduled
tagging is a bit redundant, since the dates are embedded in our
nightly builds already, so one can just get with the correct date
specification. I derived a script from the codestriker-modified
log_accum.pl that does what I need.
This is easier for our management group than going through a pile of
reviews generated by each commit, since we have a large, distributed
dev team. The review is generated via cron each night, for their
review in the morning.
This uses a very slightly simplified clone of the
codestriker_create_topic function from log_accum.pl
I'll happily post the entire script if others might find it useful.
The meat of it is:
my @diffs = `$diffcmd $_`;
;# if we actually made changes, document them
codestriker_create_topic('dave@...', "$_ $day", \@diffs);
One problem is that there are a few rtf files sprinkled through our
source. They're in text-mode under cvs, to allow using $Keywords$,
but I'd as soon not see the raw rtf diffs in my generated review sets.
Is there a way to do filetype-exclusions in codestriker? Or are there
tricks I could do with cvsignore?
Any sufficiently advanced technology is indistinguishable from magic.
-- Arthur C. Clarke