CEDET

Hi Eric,

i have found a small bug in speedbar which probably prevents =
`speedbar-vc-directory-enable-hook' to work correct or to work at all.

The line

(run-hook-with-args ....)=20

must be

(run-hook-with-arg-until-success ...)

because the docstring of run-hook-with-args says "...it is the best to =
to depend on the value returned by run-hook-with-args!..."

Otherwise the result of speedbar-vc-check-dir-p is unpredictable for all =
backends besides CVS, RCS and SCCS...

Ciao,
Klaus

[CEDET-devel] Re[1]: Bug in the VC-support of speedbar From: Eric M. Ludlam <eric@si...> - 2004-10-02 17:41 >>> "Berndl, Klaus" <klaus.berndl@...> seems to think that: >Hi Eric, > >i have found a small bug in speedbar which probably prevents = >`speedbar-vc-directory-enable-hook' to work correct or to work at all. > >The line > >(run-hook-with-args ....)=20 > >must be > >(run-hook-with-arg-until-success ...) > >because the docstring of run-hook-with-args says "...it is the best to = >to depend on the value returned by run-hook-with-args!..." > >Otherwise the result of speedbar-vc-check-dir-p is unpredictable for all = >backends besides CVS, RCS and SCCS... [ ... ] Thanks! Could you check that in? Eric -- Eric Ludlam: zappo@..., eric@... Home: http://www.ludlam.net Siege: http://www.siege-engine.com Emacs: http://cedet.sourceforge.net GNU: http://www.gnu.org

1 message has been excluded from this view by a project administrator.