On Wed, 2003-07-02 at 06:10, John Levon wrote:
> On Tue, Jul 01, 2003 at 04:49:01PM -0600, Al Stone wrote:
> > Oops. Sorry about that; I wasn't thinking about this
> > very clearly, I guess.
> > Please find attached a diff that makes more sense.
> +Upstream Author(s):
> + John Levon <moz@...>
> I guess you can remove the brackets :) And please use
> +++ oprofile-debian/ReleaseNotes 2003-06-25 11:23:26.000000000
> Does debian demand this file to exist ? It's slightly more awkward for
> us to include it...
No. It's for convenience, more than anything else.
None of the debian changes have to be in the oprofile
CVS tree. You could choose to include none of these;
it's normally considered the responsibility of the debian
package maintainer to synchronize the CVS tree with any
changes made for packaging. It's a very minor step for
me to include this with new releases and I don't mind
doing it to make the documentation more complete.
> +dnl AC_TRY_COMPILE([#include <bfd.h>], ,
> +AC_COMPILE_IFELSE([#include <bfd.h>],
> Why ? What does this macro do ? It seems undocumented. Does it work
> with autoconf 2.13 ?
Using the debian unstable release, AC_TRY_COMPILE was
reported as being deprecated and that AC_COMPILE_IFELSE
was to be used instead (autoconf 2.57 and automake 1.7.5).
That's was why I replaced it. I don't believe it works
in 2.13; I can go either way on whether it's a necessary
change or not -- it does keep some warnings out of the
build of the package.
> > +++ oprofile-debian/debian/Makefile.modules.am
> Hmmm, duplicated code :( Isn't there a better way ?
Not that I've been able to come up with yet :(. This
was created to make it possible for the debian package
autobuilder to automagically create kernel module
packages for all of the various permutations of kernel
that get built. I've played with some scripts but
have not found a clean, reliable way of creating this
file just yet.
> > +++ oprofile-debian/debian/changelog
> Must this be "changelog" or can it be "ChangeLog" to match what we have
> already in the top level dir ?
The file debian/changlog is a required file for debian
packaging. Again, none of the changes for debian have
to be in the oprofile CVS tree; it's entirely up to you.
The two files -- debian/changelog and ChangeLog serve entirely
different purposes. The debian/changelog file is meant to
track changes specific to debian packaging and hence only has
a meaning as part of a debian package. Clearly, ChangeLog
has meaning completely independent of how oprofile is
packaged; note, too, that both files get included in the
files installed in /usr/share/doc/oprofile when the debian
package gets installed.
> > +++ oprofile-debian/debian/configure.modules.in
> Again, I'm not happy with duplicating stuff... maintenance burden.
Granted. Neither am I. I'm open to suggestion....I just
haven't been happy with my attempts at scripting the update.
> > - KSRC=/lib/modules/`uname -r`/build
> + KSRC=/usr/src/linux
> This change is incorrect on any system except a standard Debian one, I
> suspect ... We cannot default to /usr/src/linux, there is no standard
> that says it must match the running kernel
This change goes hand-in-hand with the changes to m4/findkernel.m4.
The idea was to make this so that regardless of the default, the
macro would actually test for the existence of the source directories
and fall back on 'KSRC=/lib/modules/`uname -r`/build' if it had to.
The problem being solved is that a package called oprofile-source
gets created that's the source files for building the kernel module.
Those files are in turn built with any number of kernel source trees;
hence, findkernel.m4 was added to so that it would look through
several additional possibilities before giving up.
> p.s. please cc: oprofile-list@... in your reply
Sigh. Clearly I need more coffee :). I'm even subscribed
to that list and spaced it. Done.
Linux & Open Source Lab