sfTerminate operation must catch Throwables, rather than just Exception
-----------------------------------------------------------------------
Key: SFOS-1646
URL: http://jira.smartfrog.org/jira/browse/SFOS-1646
Project: SmartFrog
Issue Type: Bug
Components: .sfCore
Affects Versions: 3.18.010
Reporter: Steve Loughran
Assignee: Patrick Goldsack
Priority: Critical
Fix For: 3.18.x
We are seeing this in hudson, a stack trace showing that when a component triggers a NullPointerException in its sfTerminateWith() method, the exception may not be being caught in PrimImpl.sfTerminateQuietlyWith()
The catcher methods should catch all Throwable events, and continue to shutdown.
I can imagine an easy test for this.
[sf-startdaemon-debug] sudo null/sup-vnet-unload -c
[sf-startdaemon-debug] 2011/08/15 15:01:55:099 BST [INFO ][TerminatorThread] SFCORE_LOG - ShellRunner execute: sudo null/sup-vnet-unload -c
[sf-startdaemon-debug] 2011/08/15 15:01:55:099 BST [ERROR]SFCORE_LOG - null <java.lang.NullPointerException>
[sf-startdaemon-debug] java.lang.NullPointerException
[sf-startdaemon-debug] at com.hp.sup.common.ShellRunner.getSh(ShellRunner.java:165)
[sf-startdaemon-debug] at com.hp.sup.common.ShellRunner.execute(ShellRunner.java:75)
[sf-startdaemon-debug] at com.hp.sup.common.ShellRunner.execute(ShellRunner.java:129)
[sf-startdaemon-debug] at com.hp.sup.hm.NetworkModConfig.unloadModules(NetworkModConfig.java:144)
[sf-startdaemon-debug] at com.hp.sup.hm.NetworkModConfig.sfTerminateWith(NetworkModConfig.java:161)
[sf-startdaemon-debug] at org.smartfrog.sfcore.prim.PrimImpl.terminateNotifying(PrimImpl.java:1244)
[sf-startdaemon-debug] at org.smartfrog.sfcore.prim.PrimImpl.sfTerminateQuietlyWith(PrimImpl.java:1357)
[sf-startdaemon-debug] at org.smartfrog.sfcore.common.TerminatorThread.execute(TerminatorThread.java:211)
[sf-startdaemon-debug] at org.smartfrog.sfcore.utils.SmartFrogThread.run(SmartFrogThread.java:278)
[sf-startdaemon-debug]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|