gramps

Sorry if I committed something incorrectly... I'll go back and look.

If you can fix and are willing to, please do. Thanks!

-Doug

Alex Roitman wrote:
> Hi everybody,
> 
> As was brought up yesterday by the FreeBSD port packager,
> we do have gconf schemas screwed up and confused with the
> mime types in our installation.
> 
> It seems that Don has removed gconf stuff from data/Makefile.am
> in revision 8755. Then Doug has added some of that back on
> revision 9851. It looks to me that the last one was a runaway commit
> that was not meant to happen. Doug, can you confirm either way?
> 
> 
> I would propose this:
> 1. Deleting data/gramps.schemas from svn
> 2. Removing all gconf-schema-related stuff from data/Makefile.am
> 3. Cleaning up our acinclude.m4 extension to get rid of gconf macros
>    (I wrote that so I should be able to safely remove that).
> 
> I could get this all cleaned up fairly quickly.
> 
> A question to the release management guys: should this
> go into 3.0.1 or should we do it later?
> 
> I would vote for now rather than later. But so far I haven't commited
> anything.
> 
> Alex
>

I did check the archives and found this:

http://www.nabble.com/make-distcheck-passes%21-td14884174.html#a14884174

where I said:

"""
In order to get "make distcheck" to pass, I had to do some things that I
don't understand and merely guessed at. If someone wishes, please look 
at the changes in:

src/data/Makefile.am (anything mentioning "schemas")
"""

So, yes, I had no idea what I was doing; thanks for looking at that!

-Doug

Alex Roitman wrote:
> Hi everybody,
> 
> As was brought up yesterday by the FreeBSD port packager,
> we do have gconf schemas screwed up and confused with the
> mime types in our installation.
> 
> It seems that Don has removed gconf stuff from data/Makefile.am
> in revision 8755. Then Doug has added some of that back on
> revision 9851. It looks to me that the last one was a runaway commit
> that was not meant to happen. Doug, can you confirm either way?
> 
> 
> I would propose this:
> 1. Deleting data/gramps.schemas from svn
> 2. Removing all gconf-schema-related stuff from data/Makefile.am
> 3. Cleaning up our acinclude.m4 extension to get rid of gconf macros
>    (I wrote that so I should be able to safely remove that).
> 
> I could get this all cleaned up fairly quickly.
> 
> A question to the release management guys: should this
> go into 3.0.1 or should we do it later?
> 
> I would vote for now rather than later. But so far I haven't commited
> anything.
> 
> Alex
>

On Fri, 2008-05-16 at 15:35 -0400, Douglas S. Blank wrote:
> I did check the archives and found this:
> 
> http://www.nabble.com/make-distcheck-passes%21-td14884174.html#a14884174
> 
> where I said:
> 
> """
> In order to get "make distcheck" to pass, I had to do some things that I
> don't understand and merely guessed at. If someone wishes, please look 
> at the changes in:
> 
> src/data/Makefile.am (anything mentioning "schemas")
> """
> 
> So, yes, I had no idea what I was doing; thanks for looking at that!

I see the problem now. The Makefile.am was cleaned up, but the
gramps.schemas entry was not deleted from po/POTFILES.in and that
resulted in generation of the .schemas rule. That was the fact that
annoyed distcheck. I am ready with the fix.

Alex

-- 
Alexander Roitman   http://gramps-project.org

On Fri, May 16, 2008 at 1:01 PM, Alex Roitman <shura@...> wrote:
> OK, the sf.net takes forever to put this through, so
> I decided to send in a patch with the fix in the meantime.
>
> Applying the attached patch against SVN 10728 and
> deleting data/gramps.schemas* should do the trick.

Before I damage something -- I assume I also "svn delete
data/gramps.schemas.in"?

> I haven't committed this because it might be too close to
> the release. Please feel free to test and send me the feedback.
> It works for me, "make distcheck" is happy.

What specifically do we test?  What does this affect exactly?  It
looks like a description of configuration options for GRAMPS.

Stéphane

On Fri, 2008-05-16 at 14:00 -0700, Stéphane Charette wrote:
> On Fri, May 16, 2008 at 1:01 PM, Alex Roitman <shura@...> wrote:
> > OK, the sf.net takes forever to put this through, so
> > I decided to send in a patch with the fix in the meantime.
> >
> > Applying the attached patch against SVN 10728 and
> > deleting data/gramps.schemas* should do the trick.
> 
> Before I damage something -- I assume I also "svn delete
> data/gramps.schemas.in"?

To test on your system, you can just delete the file.
To commit deletion, "svn rm data/gramps.schemas.in" should work.

> > I haven't committed this because it might be too close to
> > the release. Please feel free to test and send me the feedback.
> > It works for me, "make distcheck" is happy.
> 
> What specifically do we test?   What does this affect exactly?

Installation. The gconf schemas were actually installing into
the mime directory, mistakenly. We have moved away from gconf,
so those schemas should disappear and not be installed anywhere.

So the testing is to ensure that:
1. We do not install gramps.schemas anywhere at all.
2. My patch has no unintended consequences. In other words, there
   should be no new issues with the installation introduced by
   the patch.

> It looks like a description of configuration options for GRAMPS.

Yes, but it has been decided that we will stick with ini files
for storing configuration, not gconf.

Alex

-- 
Alexander Roitman   http://gramps-project.org

Alex, I cannot apply the patch cleanly.  Here is what I tried, in case
I'm doing it wrong:

stephane@...$ svn st
stephane@...$ svn up
At revision 10728.
$ patch -p0 -i /home/stephane/Desktop/no_gconf.diff
(Stripping trailing CRs from patch.)
patching file INSTALL
Hunk #1 FAILED at 24.
Hunk #2 FAILED at 40.
Hunk #3 FAILED at 69.
Hunk #4 FAILED at 85.
4 out of 4 hunks FAILED -- saving rejects to file INSTALL.rej
(Stripping trailing CRs from patch.)
patching file acinclude.m4
(Stripping trailing CRs from patch.)
patching file data/Makefile.am
(Stripping trailing CRs from patch.)
patching file po/POTFILES.in
Hunk #1 succeeded at 700 (offset -5 lines).
(Stripping trailing CRs from patch.)
patching file po/POTFILES.skip
stephane@...$


Stéphane

My fault.  I see now the patch is against trunk, and I'm trying to
apply it to gramps30.

I'm free this afternoon and was planning on doing the 3.0.1 release.
Do I merge Alex's fix into gramps30?

Stéphane


On Fri, May 16, 2008 at 2:16 PM, Stéphane Charette
<stephanecharette@...> wrote:
> Alex, I cannot apply the patch cleanly.  Here is what I tried, in case
> I'm doing it wrong:
>
> stephane@...$ svn st
> stephane@...$ svn up
> At revision 10728.
> $ patch -p0 -i /home/stephane/Desktop/no_gconf.diff
> (Stripping trailing CRs from patch.)
> patching file INSTALL
> Hunk #1 FAILED at 24.
> Hunk #2 FAILED at 40.
> Hunk #3 FAILED at 69.
> Hunk #4 FAILED at 85.
> 4 out of 4 hunks FAILED -- saving rejects to file INSTALL.rej
> (Stripping trailing CRs from patch.)
> patching file acinclude.m4
> (Stripping trailing CRs from patch.)
> patching file data/Makefile.am
> (Stripping trailing CRs from patch.)
> patching file po/POTFILES.in
> Hunk #1 succeeded at 700 (offset -5 lines).
> (Stripping trailing CRs from patch.)
> patching file po/POTFILES.skip
> stephane@...$
>
>
> Stéphane
>

Stephane,

> I'm free this afternoon and was planning on doing
> the 3.0.1 release.
> Do I merge Alex's fix into gramps30?

If you can apply the patch and test that it works,
then I would be fine with putting it in 3.0.1. Someone
should file an issue on the tracker so it ends up in
the changelog.

~Brian

Brian,

On Fri, 2008-05-16 at 14:57 -0700, Brian Matherly wrote:
> Stephane,
> 
> > I'm free this afternoon and was planning on doing
> > the 3.0.1 release.
> > Do I merge Alex's fix into gramps30?
> 
> If you can apply the patch and test that it works,
> then I would be fine with putting it in 3.0.1. Someone
> should file an issue on the tracker so it ends up in
> the changelog.

http://bugs.gramps-project.org/view.php?id=2154

I would love it if several people tested it.

Alex


-- 
Alexander Roitman   http://gramps-project.org