On Sun, 2006-07-23 at 20:50 -0400, Evan Schoenberg wrote:
> On Jul 23, 2006, at 12:45 PM, Stu Tomlinson wrote:
> > Doesn't this break the upgrade path for anyone who already has a
> > sametime account set up? Gaim would look for prpl-meanwhile and not
> > find
> > it. Why was this necessary for static compilation?
It does break the upgrade path, and that's pretty bad.
> This was necessary because sametime prpl claims in GAIM_INIT_PLUGIN to
> be named sametime but there claims to be named meanwhile.
I thought about this some more, and it just didn't make any sense. The
library name doesn't mean anything to the identifier string that a
plugin registers itself with.
I think I figured out why this was causing a problem in Adium, and it
wasn't due to static compilation... it looks like sametime.c in libgaim
and ESGaimMeanwhileAccount.m just didn't agree on what to call the
plugin. Changing them both to "prpl-meanwhile" is working for me.
> Changing the GAIM_INIT_PLUGIN declaration to meanwhile and reverting
>  would be an equally acceptable solution; I'll be happy to do
> that if that's better, which sounds like it's the case. I guess I
> could also special case and do gaim_init_sametime_plugion() and use
> "prpl-meanwhile" as the prpl identifier. Just felt better to make the
> file consistent one way or another instead of using two different
> > On Thu, 2006-07-20 at 06:04 -0700, evands@...
> > wrote:
> > > Revision: 16528
> > > Author: evands
> > > Date: 2006-07-20 06:04:35 -0700 (Thu, 20 Jul 2006)
> > > ViewCVS: http://svn.sourceforge.net/gaim/?rev=16528&view=rev
> > >
> > >
> > > Log Message:
> > > -----------
> > > Fixed sametime prpl when using static compilation.
> > > Modified Paths:
> > > --------------
> > > trunk/src/protocols/sametime/sametime.c
> > > Modified: trunk/src/protocols/sametime/sametime.c
> > > ===================================================================
> > > --- trunk/src/protocols/sametime/sametime.c 2006-07-20 12:53:46
> > > UTC (rev 16527)
> > > +++ trunk/src/protocols/sametime/sametime.c 2006-07-20 13:04:35
> > > UTC (rev 16528)
> > > @@ -75,7 +75,7 @@
> > > I don't know why I even bother providing these. Oh valiant
> > > reader,
> > > I do it all for you. */
> > > /* scratch that, I just added it to the prpl options panel */
> > > -#define PLUGIN_ID "prpl-meanwhile"
> > > +#define PLUGIN_ID "prpl-sametime"
> > > #define PLUGIN_NAME "Sametime"
> > > #define PLUGIN_SUMMARY "Sametime Protocol Plugin"
> > > #define PLUGIN_DESC "Open implementation of a Lotus Sametime
> > > client"
Christopher (siege) O'Brien <siege@...>