On Sun, 2006-06-11 at 14:48 -0700, roast@... wrote:
> + if (!g_ascii_strncasecmp(gaim_account_get_username(log->account),
> + gaim_account_get_username(log->conv->account),
> + strlen(gaim_account_get_username(log->account)))) {
This looks bogus.
At first glance, I thought you were comparing the usernames directly.
For the record, that won't work because you have to normalize them.
However, I realized you're comparing the usernames of the accounts.
That's flawed, because "rlaager" on Yahoo != "rlaager" on AIM.
Since the account pointers are managed by the Gaim core, they're going
to be identical for a given account.
So, you'll just want to compare the account pointers numerically:
if (log->account == log->conv->account)
However, why is this necessary? What's the point in special-casing
conversations with yourself?
Richard
|
