Hi all,
I think that you are considering the wrong set of files.
Since the Win32 build uses none of the autoconf/automake
tree, this is likely the wrong place to put such a thing.
The Win32 build is performed with hand-made makefiles,
and the Makedep perl scripts. A better place would be
$INKSCAPE/Makefile.mingw, where the 'make dist' target
already exists. Maybe add a target, 'make installer'.
However, even that might not be worth the effort. Over the last
year, we have customized those Makefiles to work on Win9x,
WinNT+, and Linux. Getting NSIS to run on all devices
might be more trouble than it is worth. And for the last
two releases, it was necessary to do some
manual cleanup of the 'dist' directory, after it had been
created, before running the NSIS packager. So it wouldn't
be part of the set of target dependencies, without manual
intervention. So, IMHO, it is not necessary to put it into
the makefiles at all.
Bob
Kees Cook wrote:
>On Sun, Oct 31, 2004 at 04:22:47PM +1100, Peter Moulder wrote:
>
>
>>We could have a .nsi.in file with e.g.
>>
>> !define PRODUCT_VERSION "@VERSION@"
>>
>>
>
>I was thinking about that when I did the commit, actually. The
>inkscape.spec is built the same way.
>
>
>>and have a makefile rule, e.g. in Makefile.am:
>>
>> inkscape.nsi: inkscape.nsi.in configure.ac
>> sed 's,[@]VERSION[@],$(VERSION),g' < $(srcdir)/inkscape.nsi.in > inkscape.nsi
>>
>>
>
>This can be done by adding "inkscape.nsi" with configure.ac's
>AC_CONFIG_FILES list.
>
>
>
>>and perhaps add inkscape.nsi to EXTRA_DIST if we want people to be able
>>to use the .nsi file without being able to use `make'.
>>
>>
>
>Oh! Yeah, good idea. Ah, yeah, I see the inkscape.spec is in there
>already. Cool.
>
>
>
|