On Tue, Mar 02, 2004 at 09:41:27AM -0300, Miguel Freitas wrote:
> i'm back to the (so called) civilized world after a great week climbing
> mountains... ;)
> On Mon, 2004-02-23 at 13:39, Thibaut Mattern wrote:
> > On Sat, 2004-02-14 at 00:33, Yann Vernier wrote:
> > > The patch is at http://donkey.dyndns.org/~yann/colorkeyxv.diff and co=
> > > use some testing. Note that if your Xvideo accelerator supports
> > > XV_AUTOPAINT_COLORKEY you must set video.xv_autopaint_colorkey:0 in y=
> > > ~/.xine/config for colorkey osds to work, otherwise it still uses the
> > > shape extension.
> i still haven't tested it, but i'm happy to see somebody working to
> improve the unscaled osd. using colorkey is definitely a good thing, i
> also feel a little annoyed about the xshape flashing, but it seemed to
> be the most X11 compatible way (ie. works with several vo drivers and
> different OS's)
> the patch looks very nice. i remember you had some plans to improve it
> further, so should we commit it now or wait for a new version?
I think commiting this part now is a good idea. I'm not sure when I'll
pick up on coding again.. perhaps the default setting of autopaint
should be altered (if it's available, colorkey does seem nicer than
> > Miguel: do you have some time to review it ?=20
> unfortunately not as throughly as i would like. but don't let me stop
> you from applying it, we can always fix/improve things later. it is
> definitely the right direction.
That's what I think too. It's not perfect, but an improvement, and
getting it into CVS will get more people to try it out.
PGP fingerprint =3D 9242 DC15 2502 FEAB E15F 84C6 D538 EC09 5380 5746