gramps

Some comments on the family view:

When I say "add" for Spouse and then press "Add new person", I get an
empty spot in the Spouse box and an "empty" person is added to the list of
persons.

I would always display the "Preferred Relationship" text so that there is
no need to change the layout of the spouse box when you add a second
person.

I don't like having a check-box "Make this the preferred relationship"
which behaves like a button. Why not just make it a button.

I wasn't able to check out the "Preferred parents" thing because I get the
following error when I try to add parents (no matter whether there are
already parents or not):

Traceback (most recent call last):
  File "/usr/lib/python2.1/site-packages/libglade.py", line 28, in
__call__
    ret = apply(self.func, a)
  File
"/home/schandl/develop/gramps-install/share/gramps/ChooseParents.py", line
230, in save_parents_clicked
    self.change_family_type(self.family,mother_rel,father_rel)
  File
"/home/schandl/develop/gramps-install/share/gramps/ChooseParents.py", line
269, in change_family_type
    self.person.addAltFamily(family,mother_rel,father_rel)
  File "/home/schandl/develop/gramps-install/share/gramps/RelLib.py", line
1082, in addAltFamily
    assert(family==None)
AssertionError

By the way, in the Family tab, it says "Remove Child" on the lower right.
Everywhere (?) else it say "Delete Person/Source/...".

	Bernd
-- 
Bernd Schandl
Tired of spam? Use spamcop.net to complain!

On Mon, 2002-03-25 at 10:44, Bernd Schandl wrote:
> Some comments on the family view:
> 
> When I say "add" for Spouse and then press "Add new person", I get an
> empty spot in the Spouse box and an "empty" person is added to the list of
> persons.

Well, this was doing exactly what it was supposed to do, just that it
didn't make too much sense. What it was trying to do is build a new
person from the Given/Surname fields. This was completely inconsistent
with the add parents, so I've changed it to be like the add parents
dialog.

Okay, the choose parents and choose spouse work similar now. There is no
longer the issue of sometimes have a text box, and other times having an
OptionMenu, depending on the number of relationships.

I think it is cleaned up a good bit. Try it out, and let me know what
you think.

Be warned - this is not fully production ready yet. I haven't had the
time to completely test it.

> I don't like having a check-box "Make this the preferred relationship"
> which behaves like a button. Why not just make it a button.

Good point. Done.

> 
> By the way, in the Family tab, it says "Remove Child" on the lower right.
> Everywhere (?) else it say "Delete Person/Source/...".

Because it doesn't actually delete the person (the person is still in
the database), it just removes the person as a child of the family. 

-- 
Don Allingham
dallingham@...
http://gramps.sourceforge.net

On 26 Mar 2002, Don Allingham wrote:

> On Mon, 2002-03-25 at 10:44, Bernd Schandl wrote:
> > Some comments on the family view:
> >
> > When I say "add" for Spouse and then press "Add new person", I get an
> > empty spot in the Spouse box and an "empty" person is added to the list of
> > persons.
>
> Well, this was doing exactly what it was supposed to do, just that it
> didn't make too much sense. What it was trying to do is build a new
> person from the Given/Surname fields. This was completely inconsistent
> with the add parents, so I've changed it to be like the add parents
> dialog.

Ok, good.

> Okay, the choose parents and choose spouse work similar now. There is no
> longer the issue of sometimes have a text box, and other times having an
> OptionMenu, depending on the number of relationships.

Actually, I think I liked the interface with the OptionMenu
(Drop-Down-Box) better. BTW, the tooltip on the arrows in spouse area are
wrong.

> I think it is cleaned up a good bit. Try it out, and let me know what
> you think.
>
> Be warned - this is not fully production ready yet. I haven't had the
> time to completely test it.

I still get the following error when adding parents:

Traceback (most recent call last):
  File "/usr/lib/python2.1/site-packages/libglade.py", line 28, in
__call__
    ret = apply(self.func, a)
  File
"/home/schandl/develop/gramps-install/share/gramps/ChooseParents.py", line
236, in save_parents_clicked
    self.change_family_type(self.family,mother_rel,father_rel)
  File
"/home/schandl/develop/gramps-install/share/gramps/ChooseParents.py", line
263, in change_family_type
    self.person.addAltFamily(family,mother_rel,father_rel)
  File "/home/schandl/develop/gramps-install/share/gramps/RelLib.py", line
1082, in addAltFamily
    assert(family==None)
AssertionError

And I get this error when I want to switch the active person with the
spouse when there is more than one spouse:

Traceback (most recent call last):
  File "/usr/lib/python2.1/site-packages/libglade.py", line 28, in
__call__
    ret = apply(self.func, a)
  File "/home/schandl/develop/gramps-install/share/gramps/gramps_main.py",
line 1278, in on_swap_clicked
    spouse = self.spouse_menu.get_menu().get_active().get_data("person")
AttributeError: 'None' object has no attribute 'get_menu'

Nothing happens when I click that button and there is only one spouse.

> > I don't like having a check-box "Make this the preferred relationship"
> > which behaves like a button. Why not just make it a button.
>
> Good point. Done.
>
> >
> > By the way, in the Family tab, it says "Remove Child" on the lower right.
> > Everywhere (?) else it say "Delete Person/Source/...".
>
> Because it doesn't actually delete the person (the person is still in
> the database), it just removes the person as a child of the family.

Oh, I didn't notice/understand this little difference in functionality and
the English language. I will have to change my translations accordingly.

Off to work ;-)

	Bernd
-- 
Bernd Schandl
Tired of spam? Use spamcop.net to complain!

On Tue, 2002-03-26 at 14:08, Bernd Schandl wrote:
> > Okay, the choose parents and choose spouse work similar now. There is no
> > longer the issue of sometimes have a text box, and other times having an
> > OptionMenu, depending on the number of relationships.
> 
> Actually, I think I liked the interface with the OptionMenu
> (Drop-Down-Box) better. BTW, the tooltip on the arrows in spouse area are
> wrong.
> 

I've switched to a ComboBox, which has the drop down menu. It looks a
lot better than the OptionMenu or the double arrow, yet still seems to 
fit in with the parent selection mechanism.

Let me know what you think.

> I still get the following error when adding parents:
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.1/site-packages/libglade.py", line 28, in
> __call__
>     ret = apply(self.func, a)
>   File
> "/home/schandl/develop/gramps-install/share/gramps/ChooseParents.py", line
> 236, in save_parents_clicked
>     self.change_family_type(self.family,mother_rel,father_rel)
>   File
> "/home/schandl/develop/gramps-install/share/gramps/ChooseParents.py", line
> 263, in change_family_type
>     self.person.addAltFamily(family,mother_rel,father_rel)
>   File "/home/schandl/develop/gramps-install/share/gramps/RelLib.py", line
> 1082, in addAltFamily
>     assert(family==None)
> AssertionError

This should be fixed now as well.


-- 
Don Allingham
dallingham@...
http://gramps.sourceforge.net

On Tue, Mar 26, 2002 at 08:47:00AM -0700, Don Allingham wrote:
>
> Okay, the choose parents and choose spouse work similar now. There is no
> longer the issue of sometimes have a text box, and other times having an
> OptionMenu, depending on the number of relationships.
> 
> I think it is cleaned up a good bit. Try it out, and let me know what
> you think.

When adding new parents... there needs to be scroll bars on the lists
of people.  Also, when you add a new person by clicking on the "Add
Person" button the new person should be automatically selected as the
father or mother, depending on the sex of the new person.

It would be nice also if there was a way to quicky scroll to a name by
typing the first few letters of the last name.  I have a lot of names
in my DB and it's difficult to precisely scroll using such small
lists.

Jeff

On 26 Mar 2002, Don Allingham wrote:

> On Tue, 2002-03-26 at 14:08, Bernd Schandl wrote:
> > > Okay, the choose parents and choose spouse work similar now. There is no
> > > longer the issue of sometimes have a text box, and other times having an
> > > OptionMenu, depending on the number of relationships.
> >
> > Actually, I think I liked the interface with the OptionMenu
> > (Drop-Down-Box) better. BTW, the tooltip on the arrows in spouse area are
> > wrong.
> >
>
> I've switched to a ComboBox, which has the drop down menu. It looks a
> lot better than the OptionMenu or the double arrow, yet still seems to
> fit in with the parent selection mechanism.

So we have the arrows for parents and a combo box for the spouse - a
little inconsistent but I really like the combo box and I don't see how to
use it for parents. So I'd leave it how it is now and hope that not many
people have several spouses and several parents ;-)

I have one new bug: When I add a second spouse, I get this error:

Traceback (most recent call last):
  File "/usr/lib/python2.1/site-packages/libglade.py", line 28, in
__call__
    ret = apply(self.func, a)
  File "/home/schandl/develop/gramps-install/share/gramps/AddSpouse.py",
line 158, in select_spouse_clicked
    self.update(family)
  File "/home/schandl/develop/gramps-install/share/gramps/gramps_main.py",
line 1473, in load_family
    self.build_spouse_dropdown()
  File "/home/schandl/develop/gramps-install/share/gramps/gramps_main.py",
line 1410, in build_spouse_dropdown
    self.spouse_combo.list.select_child(sel)
UnboundLocalError: local variable 'sel' referenced before assignment

Then I have a combo box with just one entry. When I hit Delete, I have a
combo box with two entries: Unknown (which is preferred) and the second
name. Deleting Unknown doesn't work, deleting the second name leads to an
empty text box.

Anyway, I think the interface for handling several spouses and parents
including preferences is pretty good now!

	Bernd
-- 
Bernd Schandl
Tired of spam? Use spamcop.net to complain!

On Tue, 2002-03-26 at 11:23, Jeffrey C. Ollie wrote:
> On Tue, Mar 26, 2002 at 08:47:00AM -0700, Don Allingham wrote:
> >
> > Okay, the choose parents and choose spouse work similar now. There is no
> > longer the issue of sometimes have a text box, and other times having an
> > OptionMenu, depending on the number of relationships.
> > 
> > I think it is cleaned up a good bit. Try it out, and let me know what
> > you think.
> 
> When adding new parents... there needs to be scroll bars on the lists
> of people.  Also, when you add a new person by clicking on the "Add
> Person" button the new person should be automatically selected as the
> father or mother, depending on the sex of the new person.

Missing scrollbars was something I accidentally overlooked. They should
be in place now.

I'll look into the other. It shouldn't be too hard. Just have to figure
out what to do with the gender of both parents is the same. Any ideas?
Maybe only do this if the genders are not the same?

> 
> It would be nice also if there was a way to quicky scroll to a name by
> typing the first few letters of the last name.  I have a lot of names
> in my DB and it's difficult to precisely scroll using such small
> lists.

This is a feature that we should get with GNOME 2.

Don
-- 
Don Allingham
dallingham@...
http://gramps.sourceforge.net

On Wed, 2002-03-27 at 12:51, Bernd Schandl wrote:
> So we have the arrows for parents and a combo box for the spouse - a
> little inconsistent but I really like the combo box and I don't see how to
> use it for parents. So I'd leave it how it is now and hope that not many
> people have several spouses and several parents ;-)

Yeah, but I'm not sure how to get it more consistent. 

> I have one new bug: When I add a second spouse, I get this error:
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.1/site-packages/libglade.py", line 28, in
> __call__
>     ret = apply(self.func, a)
>   File "/home/schandl/develop/gramps-install/share/gramps/AddSpouse.py",
> line 158, in select_spouse_clicked
>     self.update(family)
>   File "/home/schandl/develop/gramps-install/share/gramps/gramps_main.py",
> line 1473, in load_family
>     self.build_spouse_dropdown()
>   File "/home/schandl/develop/gramps-install/share/gramps/gramps_main.py",
> line 1410, in build_spouse_dropdown
>     self.spouse_combo.list.select_child(sel)
> UnboundLocalError: local variable 'sel' referenced before assignment
> 
> Then I have a combo box with just one entry. When I hit Delete, I have a
> combo box with two entries: Unknown (which is preferred) and the second
> name. Deleting Unknown doesn't work, deleting the second name leads to an
> empty text box.
> 
> Anyway, I think the interface for handling several spouses and parents
> including preferences is pretty good now!
> 
> 	Bernd

The first bug should be fixed now, and I think the second one was cause
by the first.

Don

-- 
Don Allingham
dallingham@...
http://gramps.sourceforge.net

On Tue, 2002-03-26 at 11:23, Jeffrey C. Ollie wrote:
> When adding new parents... there needs to be scroll bars on the lists
> of people.  Also, when you add a new person by clicking on the "Add
> Person" button the new person should be automatically selected as the
> father or mother, depending on the sex of the new person.

This functionality should be in place now. Also, adding a new person to
the list should be significantly faster on large databases, as should
changing the relationship type.

-- 
Don Allingham
dallingham@...
http://gramps.sourceforge.net

On Mon, 2002-03-25 at 08:36, Jeffrey C. Ollie wrote:
> Plus the current interface does not deal very well with the following
> scenario:
> 
> 1) Add a person.
> 2) Add children to that person.
> 3) Go back later and add a spouse that is supposed to be the parent of
> the children from step 2.
> 
> Basically, I think that this is because the current interface assumes that
> you are creating a new family every time you add a spouse.

Very good point. I've altered it so that if you press 'Add' and no
spouse is defined, it will give you the option of creating a new
relationship (what used to be the only option), or selecting the spouse
for the current relationship.

Let me know what you think. Changes have been committed to CVS.

Don

-- 
Don Allingham
dallingham@...
http://gramps.sourceforge.net