Codestriker: collaborative code reviewer

It only seems to be on the main view pages.. not the popup file diff views.

On Fri, Nov 16, 2012 at 11:34 AM, Scarlette Ng <scarletteng@...> wrote:
> Hi all,
>
> I wonder if there are any "Next"/ "Previous" on the diff windows?
> Thanks!
>
> -Scarlette
>
>
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>

Wonder if Codestriker is working with ClearQuest?

Thanks!

-Scarlette

The problem we are encountering is with the use of externals in the project.  Obviously the externals won't be at the repository root of the prepared patch, so the full file review for files in externals cannot be prepared by Codestriker.

Chris

-----Original Message-----
From: Chris Welch 
Sent: Wednesday, February 29, 2012 11:50 AM
To: 'codestriker-user@...'
Subject: RE: [Codestriker-user] Parallel view bug using SVN, get uninitialized value error

Looking through the documentation I think we are hitting this problem:

"This file should then be selected for the "Topic text upload" field. The "Start tag", "End tag" and "Module" fields have no relevance in this situation. Because of an issue in Subversion, running the svn diff command outside of the repository root will not allow Codestriker to download and review the full file (although the patch segments can still be reviewed). If you commit your code first, then let Codestriker make the diff, as explained in the next section, then you can avoid this limitation."

I'll check and see how the problematic Topics were created.

Chris

-----Original Message-----
From: Chris Welch 
Sent: Wednesday, February 29, 2012 11:34 AM
To: 'codestriker-user@...'
Subject: RE: [Codestriker-user] Parallel view bug using SVN, get uninitialized value error

I tried the code change and the Parallel display still comes up empty.  Do we have to recreate the Topic for this code change to have effect (I.e. the change is used during Topic creation, not dynamically during Topic display)?

Tx,

Chris

From: Chris Welch 
Sent: Wednesday, February 29, 2012 9:44 AM
To: codestriker-user@...
Subject: RE: [Codestriker-user] Parallel view bug using SVN, get uninitialized value error

Great, tx gentlemen I'll look into both of these suggestions.  I suspect the different branch is the most likely cause as many of our projects make heavy use of externals.

Chris

From: David Carson [mailto:dccarson@...] 
Sent: Wednesday, February 29, 2012 8:29 AM
To: David Sitsky
Cc: Chris Welch; codestriker-user@...
Subject: Re: [Codestriker-user] Parallel view bug using SVN, get uninitialized value error

This couldn't have to do with 'highlight' being defined, but no highlight utility being installed, could it?  Seems like when I hit that particular error, it showed up as data not being retrieved as expected.
On Wed, Feb 29, 2012 at 12:42 AM, David Sitsky <david.sitsky@...> wrote:
Hi Chris,

That error message in the logs basically indicates that no data was
retrieved from the subversion server for some reason.  Normally the
logs would contain some information about it.

I've sometimes seen this issue happen in the past where the revisions
were created on different branches that what the repository is based
off.

In Subversion.pm:
http://codestriker.cvs.sourceforge.net/viewvc/codestriker/codestriker/lib/Codestriker/Repository/Subversion.pm?revision=1.29&view=markup
around line 77, you could try replacing:

push @args, @{ $self->{userCmdLine} };
push @args, $self->{repository_url} . '/' . $filename . '@' . $revision;

with

push @args, '-r';
push @args, $revision;
push @args, @{ $self->{userCmdLine} };
push @args, $self->{repository_url} . '/' . $filename;

to see if it makes any difference.

There was some semantic differences with how subversion treats @r
retrievals vs -r retrievals.  A long time ago, somebody made the
change to use @r retrievals

Cheers,
David

On Wed, Feb 29, 2012 at 4:10 AM, Chris Welch <Chris.Welch@...> wrote:
> Using Codestriker 1.9.10 with SVN 1.6.  Patches are typically created using TortoiseSVN 1.6.2 (right click, generate patch).
>
> Most of the time this works but we have some Topics that the full file content is blank when you do a Parallel view.  This failure occurs regardless of browser.
>
> The Apache log shows the following error for this request:
>
> [Tue Feb 28 11:27:37 2012] [error] [client 10.13.36.124] [Tue Feb 28 11:27:37 2012] codestriker.pl: Use of uninitialized value in concatenation (.) or string at /var/www/codestriker/lib/Codestriker/Action/ViewTopicFile.pm line 113., referer: http://aontools/codestriker/codestriker.pl?action=view&topic=2687633&mode=2&fview=0
>
> The code in question is:
>
>        # Output those lines leading up to the start of the next delta.
>        # Build up a delta with no changes, and render it.
>        my $next_delta_linenumber = $delta->{old_linenumber};
>        for (my $i = $old_linenumber; $i < $next_delta_linenumber; $i++) {
>            $delta_text .= " $filedata[$i]\n";
>            $old_linenumber++;
>
> with the failure occurring at the delta_text concatenation (I.e. $filedata[$i] is uninitialized).
>
> Any ideas on how to fix or work around this?
>
> Tx,
>
> Chris Welch
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Codestriker-user mailing list
Codestriker-user@...
https://lists.sourceforge.net/lists/listinfo/codestriker-user

Hi folks,

Is it possible to add more than 1 module/file on the same Topic title?
I am using codestriker 1.9.10 for ClearCase dynamic view.
Thanks!

-Scarlette

Hi,

It is possible.. I would check the manual for more details, but from
memory you could specify a directory and it would return all
sub-directories and files.

Cheers,
David

On Sat, Oct 27, 2012 at 11:25 AM, Scarlette Ng <scarletteng@...> wrote:
> Hi folks,
>
> Is it possible to add more than 1 module/file on the same Topic title?
> I am using codestriker 1.9.10 for ClearCase dynamic view.
> Thanks!
>
> -Scarlette
>
>
> ------------------------------------------------------------------------------
> WINDOWS 8 is here.
> Millions of people.  Your app in 30 days.
> Visit The Windows 8 Center at Sourceforge for all your go to resources.
> http://windows8center.sourceforge.net/
> join-generation-app-and-make-money-coding-fast/
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>

>
> "Problem generating topic text:
>
> At present CC::Dynamic does not support adding all files of a dir if directory is given. "

That is correct.. I didn't write this module and nor do I know
ClearCase.  If you have the option, I believe the clearcase snapshot
route might be more convenient as I think it handles directories?

> Another question: So I will need to add the every dynamic view name under the config file in order for select the "Repository" from the pop-down menu?

That's right.

Cheers,
David

Actually this is strange, as the code looks like this:

my $template = Template->new();

eval("use Template;");
die "Unable to load Template module: $@\n" if $@;

But it should actually be like this:

eval("use Template;");
die "Unable to load Template module: $@\n" if $@;

my $template = Template->new();

Can you try changing it to see if it makes any difference?  For some
mysterious reason, this was never a problem in the past with earlier
perls.

Cheers,
David

http://eastsidebarandgrill.ca/bar/files/thumbnails/level3/8512/8536/9025/giftsandsurprises.htm?postolek.leistico

<p><a href="http://dreamor.altervista.org/earbesick/Richard_Morris15/">http://dreamor.altervista.org/earbesick/Richard_Morris15/</a></p>

<p><a href="http://www.elteme.com/chewarmy/Brian_Richardson13/">http://www.elteme.com/chewarmy/Brian_Richardson13/</a></p>

<p><a href="http://spyder.snowpeak.com.tw/beliefairport/Paul_Miller35/">http://spyder.snowpeak.com.tw/beliefairport/Paul_Miller35/</a></p>

Hi Xing,

You'll need to do a print to STDERR to make it appear in apache's error
logs.

Cheers,
David

On Fri, Jun 1, 2012 at 9:09 AM, Xing Fang <xfang@...> wrote:

> Hi Guys,****
>
> ** **
>
> I want to know if there is a way to debug the back-end perl code when
> doing development. I input some parameters when using codestriker and wanna
> know if they really have been inputted into it.****
>
> ** **
>
> Is there any log file in the source code so I can check the print out
> statement or error message? Or how can you guys debug your code?****
>
> ** **
>
> Thanks a lot! ****
>
> ** **
>
> All the best!****
>
> ** **
>
> Your sincerely,****
>
> Xing Fang****
>
> ** **
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
>

Hi Ken,

It seems to be up now.  I haven't touched the install in a very long
time, so its like SF did something temporarily.

Cheers,
David

On Thu, Apr 12, 2012 at 5:57 AM, Kenneth Wolcott
<kennethwolcott@...> wrote:
> Hi;
>
> is sourceforge down? Is the Codestriker instance on Codestriker down?
> Haven't been able to connect to Codestriker for a week now.
>
> Thanks,
> Ken Wolcott

Hi Dave;

Very strange.  I cannot go to codestriker.sourceforge.net -- spins

I go to sf.net, which immediately resolves to sourceforge.net and type
"codestriker" in the search box.  Not found.

Ken

On Thu, Apr 12, 2012 at 20:27, David Sitsky <david.sitsky@...> wrote:
> Hi Ken,
>
> It seems to be up now.  I haven't touched the install in a very long
> time, so its like SF did something temporarily.
>
> Cheers,
> David
>
> On Thu, Apr 12, 2012 at 5:57 AM, Kenneth Wolcott
> <kennethwolcott@...> wrote:
>> Hi;
>>
>> is sourceforge down? Is the Codestriker instance on Codestriker down?
>> Haven't been able to connect to Codestriker for a week now.
>>
>> Thanks,
>> Ken Wolcott

I had the same initial impression of the problem and did a drill down into the source data.  The source data was consistent in its use of tabs and displays fine with several different editors.  

In this case it is a bug with Codestriker.  The code views fine everywhere but in Codestriker.  

Only Codestriker fails to display the source properly.

Yes I agree mixed white space is evil and I set up coding standards elsewhere to avoid the problem, however, it is not a requirement here.

I've provided details of the data below as examining the generated display from Codestriker showed that Codestriker is not expanding tabs consistently and is definitely a bug in Codestriker.

The problem seems to be something interfering with correct tab expansion logic when a line has parenthesis '(' or ')' in them.  Lines with a parenthesis in them do not have correct tab expansion of 4 or 8 spaces.

Please review the data I originally presented to see the problem.  There are no mixed space/tab lines yet the tabs get unevenly substituted for spaces.

This is also reflected in the 4 space expansion I've provided.  Once again there is irregular tab expansion on lines ith parenthesis on them.

Bye for now,

Chris

-----Original Message-----
From: David Sitsky [mailto:david.sitsky@...] 
Sent: Sunday, March 04, 2012 7:11 PM
To: Chris Welch
Cc: codestriker-user@...
Subject: Re: [Codestriker-user] Problems with tab expansion in codestriker

Hi Chris,

This is the problem with tabs.. and why in my work place, our IDEs
specifically are setup to not use them.  What you are seeing is quite
normal, if you load your file into an editor with different tab-stops
(8 instead of 4), you'll see the same behaviour.

Cheers,
David

On Thu, Mar 1, 2012 at 2:30 AM, Chris Welch <Chris.Welch@...> wrote:
> Using Codestriker 1.9.10 with SVN 1.6, getting tab expansion problems.  See the following:
>
>
> 458            if( attempt_num < 4 )
> 459                         ++attempt_num;
> 460           else
> 461                     TSK_sleep( ticks_per_attempt );
> 462          } while( PRD_getticks() < end_tick );
>
> The tab expansion setting is at 8 for this display.  I did an od dump of the patch looking at the data representing lines 459 and 461 that they both have three tab chars and nothing else before the text, yet they have unequal tab expansion.
>
> This patch has the following white space prior to the text on the lines:
>
> Line 458 two tab lead in, nothing else
> Line 459 three tab lead in, nothing else
> Line 460 two tab lead in, nothing else
> Line 461 three tab lead in, nothing else
> Line 462 one tab lead in, nothing else
>
> Changing the display setting to 4 spaces per tabs yields:
>
> 458        if( attempt_num < 4 )
> 459             ++attempt_num;
> 460       else
> 461             TSK_sleep( ticks_per_attempt );
> 462      } while( PRD_getticks() < end_tick );
>
> Any ideas what the problem is?
>
> Tx,
>
> Chris
>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user

To let other folks know who encounter this problem, it is indeed a bug with Codestriker and Neeta's patch works to fix it.

Thanks very much Neeta!

Bye for now,

Chris

-----Original Message-----
From: neeta.ahuja@... [mailto:neeta.ahuja@...] 
Sent: Monday, March 05, 2012 10:06 AM
To: Chris Welch; codestriker-user@...
Subject: RE: [Codestriker-user] Problems with tab expansion in codestriker

We had the same problem and I had to really work to fix it. Here is the change that was finally approved. The change is in TabToNbspLineFilter.pm file in Codestriker. 
You can try it out to see if it gets better. It did somewhat for us, but people still complain.
Thanks,
Neeta
sub _filter {
    my ($self, $text) = @_;
    my $filtered_lines;
    my $tabwidth = $self->{tabwidth};
    my @pre_filtered_lines = split  /\n/,$text;   #split the delta first
    for ( my $i = 0; $i <= $#pre_filtered_lines; $i++) {    #go through each line in delta
        my $text_to_be_altered = $pre_filtered_lines[$i] . "\n";  #need to add the end of line character now
        # The following is hard to understand.. so here goes .. go through the line, replace tab by
        # space times (number of tabs times tabwidth - modulo chars that come before tab by tabwidth)
        1 while $text_to_be_altered =~ s/\t+/' ' x
        (length($&) * $tabwidth - length($`) % $tabwidth)/eo;
        $filtered_lines .= "$text_to_be_altered"; #concatenate the altered line to rebuild delta
    }
    return "$filtered_lines";

-----Original Message-----
From: Chris Welch [mailto:Chris.Welch@...] 
Sent: Monday, March 05, 2012 9:27 AM
To: codestriker-user@...
Subject: Re: [Codestriker-user] Problems with tab expansion in codestriker

I had the same initial impression of the problem and did a drill down into the source data.  The source data was consistent in its use of tabs and displays fine with several different editors.  

In this case it is a bug with Codestriker.  The code views fine everywhere but in Codestriker.  

Only Codestriker fails to display the source properly.

Yes I agree mixed white space is evil and I set up coding standards elsewhere to avoid the problem, however, it is not a requirement here.

I've provided details of the data below as examining the generated display from Codestriker showed that Codestriker is not expanding tabs consistently and is definitely a bug in Codestriker.

The problem seems to be something interfering with correct tab expansion logic when a line has parenthesis '(' or ')' in them.  Lines with a parenthesis in them do not have correct tab expansion of 4 or 8 spaces.

Please review the data I originally presented to see the problem.  There are no mixed space/tab lines yet the tabs get unevenly substituted for spaces.

This is also reflected in the 4 space expansion I've provided.  Once again there is irregular tab expansion on lines ith parenthesis on them.

Bye for now,

Chris

-----Original Message-----
From: David Sitsky [mailto:david.sitsky@...] 
Sent: Sunday, March 04, 2012 7:11 PM
To: Chris Welch
Cc: codestriker-user@...
Subject: Re: [Codestriker-user] Problems with tab expansion in codestriker

Hi Chris,

This is the problem with tabs.. and why in my work place, our IDEs
specifically are setup to not use them.  What you are seeing is quite
normal, if you load your file into an editor with different tab-stops
(8 instead of 4), you'll see the same behaviour.

Cheers,
David

On Thu, Mar 1, 2012 at 2:30 AM, Chris Welch <Chris.Welch@...> wrote:
> Using Codestriker 1.9.10 with SVN 1.6, getting tab expansion problems.  See the following:
>
>
> 458            if( attempt_num < 4 )
> 459                         ++attempt_num;
> 460           else
> 461                     TSK_sleep( ticks_per_attempt );
> 462          } while( PRD_getticks() < end_tick );
>
> The tab expansion setting is at 8 for this display.  I did an od dump of the patch looking at the data representing lines 459 and 461 that they both have three tab chars and nothing else before the text, yet they have unequal tab expansion.
>
> This patch has the following white space prior to the text on the lines:
>
> Line 458 two tab lead in, nothing else
> Line 459 three tab lead in, nothing else
> Line 460 two tab lead in, nothing else
> Line 461 three tab lead in, nothing else
> Line 462 one tab lead in, nothing else
>
> Changing the display setting to 4 spaces per tabs yields:
>
> 458        if( attempt_num < 4 )
> 459             ++attempt_num;
> 460       else
> 461             TSK_sleep( ticks_per_attempt );
> 462      } while( PRD_getticks() < end_tick );
>
> Any ideas what the problem is?
>
> Tx,
>
> Chris
>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Codestriker-user mailing list
Codestriker-user@...
https://lists.sourceforge.net/lists/listinfo/codestriker-user