Bugs item #1174685, was opened at 2005-04-01 00:32
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1174685&group_id=9655
Category: xine
Group: v1.0
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: input_cdda.c: dummy instance didn't initailize fd&net_fd
Initial Comment:
In input_cdda.c - -> cdda_class_get_autoplay_list(),
line2387--2394
if (!ip) {
/* we need an instance pointer to store all the details
about the
* device we are going to open; but it is possible that
this function
* gets called, before a plugin instance has been
created;
* let's create a dummy instance in such a condition
*/
ip = (cdda_input_plugin_t *)xine_xmalloc(sizeof
(cdda_input_plugin_t));
ip->stream = NULL;
}
should add initalizaiton of ip->fd & ip->net_fd.
if (!ip) {
ip = (cdda_input_plugin_t *)xine_xmalloc(sizeof
(cdda_input_plugin_t));
ip->stream = NULL;
ip->fd = -1;
ip-> net_fd = -1;
}
otherwise. in line 2424, the call of cdda_close(ip); will
close initialized net_fd.
===============
moting9@...
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2005-04-01 00:34
Message:
Logged In: NO
sorry, the last two line should be
"otherwise. in line 2424, the call of cdda_close(ip); will
close uninitialized net_fd."
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1174685&group_id=9655
|