On Tue, 2002-11-12 at 00:02, Tripp Lilley wrote:
> I don't want to make this change until I'm sure I know it won't break
> anything :)
> I believe that, in this code, the check if
> self._actionSet().hasKey(action) is superfluous:
> # Check for actions
> for action in self.actions():
> if req.hasField('_action_%s' % action) or \
> req.field('_action_', None) == action or \
> (req.hasField('_action_%s.x' % action) and \
> req.hasField('_action_%s.y' % action)):
> if self._actionSet().has_key(action):
> Since the call comes inside of a loop where action is defined as a member
> of self.actions(), and _actionSet is created from self.actions(), there's
> no need to check it again, right?
Indeed, you are correct.
> I realize _actionSet is useful for streamlining dispatch of old-style
> actions (when are those going away, BTW? :) ), so I'm not saying to remove
> it entirely. I'm just wondering if we can take this one check out?
They kind of have, though you can still use <input type=hidden
name="_action_" value="methodName>, and I don't see any reason to remove
that, but now it just acts equivalently to _action_methodName.