Viking GPS data editor and analyzer

Guilhem Bonnefille wrote:
> Hi,
>
> Now, it's done: the viking's history is now hosted on the Git service
> provided by SourceForge:
>   

Thanks for the great work, Guilhem.
It must've taken a lot of your time.

Quy

2009/3/27 Quy Tonthat <qtonthat@...>:
> It must've taken a lot of your time.

A little bit. But less than the work needed to rebase all my private
foolish/old/dead branches. :-)


-- 
Guilhem BONNEFILLE
-=- JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/

Guilhem Bonnefille wrote:
> 2009/3/27 Quy Tonthat <qtonthat@...>:
>   
>> It must've taken a lot of your time.
>>     
>
> A little bit. But less than the work needed to rebase all my private
> foolish/old/dead branches. :-)
>   

Well, we have to pay prices for our obsession for perfection, don't we.

Quy

Great. We will add this info in the wiki as soon as possible.

Did you make some modifications you want to push back to official repo?

Regards,
-- 
Guilhem BONNEFILLE
-=- JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/

On Tue, Mar 24, 2009 at 01:24:32PM +0100, Guilhem Bonnefille wrote:
> Great. We will add this info in the wiki as soon as possible.
> 
> Did you make some modifications you want to push back to official repo?

No, no changes were made, it's a vanilla build. I plan to add an OS X .app
folder in order to be able to start viking as any other app (not from the
cli), once I've figured out how that works (I'm coming from Linux and am still
new to OS X). But those files don't necessarily need to be added to the
official repo, they could be part of the Portfile living in the Macports
repository (looking at other apps like Vim etc. this seems to be the common
procedure if you're not developing a "native" OS X version of the
application).

Btw, there's no such thing like an official Viking icon which could be used
for the application launcher icon yet (on either Linux/Win/OSX), or did I miss
sth.?

Michael

-- 
Michael Klier

www:    http://www.chimeric.de
jabber: chi@...
key:    http://downloads.chimeric.de/chi.asc
key-id: 0x8308F551

2009/3/24 Michael Klier <chi@...>:
> No, no changes were made, it's a vanilla build. I plan to add an OS X .app
> folder in order to be able to start viking as any other app (not from the
> cli), once I've figured out how that works (I'm coming from Linux and am still
> new to OS X). But those files don't necessarily need to be added to the
> official repo, they could be part of the Portfile living in the Macports
> repository (looking at other apps like Vim etc. this seems to be the common
> procedure if you're not developing a "native" OS X version of the
> application).

OK.

> Btw, there's no such thing like an official Viking icon which could be used
> for the application launcher icon yet (on either Linux/Win/OSX), or did I miss
> sth.?

Yu can find an icon as src/icons/viking.png.

-- 
Guilhem BONNEFILLE
-=- JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/

Hi,

Le 10 mars 2009, Jon Burgess a écrit :
> I have been seeing crashes when I click on the right hand side of the
> speed/time graph for a track. The track has about a minute of 0km/h
> points at the end and it looks like problem may occur when it tries to
> calculate the corresponding position on the elevation/distance graph. 
> 
> Printing out some of the variables gives:
> 
> [jburgess@...
> src]$ ./viking event_x=817.000000 img_width=990 x=657.000000, limit
> 670 x2(829.8104323)
> width(990) event_x=829.810432 img_width=990 x=669.810432, limit 670
> The program 'viking' received an X Window System error.
> ...
> 
> I believe the problem one is "x=669.810432, limit 670". When
> draw_graph_mark() tries to save +-saved_width/2, the upper bound goes
> beyond 670. The attached patch fixes it for me.
> 
> One odd thing is that this only seems to happen if the very first
> click is on the RHS, if I click anywhere else first, then the click
> on the right there is no crash.

It looks like the same problem than the one on
https://sourceforge.net/tracker/index.php?func=detail&aid=1947453&group_id=83870&atid=570956
and I can see the bug with all the gpx traces I have checked.

If I correctly understand your patch, it will make it impossible to
have a bar printed on the few last values. I think that a better way
to fix the problem is to change saved_width to 1, as we only draw a
line, so only a 1-pixel-large column needs to be saved.

A simple patch for this is attached. This could be refined to remove
all mention of saved_width in the code.

The bug is in fact caused because we try to save data which is not
available on the picture drawn (the width of the saved data exceed the
pixmap). But I don't understand why it doesn't crash on next click on
the right edge...

Thanks,
Jocelyn

On Tue, 2009-03-17 at 23:40 +0100, Jocelyn Jaubert wrote:
> Hi,
> 
> Le 10 mars 2009, Jon Burgess a écrit :
> > I have been seeing crashes when I click on the right hand side of the
> > speed/time graph for a track. The track has about a minute of 0km/h
> > points at the end and it looks like problem may occur when it tries to
> > calculate the corresponding position on the elevation/distance graph. 
> > 
> > Printing out some of the variables gives:
> > 
> > [jburgess@...
> > src]$ ./viking event_x=817.000000 img_width=990 x=657.000000, limit
> > 670 x2(829.8104323)
> > width(990) event_x=829.810432 img_width=990 x=669.810432, limit 670
> > The program 'viking' received an X Window System error.
> > ...
> > 
> > I believe the problem one is "x=669.810432, limit 670". When
> > draw_graph_mark() tries to save +-saved_width/2, the upper bound goes
> > beyond 670. The attached patch fixes it for me.
> > 
> > One odd thing is that this only seems to happen if the very first
> > click is on the RHS, if I click anywhere else first, then the click
> > on the right there is no crash.
> 
> It looks like the same problem than the one on
> https://sourceforge.net/tracker/index.php?func=detail&aid=1947453&group_id=83870&atid=570956
> and I can see the bug with all the gpx traces I have checked.

This appears to be the same issue.

> If I correctly understand your patch, it will make it impossible to
> have a bar printed on the few last values. I think that a better way
> to fix the problem is to change saved_width to 1, as we only draw a
> line, so only a 1-pixel-large column needs to be saved.

I did not notice any issues myself, I think it just stopped the code
saving/restoring these last few pixels, it did not prevent you selecting
them. I thought it might cause some black bars to get left on the edge
of the graph but I never noticed any.

> A simple patch for this is attached. This could be refined to remove
> all mention of saved_width in the code.

I guess saving just 1 pixel would be fine, but I can not say what the
original author intended.

> The bug is in fact caused because we try to save data which is not
> available on the picture drawn (the width of the saved data exceed the
> pixmap). But I don't understand why it doesn't crash on next click on
> the right edge...

I could not work that out either. Perhaps something in GDK or the X
server caches the pixmap dimensions on the first response and ignores
the future invalid requests.

	Jon

My previous script was totally wrong. Here is a better one.

I also pushed the result at
http://repo.or.cz/w/viking/guyou.git?a=shortlog;h=refs/heads/rewriten

Feel free to double check these commits. There are 709 commits, but we
will do this conversion ONLY ONCE.


Related to this, I have a question for guys familiar with Git. What is
the meaning of "Signed-of-by" tag? When to use, when not?
I understand we have to use this tag every time we are not the author,
in order to keep a log of who reviewed the commit. Am I right?
If so, I will improve my script to add Signed-of-by tag in any comment
where commiter is different than author.
-- 
Guilhem BONNEFILLE
-=- #UIN: 15146515 JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/

Guilhem Bonnefille wrote:
> Related to this, I have a question for guys familiar with Git. What is
> the meaning of "Signed-of-by" tag? When to use, when not?
> I understand we have to use this tag every time we are not the author,
> in order to keep a log of who reviewed the commit. Am I right?
> If so, I will improve my script to add Signed-of-by tag in any comment
> where commiter is different than author.
>   

"Signed-of-by" is only there when a commit is done
with "git commit -s", a choice made by the committer.
(I would recommend doing that when we switch to git)
So I think we should keep the tag if it is there
but not to add it in even if the authour and the committer
are different.

Quy

2009/3/5 Quy Tonthat <qtonthat@...>:
> Guilhem Bonnefille wrote:
>> Related to this, I have a question for guys familiar with Git. What is
>> the meaning of "Signed-of-by" tag? When to use, when not?
>> I understand we have to use this tag every time we are not the author,
>> in order to keep a log of who reviewed the commit. Am I right?
>> If so, I will improve my script to add Signed-of-by tag in any comment
>> where commiter is different than author.
>>
>
> "Signed-of-by" is only there when a commit is done
> with "git commit -s", a choice made by the committer.
> (I would recommend doing that when we switch to git)
> So I think we should keep the tag if it is there
> but not to add it in even if the authour and the committer
> are different.

OK. But what is the meaning of this tag for you?


-- 
Guilhem BONNEFILLE
-=- #UIN: 15146515 JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/

Guilhem Bonnefille wrote:
> 2009/3/5 Quy Tonthat <qtonthat@...>:
>   
>> Guilhem Bonnefille wrote:
>>     
>>> Related to this, I have a question for guys familiar with Git. What is
>>> the meaning of "Signed-of-by" tag? When to use, when not?
>>> I understand we have to use this tag every time we are not the author,
>>> in order to keep a log of who reviewed the commit. Am I right?
>>> If so, I will improve my script to add Signed-of-by tag in any comment
>>> where commiter is different than author.
>>>
>>>       
>> "Signed-of-by" is only there when a commit is done
>> with "git commit -s", a choice made by the committer.
>> (I would recommend doing that when we switch to git)
>> So I think we should keep the tag if it is there
>> but not to add it in even if the authour and the committer
>> are different.
>>     
>
> OK. But what is the meaning of this tag for you?
>   

It depends on projects/environments:
Approved by, committed by, cherry-picked by, done by...
(There can be more than one "Signed-of-by"
in one log message)
Quy

Hi,

Le 4 mars 2009, Guilhem Bonnefille a écrit :
> My previous script was totally wrong. Here is a better one.
> 
> I also pushed the result at
> http://repo.or.cz/w/viking/guyou.git?a=shortlog;h=refs/heads/rewriten
> 
> Feel free to double check these commits. There are 709 commits, but we
> will do this conversion ONLY ONCE.

I did a quick check, and that seems correct.

But I don't see any tags for viking releases. Will you add them to the
final git repository ?

If you are happy with this, I would like the switch to git to be done
as soon as possible: I have some patchs waiting in my local repository
that I would like to port to the "official" one.


Thanks,
Jocelyn

2009/3/15 Jocelyn Jaubert <jocelyn.jaubert@...>:
> I did a quick check, and that seems correct.

Thanks.

> But I don't see any tags for viking releases. Will you add them to the
> final git repository ?

Yes, you're right, I just forgave them. I also forgave branches hosted
in Subversion, but I think we can consider they are definitively dead.
Nevertheless, I will check why they are not processed by my script.

> If you are happy with this, I would like the switch to git to be done
> as soon as possible: I have some patchs waiting in my local repository
> that I would like to port to the "official" one.

Yes, me too. I still wait for some confirmations. I hope to do the
conversion for the end of the week, if everything is OK.

-- 
Guilhem BONNEFILLE
-=- JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/

Hi Greg,

Welcome to the viking's community!

Concerning WMS, I also imagine it would be great to have some support
in viking. I wished to start it, but other priorities... So, feel free
to contribute.
Concerning the hability to add a WMS layer by setting its URL
somewhere, please, do not spend time on this. I have a significant
rewrite of map system that can add such feature easily. So, I suggest
you to add WMS support with a hard coded URL. Then, we will
*generalize* this job together.

Best regards,
Guilhem


Le 14 mars 2009 21:40, Greg Troxel <gdt@...> a écrit :
> I'm new to using viking.  I just added a package for it to pkgsrc,
> contributed by Jochen Kunz.  (pkgsrc is the packaging control system for
> NetBSD and Dragonfly, and runs on many other systems, including Solaris
> and Macs.)
>
> I was able to get OSM tiles when I first started, at someplace more or
> less in the middle of my track.  I was able to pan.  But after I zoomed
> in and out, I wasn't able to get them any more.  I was not able to
> figure out why.  What I think is that there is some set of zoom levels
> that work for WMS tiles, and I was somehow not at one of those zooms.
> If that's right, then I'd like to suggest quantizing the zoom level to a
> WMS level, and display e.g. z14 somewhere.
>
> It was not obvious how to set things up so that on opening a trackfile I
> have the map layer I usually want.
>
> There was no documentation that explained the privacy aspects of which
> tiles get requested (probably obvious, but would be good to minimize the
> information leakage), and how to set up caching of those tiles so they
> can be used from local disk.  Perhaps this isn't implemented, but it
> would be nice.
>
> It would be cool to be able to add a WMS layer by URL, so one could set
> up mapnik locally to render OSM data without the net, for use when
> disconnected.
>
> Starting In 2000 I wrote a library libdrg to mosaic together USGS DRGs
> that are tiff in NAD27, and have overlaid track in them with xplot.  I
> wonder about using that as a backing layer.  I will try to get it
> straightened out a little bit so it's usable by others.
>
> ------------------------------------------------------------------------------
> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> _______________________________________________
> Viking-devel mailing list
> Viking-devel@...
> https://lists.sourceforge.net/lists/listinfo/viking-devel
> Viking home page: http://viking.sf.net/
>



-- 
Guilhem BONNEFILLE
-=- JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/

Hi,

Le 4 mars 2009, Mathieu Albinet a écrit :
> 2009/3/3 Guilhem Bonnefille <guilhem.bonnefille@...>:
> > So, if you
> > decide to move some page from the old wiki to the new one, please,
> > remove the old page (or replace whole content by a single sentence)
> > in order easily identify page moved and other.
> 
> Maybe it's also the occasion to restructure the content of the site
> but I have to say that it's not very user friendly. There is a lot of
> information (not enough) but very hard to find. Moreover it's totally
> developper oriented and not for the end user.
> If we try to copy some other open source project, we can have
> something structured like this (most of it is already in the menu at
> the left of the screen but it should also go in the main page)

I wanted to move the pages from the old wiki to the new one, by
following Mathieu's suggestion, but I cannot edit the main page.

Can anybody allow edit to all sourceforge accounts, or at least my
account (which is jocelynj) ?

Thanks,
Jocelyn

Hi,

I did not yet checked how this mediawiki is configured and how it is
tied to SourceForge. But I found how to add "Edit" priviledge to the
user "jocelynj". Do not hesitate to report any other PB.

2009/3/14 Jocelyn Jaubert <jocelyn.jaubert@...>:
> Hi,
>
> Le 4 mars 2009, Mathieu Albinet a écrit :
>> 2009/3/3 Guilhem Bonnefille <guilhem.bonnefille@...>:
>> > So, if you
>> > decide to move some page from the old wiki to the new one, please,
>> > remove the old page (or replace whole content by a single sentence)
>> > in order easily identify page moved and other.
>>
>> Maybe it's also the occasion to restructure the content of the site
>> but I have to say that it's not very user friendly. There is a lot of
>> information (not enough) but very hard to find. Moreover it's totally
>> developper oriented and not for the end user.
>> If we try to copy some other open source project, we can have
>> something structured like this (most of it is already in the menu at
>> the left of the screen but it should also go in the main page)
>
> I wanted to move the pages from the old wiki to the new one, by
> following Mathieu's suggestion, but I cannot edit the main page.
>
> Can anybody allow edit to all sourceforge accounts, or at least my
> account (which is jocelynj) ?
>
> Thanks,
> Jocelyn
>
> ------------------------------------------------------------------------------
> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> _______________________________________________
> Viking-devel mailing list
> Viking-devel@...
> https://lists.sourceforge.net/lists/listinfo/viking-devel
> Viking home page: http://viking.sf.net/



-- 
Guilhem BONNEFILLE
-=- JID: guyou@... MSN: guilhem_bonnefille@...
-=- mailto:guilhem.bonnefille@...
-=- http://nathguil.free.fr/