Das U-Boot - Universal Bootloader

On Sun, 13 May 2007 01:19:07 +0200
Rodolfo Giometti <giometti@...> wrote:

> Using serial console with a bootdelay of only 1 second is ok, but
> using usbtty is not. In fact is not possible to stop boot sequence
> anymore unless bootdelay is increased at least 10-15 seconds needed
> to run the terminal on the new ttyUSB0 device and to enter the
> password.
> 
> Also I notice that when usbtty is selected as the default console
> the system doesn't start up until I connect the kermit/minicom to
> the new ttyUSB0 device.


Hmm, you might want to change

unsigned int len = 0;
while(len > 0) {
	usbtty_poll();

	space = maxlen - usbtty_output.size;
	if(space){
		/* Do stuff */
	}
}

to


/* Not tested */
unsigned int len = 0;
while(len > 0) {
	usbtty_poll();

	/* Do stuff */
}

in __usbtty_puts()


puts() I guess _should_ be a 'best effort'. Better, still, maybe
we could add an environment variable which would switch puts()
between flow-control and 'best effort', so that people have the
choice.

/* Not tested */
unsigned int len = 0;
while(len > 0) {
	usbtty_poll();
	space = maxlen;

	if(environment_variable_use_tty_flow_control)
		space = maxlen - usbtty_output.size;
	
	if(space){
		/* Do stuff */
	}
}


Bryan

In message <46465158.5070602@...> you wrote:
>
> > The limit on the length of lines is 80 columns and THIS IS A HARD
> > LIMIT.
...
> Does :set ts=4 count?  It fits in 80 columns then. ;-)

No, this does not count, as it violates another part of the Coding
Style document:

"Tabs are 8 characters, and thus indentations are also 8 characters.
There are heretic movements that try to make indentations 4 (or even 2!)
characters deep, and that is akin to trying to define the value of PI to
be 3."

> The nesting is getting me in trouble.  I can fix some, but some would be 
> ugly to fix because I would need to split strings.  I could move the 
> value parsing into a subroutine, that would help.

"... The answer to that is that if you need
more than 3 levels of indentation, you're screwed anyway, and should fix
your program.

In short, 8-char indents make things easier to read, and have the added
benefit of warning you when you're nesting your functions too deep.
Heed that warning."

> Since the LIMIT IS HARD, I'll work it...

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,    CEO: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@...
Speed of a tortoise breaking the sound barrier         = 1 Machturtle