TortoiseHg

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

josschne on Mon, 10 Aug 2009 18:56:17 +0200:

Comment:
  Sorry, meant 40,000 files.  Also should add that the event log shows the notifications happening ~7 seconds apart.  I assume this is because of the 5 second "hg status" call, plus the 2 second sleep in the code between shell nofitication.

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

Adrian Buehlmann / abuehl on Mon, 10 Aug 2009 19:02:21 +0200:

Comment:
  A huge repo, indeed. I assume it is not publicly available? (although I'm not keen to download 1GB... :)

Quick stupid first question: Did you try a reboot?

What happens if you do the following:

# Exit the taskbar app (right click on mercurial tray icon in taskbar and choose "Exit")
# Delete the file .hg/thgstatus in your repo
# Open a command shell (cmd.exe) in the root folder of your repo and execute "hgtk thgstatus"

Now open an explorer window and navigate into your repo. Are the icons ok?

Then logout (make sure all users are logged out from your computer) and login.

Just for the record: What version of Windows is that, 32bit or 64bit?

If you don't want to spend more time with this problem: as a workaround you can disable
the overlay icons (and the updating) for a specific repo by overwriting the file .hg/thgstatus with the string "@@noicons" (make sure thgtaskbar.exe is not running when writing the file). 

Changes:
  status: new -> open
  component: status -> overlays

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

josschne on Mon, 10 Aug 2009 21:10:03 +0200:

Comment:
  Tried a reboot, same issue reproduces after a reboot.

After quitting the taskbar app and manually deleting and refreshing the status file, the icons look correct.  After logging out/in, the taskbar app was again running and the refresh issue was reproduced again.

This is on 32bit Windows XP SP2.

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

Adrian Buehlmann / abuehl on Mon, 10 Aug 2009 22:16:25 +0200:

Comment:
  Ok. Thanks for reporting. I've never tested the thgtaskbar.exe and THgShell.dll with such a huge repo.

Maybe I can try simulate a slow hg status call (this is what thgtaskbar basically does) by inserting a wait call and see if I can reproduce the update loop and think about how a fix should look like.

On another note, we might be able to offer a manual update of the folder icons through the "update icons" context menu command for the case when thgtaskbar.exe is (intentionally) not running.

The .hg/thgstatus file is only needed for the icons on the **folders** and thgtaskbar.exe updates that. If .hg/thgstatus doesn't exist, you get the question mark icons on the folders, but the icons on the files are still correct independently, as those are produced from reading .hg/dirstate and comparing file modification dates and sizes.

If thgtaskbar.exe is not running you can manually update .hg/thgstatus of any repo with "hgtk thgstatus". There is also a small helper batch "refreshicons.cmd" in the contrib dir of the installation folder that can be used. Copy it into the directory where you have all your repos and double click it to update the icons of your repos (use only if thgtaskbar.exe is not running).

In 0.8.1 the explorer shell extension ("THgShell.dll") triggers the thgtaskbar.exe through a named pipe (inter process communication). If the thgtaskbar.exe is not running, the shell extension does nothing but report an error message to the debug out. We could instead spawn a process and do a "hgtk thgstatus" if it was triggered by a context menu "update icons". Like this, we could offer a manual update of the folder icons. This would make sense for very big repos.

Anyway, I will see if I can find out something about the endless update loop.

In case you are interested, you can install and run Debug View from http://technet.microsoft.com/en-us/sysinternals/bb896647.aspx . The shell extension emits debug output there.

Example output 1:

{{{
[2536] [THG] findHgRoot(W:\yyy\bb.txt): hgroot = 'W:\yyy' (found repo)
[2536] [THG] DirectoryStatus::read(W:\yyy): done. 0 entries read. noicons_ = 0
[2536] [THG] Dirstatecache::get: lstat(W:\yyy\.hg\dirstate) ok 
[2536] [THG] Dirstatecache::get: dropping W:\xxx
[2536] [THG] Dirstatecache::get: reading W:\yyy
[2536] [THG] Dirstatecache::get: read done in 0 ticks, 10 repos in cache
[2536] [THG] Thgstatus::update: sending 'update|W:\yyy' to \\.\pipe\TortoiseHgRpcServer-bc0c27107423-adi
[2536] [THG] findHgRoot(W:\yyy\bb.txt): hgroot = 'W:\yyy' (found repo)
[2536] [THG] findHgRoot(W:\yyy\bb.txt): hgroot = 'W:\yyy' (found repo)
[2536] [THG] DirectoryStatus::read(W:\yyy): done. 0 entries read. noicons_ = 0
[2536] [THG] Dirstatecache::get: lstat(W:\yyy\.hg\dirstate) ok 
}}}

Example output 2 (thgtaskbar.exe not running):

{{{
[2536] [THG] CShellExt::InvokeCommand
[2536] [THG] CShellExt::InvokeCommand: idCmd = 8
[2536] [THG] Thgstatus::update: sending 'remove|W:\yyy' to \\.\pipe\TortoiseHgRpcServer-bc0c27107423-adi
[2536] [THG] Thgstatus::update: CallNamedPipeA failed (2)
}}}





-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

josschne on Mon, 10 Aug 2009 23:35:40 +0200:

Comment:
  DebugView snippet:

{{{
[2864] [THG] findHgRoot(G:\<repo>\.sbas): hgroot = 'G:\<repo>' (found repo)
[2864] [THG] DirectoryStatus::read(G:\<repo>): done. 16 entries read. noicons_ = 0
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] Dirstatecache::get: refreshing G:\<repo>
[2864] [THG] Dirstatecache::get: has unset entries
[2864] [THG] Dirstatecache::get: read done in 731 ticks, 1 repos in cache
[2864] [THG] Thgstatus::update: sending 'update|G:\<repo>' to \\.\pipe\TortoiseHgRpcServer-bc0c27107423-<user>
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] findHgRoot(G:\<repo>\.sbas): hgroot = 'G:\<repo>' (found repo)
[2864] [THG] DirectoryStatus::read(G:\<repo>): done. 16 entries read. noicons_ = 0
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] Dirstatecache::get: refreshing G:\<repo>
[2864] [THG] Dirstatecache::get: has unset entries
[2864] [THG] Dirstatecache::get: read done in 591 ticks, 1 repos in cache
[2864] [THG] Thgstatus::update: sending 'update|G:\<repo>' to \\.\pipe\TortoiseHgRpcServer-bc0c27107423-<user>
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] findHgRoot(G:\<repo>\.sbas): hgroot = 'G:\<repo>' (found repo)
[2864] [THG] DirectoryStatus::read(G:\<repo>): done. 16 entries read. noicons_ = 0
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] findHgRoot(G:\<repo>\.sbas): hgroot = 'G:\<repo>' (found repo)
[2864] [THG] DirectoryStatus::read(G:\<repo>): done. 16 entries read. noicons_ = 0
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] Dirstatecache::get: refreshing G:\<repo>
[2864] [THG] Dirstatecache::get: has unset entries
[2864] [THG] Dirstatecache::get: read done in 530 ticks, 1 repos in cache
[2864] [THG] Thgstatus::update: sending 'update|G:\<repo>' to \\.\pipe\TortoiseHgRpcServer-bc0c27107423-<user>
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] findHgRoot(G:\<repo>\.sbas): hgroot = 'G:\<repo>' (found repo)
[2864] [THG] DirectoryStatus::read(G:\<repo>): done. 16 entries read. noicons_ = 0
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 
[2864] [THG] Dirstatecache::get: refreshing G:\<repo>
[2864] [THG] Dirstatecache::get: has unset entries
[2864] [THG] Dirstatecache::get: read done in 591 ticks, 1 repos in cache
[2864] [THG] Thgstatus::update: sending 'update|G:\<repo>' to \\.\pipe\TortoiseHgRpcServer-bc0c27107423-<user>
[2864] [THG] Dirstatecache::get: lstat(G:\<repo>\.hg\dirstate) ok 

}}}

The thing that caught my eye is "has unset entries".  Haven't checked out the code, but should that be appearing all the time?

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

Adrian Buehlmann / abuehl on Tue, 11 Aug 2009 00:12:28 +0200:

Comment:
  The unset entries thing is a nastiness that mercurial leaves in the .hg/dirstate file. It's by design.

See http://mercurial.selenic.com/wiki/DirState for the gory details.

The shell extension (explorer.exe, that is) never writes .hg/dirstate. It only reads it.

Processes like "hg status" or "hgtk thgstatus" or "thgstatus.exe doing an update" all fix them as a side effect (that is, they eliminate the unset entries in .hg/dirstate -- at least they **should **if they work as expected).

You can often see unset entries after a largeish 'hg update' (or after a 'hg clone', which implies by default a 'hg update' at the end).

Various conditions trigger the shell extension to send an update request to thgstatus.exe. Unset entries in .hg/dirstate are one of them.

In other words, if the shell extension finds an unset entry in .hg/dirstate, it sends an update request to thgstatus.exe, which in turn implies a 'hg status' (basically), which causes a rewrite of .hg/dirstate. thgstatus.exe then sends a request to the "shell" (explorer.exe) to refresh the overlay icons, which in turn triggers the shell extension to reread .hg/dirstate.

So, unset entries are normal and expected. The thing that isn't expected is the endless update loop you see. We might have some timing/racing bug(s) left lurking in that whole system that affect huge repos.

The duration of hg status in itself shouldn't be a problem. If everything would work fine, it should just take whatever time it needs to update the icons -- that's all. ~5 or 7 seconds on such a huge repo wouldn't be that bad. 

I will try to investigate this tomorrow (UTC+2).


-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

Adrian Buehlmann / abuehl on Tue, 11 Aug 2009 00:24:11 +0200:

Comment:
  Sorry, I meant 'thgtaskbar.exe' instead of 'thgstatus.exe'


-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 480: Endless refresh status loop
http://bitbucket.org/tortoisehg/stable/issue/480/endless-refresh-status-loop

Adrian Buehlmann / abuehl on Tue, 11 Aug 2009 00:30:58 +0200:

Comment:
  BTW, 'unset' entries in .hg/dirstate lead to false 'modified' overlay icons on files in explorer. Although they should be momentarily only, if everything works as expected.


-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 481: UI for hg rebase
http://bitbucket.org/tortoisehg/stable/issue/481/ui-for-hg-rebase

Steve Borho / sborho on Mon, 10 Aug 2009 20:13:07 +0200:

Comment:
  Not too difficult, especially if you use hgcmd to do the rebase command.  Feel like making a patch for it?

Changes:
  status: new -> open
  component: nothing -> history
  version: 0.8.1 -> 0.9

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 481: UI for hg rebase
http://bitbucket.org/tortoisehg/stable/issue/481/ui-for-hg-rebase

Dimitris Glezos / glezos on Mon, 10 Aug 2009 21:21:59 +0200:

Comment:
  Sure. Could you point me to a changeset in history which added the most close functionality to this one?

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 481: UI for hg rebase
http://bitbucket.org/tortoisehg/stable/issue/481/ui-for-hg-rebase

Steve Borho / sborho on Mon, 10 Aug 2009 21:35:15 +0200:

Comment:
  See <<cset 6f9e9bde65a6>>

history: allow to send bundles and mails from a range

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 479: Diff viewer does not display diffs on the fly for files in subdirectories.
http://bitbucket.org/tortoisehg/stable/issue/479/diff-viewer-does-not-display-diffs-on-the-fly-for-files-in

Steve Borho / sborho on Mon, 10 Aug 2009 16:02:57 +0200:

Comment:
  I can't reproduce this on the stable branch, but I can reproduce this on the tip of default.  The new text diff pane is not showing changes but the hunk selection pane is.

Is that what you find as well?

Changes:
  status: new -> open
  component: nothing -> status

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 479: Diff viewer does not display diffs on the fly for files in subdirectories.
http://bitbucket.org/tortoisehg/stable/issue/479/diff-viewer-does-not-display-diffs-on-the-fly-for-files-in

Adrian Buehlmann / abuehl on Mon, 10 Aug 2009 16:45:09 +0200:

Comment:
  With f2d21d7c732b (default tip) I get

{{{
#!python
** Please report this bug to tortoisehg-discuss@... or http://bitbucket.org/tortoisehg/stable/issues
** Mercurial version (unknown).  TortoiseHg version (unknown)
** Command: --nofork log
** CWD: W:\thg-stable
** Extensions loaded: mq, graphlog, rebase, forest, pbranch
Recoverable runtime error (stderr):
Traceback (most recent call last):
  File "W:\thg-stable\hggtk\status.py", line 453, in realize_status_settings
    self.reload_status()
  File "W:\thg-stable\hggtk\status.py", line 591, in reload_status
    self.update_check_count()
  File "W:\thg-stable\hggtk\status.py", line 439, in update_check_count
    self.get_toolbutton(_('_Diff')).set_sensitive(sensitive)
  File "W:\thg-stable\hggtk\gdialog.py", line 302, in get_toolbutton
    return self.toolbuttons[label]
KeyError: '_Diff'

}}}

when closing the log window

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 479: Diff viewer does not display diffs on the fly for files in subdirectories.
http://bitbucket.org/tortoisehg/stable/issue/479/diff-viewer-does-not-display-diffs-on-the-fly-for-files-in

Steve Borho / sborho on Mon, 10 Aug 2009 16:49:33 +0200:

Comment:
  Just pushed a fix for that a few minutes ago

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.

Issue 478: "About" frm explorer context menu produced error
http://bitbucket.org/tortoisehg/stable/issue/478/about-frm-explorer-context-menu-produced

Yuki KODAMA / kuy on Mon, 10 Aug 2009 07:23:48 +0200:

Comment:
  Already fixed.

Duplicate of #475.

Changes:
  status: new -> duplicate

-- 
This is an issue notification from bitbucket.org.
You are receiving this either because you are the
owner of the issue, or you are following the issue.