Sylvie Greverend wrote:
> Josef Drexler wrote:
>>Well, the "inline" option is just another diff option, so that should be
>>no problem. In my case it's the default option because I like it better,
>>but I can put it below side-by-side as well.
>
> In admin->wiki, there is already a choice between old style and no style. I
> think it will be easy to put your choice there
Right.
>>However, changing the
>>character based diff to word based diff might need to be an additional
>>option somewhere (although I consider the char based diff to be rather
>>broken...). If so, what would be a good place for it?
>
> Isn't it another renderer? If it is, it can be easy to change
> renderer_character with renderer_word
> I think that it was on character basis because when it was developped, it
> was to copy mediawiki. It seems that mediawiki now is on a word basis too.
> So it is a good move, I think... But as Damian said, tw has a (sometimes
> stupid) rule to keep change optional
Well, I didn't think of adding a word renderer in addition to a char
renderer, so atm in my code it just replaces it. In principle, having both
wouldn't be difficult though, so I can make it an option as well.
>>Also, could making the "#" character in ((...)) links use anchors cause
>>any problems? I don't know if it's a valid character in the page name.
>>Since it's a special character in URLs I doubt anyone would use it for
>>anything else, though.
>
> As Marc said, I don't know why it is dynamic. For me it is a bug.
> I saw you based the anchor name on the heading text. What happens if you
> change the heading text
Then the anchor changes (along with the {maketoc} links). If someone wants
to keep the old anchor in addition to the new one, they'll have to manually
add one with the ANAME plugin.
There is currently no provision for cases where several headings are the
same, e.g.
!Chapter 1
!!Summary
!!Text
!Chapter 2
!!Summary
!!Text
Here linking to either of the Summary or Text sections will be unreliable,
but in such cases, users can always manually add unique anchors as well. My
change was mainly to facilitate linking to sections directly without having
to edit the page to insert anchors, and especially being able to copy&paste
the link made by {maketoc} without having to read the page source to find
out what the anchor is actually called.
>>>All we need to know is your SourceForge username and away you go.
>>
>>I'm jdrexler on SourceForge.
>
> Welcome aboard tw.
Thanks!
--
Josef Drexler
|