Hi Gary and all - cc'ing tikiwiki-artwork too as this is relevant
there too
I agree stuff like diff colours etc should be there and i worked out
your hex vs colour names scheme and generally agree with that
approach, but maybe it should be the other way round so you can do a
search to easily find them all (i.e. find the ones your _should_
override you search for #, whereas now you'd have to do a tricky
regexp to find lines containing "color" but not "#" - just a
thought... maybe too late?)
I too am mid-way through layout-ifying my themes and i'm finding quite
a few selectors that seem to be in the wrong place (in 3.x) - for
instance: line 135+ .floatright and left being in the middle of the
siteheader section - for 4.x we should think about moving them to the
Misc. Global section which you should never (usually) need to override
(and others)
I think all the empty selectors need to be somewhere, so maybe there
could be a layout-reference.css file there for these?
Also, how about a small as possible layout-import-template.css that
people can use as a start for their own themes? (and an even smaller
layout-import-option-template.css there too?)
Anyway, it's a great start, and undoubtedly a major step forward for
tiki's css - thank you so much for all this work!
Back to work...
jonny
On 9 Jul 2009, at 15:00, Gary Cunningham-Lee wrote:
> Hi Jonny,
>
> I've been thinking about layout.css, too, now that the dust is
> settling
> after the 3.x releases. About the colors in layout.css, there are some
> that I put as kind of placeholders, assuming every theme would want to
> have, for example, .rbox (warning, etc.,) title color, background
> color
> and border color. I made them bright and used colornames rather than
> hex
> codes to distiguish them as placeholders. But now that I've done a few
> more themes that import layout.css, I'm getting pretty tired of seeing
> them, so was just thinking I'd like to get rid of them.
>
> I put some colors in layout.css because I figured theme authors want,
> for example, wiki diff colors but don't want to spend time adding them
> to their theme stylesheet, so it's just a convenience.
>
> About layout.css being overweight, it does serve the purpose of
> containing pretty much all of the selectors in Tiki outside of the
> special-purpose CSS files, so is good as a reference. But whether this
> information needs to be in layout.css (especially the production
> version) is a good question. When you talk about slimming it down, do
> you mean just removing the empty selectors? Or do you mean to get
> rid of
> selectors that have properties? If the second thing, then I'd want to
> see what would be removed. It'd be good to have a layout.css "best
> practices" or statement about its purpose, guideline for what goes
> in, etc.
>
> If there are definitions in layout.css that are repeated in
> tikinewt.css, then obviously the overlap needs to be removed.
> tikinewt.css is about 30KB; the theme stylesheets I've done lately
> (which import layout.css) are between 10KB and 15KB. Seems like the
> stylesheets of existing themes are bulkier because more is defined
> (carried over from earlier versions). New themes are slimmer because I
> only defined the minimum, pretty much, to get the desired look.
>
> About the number that would be affected by layout.css changes, all the
> themes I've updated from Tiki 2 to Tiki 3 import layout.css, and I
> have
> more in the pipeline (updates and new themes), so a few dozen in all.
> But I don't mind making the adjustments if the stylesheets are working
> better overall.
>
> -- Gary
>
>
> Jonny Bradley wrote:
>> Hi Gary (including devels list)
>>
>> I did wonder about that, but in layout.css there's no float:left on
>> the .findtitle in layout.css so it doesn't need it on the .findsubmit
>> - in layout.css (as you can see by selecting the "Empty" theme) these
>> are centred on most pages, which is also ok.
>>
>> It just seemed wrong to have the input left and the button for it
>> centred to me.
>>
>> My preference is to have as little as possible in layout.css (and
>> equally as little as possible in themes that import it ;)
>>
>> While we're on this subject, i'm just about to embark on converting
>> my
>> "utopian" theme group to use layout and i think layout.css could/
>> should be slimmed down quite a bit. There are definitions for colours
>> (like yellow borders and some green bits) and i would like to
>> simplify
>> it quite a bit. Also, a lot of the definitions in layout are repeated
>> unnecessarily in tikinewt and so (i think) should be removed.
>>
>> Would it be ok if i have a go at optimising this? Are you (or anyone)
>> using layout on other themes yet? Or can i have a good rummage about
>> here without breaking too much stuff?
>>
>> Cheers
>>
>> jonny
>>
>>
>>
>> On 9 Jul 2009, at 03:26, Gary Cunningham-Lee wrote:
>>
>>
>>> Hi Jonny,
>>>
>>> Since tikinewt.css imports layout.css, this looks like the kind of
>>> change that should go to layout.css. I assume other importing themes
>>> would also need the go button fix. (But actually I don't see where
>>> this
>>> is a problem in tikinewt before the change, so if you would point
>>> that
>>> out, I'd appreciate it.) Anyway, what do you think about it being
>>> in
>>> layout.css instead?
>>>
>>> -- Gary
>>>
>>> jonnybradley@... wrote:
>>>
>>>> Revision: 20014
>>>> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=20014&view=rev
>>>> Author: jonnybradley
>>>> Date: 2009-07-08 19:05:41 +0000 (Wed, 08 Jul 2009)
>>>>
>>>> Log Message:
>>>> -----------
>>>> [FIX] Find "go" button should be next to the input field (float:
>>>> left)
>>>>
>>>> Modified Paths:
>>>> --------------
>>>> trunk/styles/tikinewt.css
>>>>
>>>> Modified: trunk/styles/tikinewt.css
>>>> ===================================================================
>>>> --- trunk/styles/tikinewt.css 2009-07-08 19:04:59 UTC (rev 20013)
>>>> +++ trunk/styles/tikinewt.css 2009-07-08 19:05:41 UTC (rev 20014)
>>>> @@ -730,7 +730,7 @@
>>>> letter-spacing: 1px;
>>>> color: #000}
>>>>
>>>> -.findtitle {float: left;}
>>>> +.findtitle, .findsubmit {float: left;}
>>>>
>>>> tr.odd {
>>>> border: 1px solid #8cacbb;
>>>>
>>>>
>>>> This was sent by the SourceForge.net collaborative development
>>>> platform, the world's largest Open Source development site.
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Enter the BlackBerry Developer Challenge
>>>> This is your chance to win up to $100,000 in prizes! For a limited
>>>> time,
>>>> vendors submitting new applications to BlackBerry App World(TM)
>>>> will have
>>>> the opportunity to enter the BlackBerry Developer Challenge. See
>>>> full prize
>>>> details at: http://p.sf.net/sfu/Challenge
>>>> _______________________________________________
>>>> Tikiwiki-cvs mailing list
>>>> Tikiwiki-cvs@...
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>>>
>>>> ------------------------------------------------------------------------
>>>>
>>>>
>>>> No virus found in this incoming message.
>>>> Checked by AVG - http://www.avg.com
>>>> Version: 8.5.387 / Virus Database: 270.13.8/2226 - Release Date:
>>>> 07/08/09 21:51:00
>>>>
>>>>
>>> ------------------------------------------------------------------------------
>>> Enter the BlackBerry Developer Challenge
>>> This is your chance to win up to $100,000 in prizes! For a limited
>>> time,
>>> vendors submitting new applications to BlackBerry App World(TM) will
>>> have
>>> the opportunity to enter the BlackBerry Developer Challenge. See
>>> full prize
>>> details at: http://p.sf.net/sfu/Challenge
>>> _______________________________________________
>>> Tikiwiki-cvs mailing list
>>> Tikiwiki-cvs@...
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Enter the BlackBerry Developer Challenge
>> This is your chance to win up to $100,000 in prizes! For a limited
>> time,
>> vendors submitting new applications to BlackBerry App World(TM)
>> will have
>> the opportunity to enter the BlackBerry Developer Challenge. See
>> full prize
>> details at: http://p.sf.net/sfu/Challenge
>> _______________________________________________
>> Tikiwiki-cvs mailing list
>> Tikiwiki-cvs@...
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>
>> ------------------------------------------------------------------------
>>
>>
>> No virus found in this incoming message.
>> Checked by AVG - http://www.avg.com
>> Version: 8.5.387 / Virus Database: 270.13.8/2226 - Release Date:
>> 07/08/09 21:51:00
>>
>>
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited
> time,
> vendors submitting new applications to BlackBerry App World(TM) will
> have
> the opportunity to enter the BlackBerry Developer Challenge. See
> full prize
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> Tikiwiki-devel mailing list
> Tikiwiki-devel@...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
|
