Bugs item #3519357, was opened at 2012-04-18 19:32
Message generated for change (Comment added) made by dgp
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3519357&group_id=10894
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 37. File System
Group: current: 8.5.11
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: daxelrod ()
Assigned to: Don Porter (dgp)
Summary: fCmd test assumes too much about the contents of /tmp
Initial Comment:
I encountered the following test failure:
==== fCmd-6.21 CopyRenameOneFile: copy/rename: S_ISDIR(source) FAILED
==== Contents of test case:
cleanup /tmp
file mkdir td1
file rename td1 /tmp
glob -nocomplain td* /tmp/td*
---- Result was:
/tmp/tdfile.tmp /tmp/td1
---- Result should have been (exact matching):
/tmp/td1
==== fCmd-6.21 FAILED
/tmp/tdfile.tmp is owned by a different user, and happens to not be writable by the user running the test.
This means that "cleanup /tmp" failed to delete /tmp/tdfile.tmp , which resulted in the error.
If the tests need to use /tmp, it would be great if they could create a uniquely-named directory inside of it (using a random number, or some mechanism similar to mkstemp(3) ) and do all their file manipulations in there.
$ uname -a:
Linux box_rhel6 2.6.32-220.el6.x86_64 #1 SMP Wed Nov 9 08:03:13 EST 2011 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.2 (Santiago)
Thank you!
----------------------------------------------------------------------
>Comment By: Don Porter (dgp)
Date: 2012-05-24 11:36
Message:
These tests are essentially unchanged since Tcl 7.6. The apparent
intent of them is to test Tcl's responses when attempting to rename a file
from one mounted
native filesystem to another. The assumption is that /tmp and . are
on different mounts.
----------------------------------------------------------------------
Comment By: Don Porter (dgp)
Date: 2012-04-19 06:25
Message:
Thanks for reporting.
These are very old tests. We'll need to examine what
the reason is for fiddling with /tmp. It could be that we
can update them to use testing facilities like [temporaryDirectory]
that came later than the tests themselves did.
If there's some actual testing need for using /tmp then something
like the submitted patch is a good idea.
----------------------------------------------------------------------
Comment By: Serg G. Brester (sebres)
Date: 2012-04-19 01:12
Message:
Commited blind in bug-3519357.
Please test, cause I have currently no unix development ready at hand...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3519357&group_id=10894
|