On 18/12/2010 18:07, Mateusz Loskot wrote:
> I have decided to apply it to the repository because as far as I see
> it is not intrusive and it should not affect other users.
> It's neat and makes the relevant code shorter.
Thanks for applying the patch, but I was thinking about a possible
increase in compile time.
Note that if the macro is not defined, it is set to 10 by default, which
provides the same functionality as before the patch, just compiling
longer. So, for those who accept 10 as the default limitation, things
get worse in terms of longer compile time.
What about this:
// here old implementation
// ... new implementation
With this code structure those who accept the default limitation get
fast compilation and those who want to tinker with the macro get more
flexibility at the price of longer compile.
This also means some code duplication (same functionality implemented in
two different ways), so I'm not entirely sure if this is perfect. I will
therefore ask for opinion those who use this more heavily.
So? Does this dual-implementation make sense?
Maciej Sobczak * http://www.msobczak.com * http://www.inspirel.com