Marcus Sorensen wrote:
> Ok, here's my patch. It applies against the stable 5.42 from
> sourceforge (as that's what we want to roll out).
> One thing I noticed while changing it over to -l was that scterc is
> using it's own function 'ataGetSetSCTErrorRecoveryControltime' to set
> SCT values, whereas I just added the necessary commands to allow me to
> use the existing 'smartcommandhandler'. I'm not sure if one method is
> necessarily preferred over the other, but I imagine someone will want
> to be consistent, and I'm not really excited to change what I've
> already got.
smartcommandhandler() is actually legacy code from the old interface
which only supports ATA commands from smart_command_set. The enum is
still used by the os_*.cpp parts which are not migrated to new
interface. New code should directly call dev->ata_pass_through(.).
I will change this and commit your patch in a week or so.
> I give no guarantee that this won't break someone else's features in
> strange ways, I can only say that we've been running smart with this
> patch (well the -z flag version) for awhile and haven't run into
> anything unexpected.