On Sat, Jan 20, 2007 at 12:23:57PM -0600, Alastair Bridgewater wrote:
> Attached is a patch (tested only against 188.8.131.52 x86/linux) to eliminate
> kludge-nondeterministic-catch-block-size. I can't imagine that it wouldn't
> work on all supported platforms, but I didn't want to just commit it, as it
> introduces a file "src/compiler/generic/not-so-early-objdef.lisp" which
> might be better off with a better name (or which we might not want to
> introduce at all).
It's nice to see that cleaned up. Thanks.
As long as you're sending out warnings about just committing something
which looks safe but which touches many architectures which you can't
test directly, you might try making it a twofer.
> + ;; FIXME: Is this SIZE slot really necessary? It doesn't seem
> + ;; to be used, and removing it on x86 doesn't appear to break
> + ;; anything.
> + size)
If you're reasonably sure that the SIZE slot isn't needed, and you're
trying to have people test your patch on the entire architectural zoo
anyway, this looks like a good time to delete the slot.
I agree that not-so-early-objdef.lisp looks like a suboptimal
filename:-) but I'm having trouble coming up with a more satisfactory
name myself. Maybe something to do with what other properties of the
definitions in the file? I see the summary
>+;;;; other non-heap data blocks
If that isn't just a temporary accidental regularity which will change
next week, maybe the file could be called early-nonheap-objdef.lisp or
some such thing.
William Harold Newman <william.newman@...>
PGP key fingerprint 85 CE 1C BA 79 8D 51 8C B9 25 FB EE E0 C3 E5 7C
God grant me serenity to accept the code I cannot change, courage to
change the code I can, and wisdom to know the difference. -- Erik Naggum