> On 06/05/2013 03:55 AM, Tim Munro wrote:
> Very nice. You've cleared up the ambiguity that was troubling me as well
> as some other minor issues.
> The way the presets work is now completely clear, and I particularly like
> the way the presets belonging to each controller are now separately saved
> in "~/.config/rosegardenmusic/Rosegarden.conf".
> A couple of very minor points:
OK, but I should admit up front, I'm a bit tired and I probably won't make
non-bugfix changes. Now I'm dog-food-testing it.
> * Before a user sets anything, perhaps the ramp mode should default to
> "Linear" and the steps mode to "Use this many steps". That way the
> Vibrato / Tremolo / LFO would also be available by default.
Well, as you said, LFO isn't (commonly) used other than for pitchbend. I
think this is a good middle ground: It's available but not the default,
except for certain pitchbend presets.
> * Under the "Controllers" menu, the special item "Insert expression
> controller Sequence ..." is probably unnecessary, as the expression-
> controller dialog can be accessed the same as any other controller
> dialog by first selecting the appropriate ruler.
'Twas you who persuaded me to make a special menu item for expression!
Now that it's coded up, I like it. :)
> * Slightly off the point, is there some sort of ruler available to show
> what is happening with pitch bend? I have never used pitch bend, so I
> admit I haven't looked very hard.
Yes. Its icon is to the left of the controllers ruler icon. It has a
sort of curved arrow.