Hi,
on my 64 bit system I get segmentation violation errors in
ewmh_set_icon, when using seamless RDP and a new
window opens. I have debugged this to be caused by corrupt
sizes being returned for the icons in _NET_WM_ICON, or
rather a wrong interpretation.
Funny thing is, despite the specification of 32 bit cardinals for the
return array, the X specifcation mandates that those will
nevertheless be stored in longs, which are 64bit on 64 bit
machines.
See also the discussion at
http://www.mail-archive.com/rxvt-unicode@...>
The attached patch drops uint32 and replaces with long and
sizeof(long). It also adds checking for i vs nitems.
Could you please apply to upstream rdesktop?
Thanks,
Stephan
|