Home / Browse / PNG and MNG/JNG image formats: home site / Mail / Archive

PNG and MNG/JNG image formats: home site

Email Archive: png-mng-implement (read-only)

2005:	_Jan	_Feb (8)	_Mar (40)	_Apr (14)	_May (30)	_Jun (44)	_Jul (45)	_Aug (47)	_Sep (30)	_Oct (22)	_Nov (22)	_Dec (35)
2006:	_Jan (24)	_Feb (157)	_Mar (228)	_Apr (201)	_May (84)	_Jun (109)	_Jul (39)	_Aug (60)	_Sep (17)	_Oct (27)	_Nov (60)	_Dec (56)
2007:	_Jan (23)	_Feb (54)	_Mar (56)	_Apr (25)	_May (172)	_Jun (99)	_Jul (71)	_Aug (88)	_Sep (55)	_Oct (86)	_Nov (29)	_Dec (16)
2008:	_Jan (42)	_Feb (43)	_Mar (81)	_Apr (102)	_May (69)	_Jun (38)	_Jul (65)	_Aug (71)	_Sep (33)	_Oct (18)	_Nov (101)	_Dec (22)
2009:	_Jan (5)	_Feb (27)	_Mar (171)	_Apr (132)	_May (54)	_Jun (101)	_Jul (84)	_Aug (101)	_Sep (56)	_Oct (86)	_Nov (232)	_Dec (69)
2010:	_Jan (80)	_Feb (109)	_Mar (43)	_Apr (96)	_May (44)	_Jun (15)	_Jul (63)	_Aug (64)	_Sep (140)	_Oct (83)	_Nov (46)	_Dec (126)
2011:	_Jan (204)	_Feb (64)	_Mar (86)	_Apr (88)	_May (43)	_Jun (95)	_Jul (73)	_Aug (60)	_Sep (57)	_Oct (178)	_Nov (128)	_Dec (24)
2012:	_Jan (66)	_Feb (89)	_Mar (68)	_Apr (19)	_May (15)	_Jun (42)	_Jul (49)	_Aug (14)	_Sep (18)	_Oct (40)	_Nov (27)	_Dec (71)
2013:	_Jan (69)	_Feb (106)	_Mar (53)	_Apr (54)	_May (57)	_Jun	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec


S	M	T	W	T	F	S
		1	2	3	4	5
				(1)		(1)
6	7	8	9	10	11	12
			(2)
13	14	15	16	17	18	19

20	21	22	23	24	25	26
				(4)		(2)
27	28	29	30
		(1)	(4)

Re: [png-mng-implement] [oss-security] CVE Request -- libpng v1.4.3 and v1.2.44 -- memory leak while processing PNG image with malformed sCAL chunks

From: Marcus Meissner <meissner@su...> - 2010-06-30 15:22

On Mon, Jun 28, 2010 at 04:26:06PM -0400, Josh Bressers wrote:
> 
> ----- "Jan Lieskovsky" <jlieskov@...> wrote:
> 
> > Hi Steve, vendors,
> > 
> >    libpng upstream has released latest v1.4.3 and v1.2.44 versions,
> > addressing two
> > security issues:
> > [a], out-of-bounds write to memory -- this already got a CVE id of
> > "CVE-2010-1205",
> > [b], memory-leak bug, involving images with malformed sCAL chunks,
> > which could
> >     lead to an application crash.
> > 
> > References:
> >    [1] http://www.libpng.org/pub/png/libpng.html
> >    [2] https://bugzilla.redhat.com/show_bug.cgi?id=608644
> > 
> > Steve, could you allocate a CVE id for the [b] issue?
> > 
> 
> Please use CVE-2010-2249 for issue [b].

oss-sec, png-mng-implement ... do you have testimages or a reproducer for the sCAL issue?

It would be helpful for our QA :/

Ciao, Marcus

[png-mng-implement] PNG file writing issue.

From: Mohit Yadav <mohit.gurgaon@gm...> - 2010-06-30 10:40

Attachments: Message as HTML MSN.ICO mohit_.png

Re: [png-mng-implement] PNG file writing issue.

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-30 13:44

You should not set members of png_ptr_write and info_ptr_write.  I don't
know if what you have done is harmless or not, but in future versions
(libpng-1.5.0) you won't be able to do it.

Glenn

On Wed, Jun 30, 2010 at 6:40 AM, Mohit Yadav <mohit.gurgaon@...> wrote:
>


      Don't set this directly;  png_set_PLTE() will pass this
      value in to libpng.

>    info_ptr_write->palette.size = ncolors;

      Make sure ncolors is 256 or less.

>    for(k = 0 ;k< ncolors;k++)
>
> {
>
>              palette[k].blue = (png_byte) blue[k];
>
>              palette[k].green = (png_byte)green[k];
>
>             palette[k].red = (png_byte) red[k];
>
> }
>
>      /*set pallete*/
>
>          png_set_PLTE(png_ptr_write,info_ptr_write,palette,ncolors );
>
> // info_ptr_write->palette.colors

             Don't set these; libpng will calculate them from the color
             type and bit depth that you pass in to png_set_IHDR().

>          png_ptr_write->channels = 4 ;
>
>           png_ptr_write->color_type = 6;
>
>
> png_set_IHDR(png_ptr_write,info_ptr_write,width,height,8,6,0,
> PNG_COMPRESSION_TYPE_DEFAULT,PNG_FILTER_TYPE_DEFAULT
> );



Glenn

Re: [png-mng-implement] PNG file writing issue.

From: John Bowler <jbowler@fr...> - 2010-06-30 14:46

As Glenn says the contents of png_struct and png_info should not be read directly.  A good test is to try to compile code against 1.5.0beta.

However in this case the output PNG file seems fine, it's a 24x24 32 bit per pixel file, but it's unrelated to the MSN.ICO file which is a 16x16 32 bit per pixel file.

From: Mohit Yadav [mailto:mohit.gurgaon@...] 
>image --> contains image data ( in my case MSN.ICO file data) type is unsigned char *
>Red colour value.
>Green Color Value
>Blue Color Value.
>Opacity.

But MSN.ICO has 1024 bytes of image data, whereas:

...
>        for (i = 0; i < info_ptr_write->height ; ++i) 
>                    row_pointers[i] = image + i*info_ptr_write->rowbytes;

'image' should be 2304 bytes in size (24x24 by 4 bytes per pixel).

The output looks pretty much like I would expect given these facts (the bottom half looks like the result of reading random memory.)

John Bowler <jbowler@...>

[png-mng-implement] CVE-2010-2249 sCAL memory leak

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-29 15:39

I understand from the Red Hat bugzilla that CVE-2010-2249 has
been assigned to the sCAL memory-leak issue.

Glenn

[png-mng-implement] Cruft in libpng-1.4.3

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-26 15:08

I left a non-working file (new_push_process_row.c) in the 1.4.3 distribution.

It's harmless (not mentioned in any makefile or configuration file) and
will be removed from the next release.

Glenn

[png-mng-implement] libpng-1.4.3, 1.2.44, and 1.5.0beta31 are available

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-26 01:02

libpng-1.4.3 and 1.2.44 are available from
ftp://ftp.simplesystems.org/pub/png/src
and from
http://libpng.sf.net

and libpng-1.5.0beta31 is available from
ftp://ftp/simplesystems.org/pub/png-group/src

Changes include

  Added missing quotation marks in the aix block of configure.ac
  The new "vstudio" project was missing from the zip and 7z distributions.
  Rewrote png_process_IDAT_data to consistently treat extra data as warnings
    and handle end conditions more cleanly.
  Removed the now-redundant check for out-of-bounds new_row from example.c
  Changed char *msg to PNG_CONST char *msg in pngrutil.c
  Stop memory leak when reading a malformed sCAL chunk.

Glenn

[png-mng-implement] Fwd: [ libpng-Feature Requests-3011658 ] Support for Digital Mars Compiler (DMC)

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-24 15:27

I suppose the answer to this person is "no", since there's no reply to
my questions about what is the error message, does it work with
libpng-1.5.0beta, and does it work with "configure; make".

Has anyone here on png-mng-implement tried the DMC
compiler, and is anyone willing to write a makefile.dmc?

I don't consider "configure; make" a "workaround."

Glenn


---------- Forwarded message ----------
From: SourceForge.net <noreply@...>
Date: Thu, Jun 24, 2010 at 10:46 AM
Subject: [ libpng-Feature Requests-3011658 ] Support for Digital Mars
Compiler (DMC)
To: noreply@...


Feature Requests item #3011658, was opened at 2010-06-04 16:10
Message generated for change (Comment added) made by ptreese
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=355624&aid=3011658&group_id=5624

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Glenn Randers-Pehrson (glennrp)
Summary: Support for Digital Mars Compiler (DMC)

Initial Comment:
I didn't found a makefile for DMC. I tried to compile the *.c files
manually, but I got an error in pngrutil.c.

----------------------------------------------------------------------

Comment By: Peter Reese (ptreese)
Date: 2010-06-24 09:46

Message:
I’m interested in official support for DMC - not a workaround. This means
testing and maintenance with every new release of libpng on your part.

If you are unable to provide such support you can clearly state so.

----------------------------------------------------------------------

Comment By: Glenn Randers-Pehrson (glennrp)
Date: 2010-06-05 08:37

Message:
Also try "configure; make" and let us know if that failed too.

----------------------------------------------------------------------

Comment By: Glenn Randers-Pehrson (glennrp)
Date: 2010-06-05 08:36

Message:
What libpng version were you trying to build?  What was the compiler error
message?
Please try the latest libpng-1.5.0 beta and see if that works.

Glenn

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=355624&aid=3011658&group_id=5624

[png-mng-implement] Libpng 1.5

From: John Bowler <jbowler@fr...> - 2010-06-24 01:45

I'd like to suggest that this be released now with a couple of minor configuration changes to the standard build - the one that is invariably installed as a shared library by system builders.

The changes are simply to switch on features that were implemented in earlier releases but were still disabled by default in 1.4:

1) Benign error handling. This changes png_struct, so it couldn't be enabled in 1.4. It should be enabled in 1.5 by default. It doesn't require any code changes in applications and it doesn't change any behavior unless the app calls the new API. In that case it allows PNG image error recovery when apparently possible - a good thing for image editors.

2) The 'inch' conversions. Present in 1.2 and 1.4, never switched on for some reason. Either this should be switched on now or the code should be eliminated (personally I don't care, but switching it on is easiest.)

3) Regularization of the FLOATING_POINT vs FIXED_POINT choice. At present switching either of these options off doesn't disable all the corresponding APIs. This happens when they are used internally or when the #if's in png.h are simply wrong. Also switching both *on* disables the fixed point sCAL APIs - that's inconsistent with everything else therefore wrong. It's easy to fix all this (I already have a patch) and, apart from enabling sCAL-fixed, it makes no change to the default build. (I also tested my patch against pngminim; it behaves as expected.)

I think these are all no-brainers, except, maybe, for the possibility of removing the currently disabled 'inch' code.

John Bowler <jbowler@...>

Re: [png-mng-implement] Libpng 1.5

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-24 01:58

All 3 OK by me.  I also wanted to see in 1.5

     4) Finish the premultiplied-alpha support

     5) Implement the integer arithmetic gamma-table building

Glenn

On Wed, Jun 23, 2010 at 8:26 PM, John Bowler <jbowler@...> wrote:
> I'd like to suggest that this be released now with a couple of minor configuration changes to the standard build - the one that is invariably installed as a shared library by system builders.
>
> The changes are simply to switch on features that were implemented in earlier releases but were still disabled by default in 1.4:
>
> 1) Benign error handling.  This changes png_struct, so it couldn't be enabled in 1.4.  It should be enabled in 1.5 by default.  It doesn't require any code changes in applications and it doesn't change any behavior unless the app calls the new API.  In that case it allows PNG image error recovery when apparently possible - a good thing for image editors.
>
> 2) The 'inch' conversions.  Present in 1.2 and 1.4, never switched on for some reason.  Either this should be switched on now or the code should be eliminated (personally I don't care, but switching it on is easiest.)
>
> 3) Regularization of the FLOATING_POINT vs FIXED_POINT choice.  At present switching either of these options off doesn't disable all the corresponding APIs.  This happens when they are used internally or when the #if's in png.h are simply wrong.  Also switching both *on* disables the fixed point sCAL APIs - that's inconsistent with everything else therefore wrong.  It's easy to fix all this (I already have a patch) and, apart from enabling sCAL-fixed, it makes no change to the default build.  (I also tested my patch against pngminim; it behaves as expected.)
>
> I think these are all no-brainers, except, maybe, for the possibility of removing the currently disabled 'inch' code.
>
> John Bowler <jbowler@...>
>
>
> ------------------------------------------------------------------------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit.  See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________
> png-mng-implement mailing list
> png-mng-implement@...
> https://lists.sourceforge.net/lists/listinfo/png-mng-implement
>

Re: [png-mng-implement] Libpng 1.5

From: John Bowler <jbowler@fr...> - 2010-06-24 02:10

Sorry, meant to copy to the list:

From: Glenn Randers-Pehrson [mailto:glennrp@...] 
>All 3 OK by me.  I also wanted to see in 1.5
>
>     4) Finish the premultiplied-alpha support
>
>     5) Implement the integer arithmetic gamma-table building

So far as I can see these are both API safe.  The changes I suggested are too, but they are good to go whereas (4) and (5) require work.

In other words 1.5.1 would have API adds, as required, for (4) and (5), 1.5.0 would just have the existing APIs (as in beta24, but with INCH and BENIGN turned on.)  There will be a certain amount of kicking and screaming associated with 1.5 because of jmp_buf; this requires changes in many apps.  That's a good reason for having 1.5.0 in parallel with 1.4 because those changes won't happen until 1.5.0 is released and we won't be able to stop enhancing 1.4 until the changes are complete.

Because png_struct and png_info are opaque in 1.5 we can fix the gamma-requires-floating-point problem without a major release.  (1.5 without PNG_FLOATING_POINT_SUPPORT doesn't have the gamma correct APIs at all - png_set/get_gamma get disabled.)

John Bowler <jbowler@...>

[png-mng-implement] MNG library

From: Kobby Katan <Kobbyk@wa...> - 2010-06-09 12:42

Attachments: Message as HTML image001.jpg

Re: [png-mng-implement] MNG library

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-09 13:09

Attachments: Message as HTML

On Wed, Jun 9, 2010 at 8:25 AM, Kobby Katan <Kobbyk@...> wrote:

>  Hello
>
>
>
> I have a question about MNG library.
>
> Is it possible to load a single image without loading all images from mng
> file
>
> (using mng_display_goframe function or another function)?
>

I don't remember what the MNG library allows, but the MNG specification only
allows you to skip to a SEEK chunk preceding the frame you want,
then process (but not display) frames until you reach the frame you want,
then display that.  If no SEEK chunks are present, you have to process
all frames until you get to the one you'd like to display or save.

Glenn

[png-mng-implement] any users of prebuilt libpng binaries on Sunfreeware.com?

From: Greg Roelofs <newt@po...> - 2010-06-05 01:50

If you make use of the Solaris libpng packages on Sunfreeware.com (e.g.,
via the "Solaris 2.5-10" link I include on the libpng.html page), please
read on and provide feedback to the site maintainer ASAP, or you may be
rolling your own henceforth.  

Greg


>> Greetings -

>> As you surely already know, Sun Microsystems was recently purchased
>> by Oracle.   As with all such events, they are now determining which
>> projects originally sponsored by Sun will continue to get their support.

>> Sunfreeware.com has been sponsored by Sun for many years and that
>> situation is now in doubt.  Therefore, I am sending this request to
>> past and current Sunfreeware.com users, developers, and others who have
>> communicated with me about my open source services.

>> I will be collecting emails sent to me remarking on how valuable/crucial
>> the packages at Sunfreeware.com and my other Solaris support contributions
>> have been to users and their organizations.   If you would please take a
>> few minutes and send me your strongest and, when possible, detailed support
>> comments, I will forward them to the decision makers.

>> The DEADLINE for this is next Tuesday night June 8 when I am required
>> to respond.

>> I greatly appreciate any help you can give me.   Please feel free to
>> pass this request onto anyone in your organization who might also send
>> positive statements.

>> If you have any questions, email me.

>> Please include your name, position, and organization with your statements.

>> Thank you very much.   I deeply appreciate your time and thoughts.

>> Steve Christensen

>> sunfreeware@... 
>> steve@...

[png-mng-implement] bad advice on Ubuntu wiki

From: Glenn Randers-Pehrson <glennrp@gm...> - 2010-06-03 14:00

Interesting advice in

https://wiki.ubuntu.com/CanonPixmaIP1500

    How to install Canon Pixma ip1500 driver for ubuntu karmic koala
(9.10) and lucid lynx (10.0)

     [...]

     6. Create symlinks:

     cd /usr/lib
     sudo ln -s libpng12.so.0 libpng.so.2
     sudo ln -s libtiff.so.4 libtiff.so.3
     sudo ln -s libxml2.so.2 libxml.so.1

     [...]

So when you install the Canon driver you are advised essentially
to make libpng.so.3 masquerade as libpng.so.2 for everyone.

The proper action would be to install libpng10.so.0 and link
that to libpng.so.2

Better would be for the maintainer of the Canon
driver to rebuild it with current libpng.

I assume a similar situation pertains to libtiff and libxml
Libraries usually have different so-numbers for a reason.

Glenn