PMD

On Tue, 2005-08-30 at 13:31 -0700, Brian Westrich wrote:
> interesting....
> Looked in my plugin dir, and saw the following
> versions: 
> net.sourceforge.pmd.core_3.0.1
> net.sourceforge.pmd.eclipse_3.0.1
> net.sourceforge.pmd.core_3.2.0
> net.sourceforge.pmd.eclipse_3.1.0
> 
> I then deleted the older 2 versions (the 3.0.1 ones),
> and tried the plugin again. Same results.  
> 
> I then dropped the jar you sent me into the core*/lib
> directory (on top of the existing one, which had the
> same name).  After doing that, I was no longer able to
> do a 'show rule' in the PMD violations view (got the
> message 'Runtime Exception:..... Couldn't find that
> class').  

Hi Brian -

Hm, let me CC the list on this to see if Philippe (or anyone else who
knows more about the Eclipse plugin then I do) can comment.  I'm not
sure about the "show rule" thing... can you try uninstalling and
reinstalling the plugin? 

Also, I had a chance to check the changelog, and yup, that was a bug
that got fixed in CVS, here's the entry: "Fixed bug which caused
MissingSerialVersionUID to trigger on all interfaces that implemented
other interfaces."

Yours,

Tom

Bugs item #695344, was opened at 2003-02-28 17:34
Message generated for change (Comment added) made by tomcopeland
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=479921&aid=695344&group_id=56262

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pmd
Group: None
>Status: Pending
Resolution: None
Priority: 5
Submitted By: Andrew Taylor (andrewtaylor)
>Assigned to: Tom Copeland (tomcopeland)
Summary: False +: StringInstantiationRule

Initial Comment:
StringInstantiationRule still flags Strings constructed
from an array of bytes as unnecessary.  This is
actually a useful way to convert bytes into a String
using the default character encoding.

Example:

     byte[] someData = msg.getBytes();
     String s = new String(someData);
     System.out.println(s);

I think this rule should really only catch the
String(String) ctor, unless I'm misinterpreting the
purpose of this rule.


----------------------------------------------------------------------

>Comment By: Tom Copeland (tomcopeland)
Date: 2005-08-30 16:21

Message:
Logged In: YES 
user_id=5159

Fixed in CVS, and you can download a new pmd-3.2.jar file here:

http://infoether.com/~tom/pmd-3.2.jar

that contains this fix.

Thanks,

Tom

----------------------------------------------------------------------

Comment By: Tom Copeland (tomcopeland)
Date: 2003-10-30 12:19

Message:
Logged In: YES 
user_id=5159

Adding Jesse Glick's test patch from here:

https://sourceforge.net/tracker/index.php?func=detail&aid=831974&group_id=56262&atid=479921

Tom

----------------------------------------------------------------------

Comment By: Andriy Rozeluk (arozeluk)
Date: 2003-08-06 10:04

Message:
Logged In: YES 
user_id=687284

As irritating as this is, I've run into it as well. However,
the rule catches more problems than annoyances like this, so
I've found it quite useful for cleanup purposes.

The only workaround I've been able to find is to use the
other constructor:

byte[] someData = msg.getBytes();
String s = new String(someData, 0, someData.length);

----------------------------------------------------------------------

Comment By: Tom Copeland (tomcopeland)
Date: 2003-02-28 20:35

Message:
Logged In: YES 
user_id=5159

Hi Andrew -

You're absolutely right, this is a perfectly legitimate use of 
new String() should not be a violation of this rule.

Unfortunately, the state of the PMD is such that it's hard to 
tell what type some things are and impossible to tell others. 
For example, since PMD checks one file at a time, it's 
impossible to check this:

public class Foo {
 public void bar() {
  String s = new String(Baz.getSomething());
 }
}

Until PMD is enhanced to resolve the type and return value of 
Baz.getSomething(), we can't tell if this is a legitimate use of 
new String().  

So this bug, along with bug # 631681, will probably stay open 
for a while.  

It's definitely a legitimate bug - it's just really hard to fix :-)

Thanks,

Tom

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=479921&aid=695344&group_id=56262

Update of /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules/strings
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26248/regress/test/net/sourceforge/pmd/rules/strings

Modified Files:
	StringInstantiationRuleTest.java 
Log Message:
Fixed bug 695344 - StringInstantiation no longer triggers on the String(byte[]) constructor.

Index: StringInstantiationRuleTest.java
===================================================================
RCS file: /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules/strings/StringInstantiationRuleTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** StringInstantiationRuleTest.java	14 Jul 2005 01:49:56 -0000	1.2
--- StringInstantiationRuleTest.java	30 Aug 2005 21:16:08 -0000	1.3
***************
*** 23,27 ****
             new TestDescriptor(TEST2, "new String array", 0, rule),
             new TestDescriptor(TEST3, "using multiple parameter constructor", 0, rule),
!            new TestDescriptor(TEST4, "using 4 parameter constructor", 0, rule)
         });
      }
--- 23,28 ----
             new TestDescriptor(TEST2, "new String array", 0, rule),
             new TestDescriptor(TEST3, "using multiple parameter constructor", 0, rule),
!            new TestDescriptor(TEST4, "using 4 parameter constructor", 0, rule),
!            new TestDescriptor(TEST5, "byte array constructor is ok", 0, rule)
         });
      }
***************
*** 54,57 ****
--- 55,66 ----
      "}";
  
+     private static final String TEST5 =
+     "public class Foo {" + PMD.EOL +
+     " void foo() {" + PMD.EOL +
+     "  byte[] bytes = new byte[50];" + PMD.EOL +
+     "  String bar = new String(bytes);" + PMD.EOL +
+     " }" + PMD.EOL +
+     "}";
+ 
  
  }

Update of /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26248/src/net/sourceforge/pmd/symboltable

Modified Files:
	AbstractNameDeclaration.java ClassNameDeclaration.java 
	ClassScope.java LocalScope.java MethodNameDeclaration.java 
	MethodScope.java NameDeclaration.java 
	VariableNameDeclaration.java 
Log Message:
Fixed bug 695344 - StringInstantiation no longer triggers on the String(byte[]) constructor.

Index: ClassNameDeclaration.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/ClassNameDeclaration.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** ClassNameDeclaration.java	4 Aug 2005 04:38:53 -0000	1.3
--- ClassNameDeclaration.java	30 Aug 2005 21:16:08 -0000	1.4
***************
*** 3,7 ****
  import net.sourceforge.pmd.ast.ASTClassOrInterfaceDeclaration;
  
! public class ClassNameDeclaration extends AbstractNameDeclaration implements NameDeclaration {
  
      public ClassNameDeclaration(ASTClassOrInterfaceDeclaration node) {
--- 3,7 ----
  import net.sourceforge.pmd.ast.ASTClassOrInterfaceDeclaration;
  
! public class ClassNameDeclaration extends AbstractNameDeclaration {
  
      public ClassNameDeclaration(ASTClassOrInterfaceDeclaration node) {

Index: MethodNameDeclaration.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/MethodNameDeclaration.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -C2 -d -r1.18 -r1.19
*** MethodNameDeclaration.java	4 Aug 2005 04:38:53 -0000	1.18
--- MethodNameDeclaration.java	30 Aug 2005 21:16:08 -0000	1.19
***************
*** 11,15 ****
  import net.sourceforge.pmd.ast.SimpleNode;
  
! public class MethodNameDeclaration extends AbstractNameDeclaration implements NameDeclaration {
  
      public MethodNameDeclaration(ASTMethodDeclarator node) {
--- 11,15 ----
  import net.sourceforge.pmd.ast.SimpleNode;
  
! public class MethodNameDeclaration extends AbstractNameDeclaration {
  
      public MethodNameDeclaration(ASTMethodDeclarator node) {

Index: MethodScope.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/MethodScope.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -C2 -d -r1.20 -r1.21
*** MethodScope.java	16 Jul 2005 01:29:44 -0000	1.20
--- MethodScope.java	30 Aug 2005 21:16:08 -0000	1.21
***************
*** 6,9 ****
--- 6,10 ----
  import net.sourceforge.pmd.ast.ASTConstructorDeclaration;
  import net.sourceforge.pmd.ast.SimpleNode;
+ import net.sourceforge.pmd.ast.ASTName;
  import net.sourceforge.pmd.util.Applier;
  
***************
*** 36,39 ****
--- 37,44 ----
          if (decl != null && !occurrence.isThisOrSuper()) {
              ((List) variableNames.get(decl)).add(occurrence);
+             SimpleNode n = occurrence.getLocation();
+             if (n instanceof ASTName) {
+                 ((ASTName)n).setNameDeclaration(decl);
+             } // TODO what to do with PrimarySuffix case?
          }
          return decl;

Index: VariableNameDeclaration.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/VariableNameDeclaration.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -C2 -d -r1.22 -r1.23
*** VariableNameDeclaration.java	12 Aug 2005 20:36:33 -0000	1.22
--- VariableNameDeclaration.java	30 Aug 2005 21:16:08 -0000	1.23
***************
*** 13,17 ****
  import net.sourceforge.pmd.ast.ASTType;
  
! public class VariableNameDeclaration extends AbstractNameDeclaration implements NameDeclaration {
  
      public VariableNameDeclaration(ASTVariableDeclaratorId node) {
--- 13,17 ----
  import net.sourceforge.pmd.ast.ASTType;
  
! public class VariableNameDeclaration extends AbstractNameDeclaration {
  
      public VariableNameDeclaration(ASTVariableDeclaratorId node) {

Index: LocalScope.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/LocalScope.java,v
retrieving revision 1.27
retrieving revision 1.28
diff -C2 -d -r1.27 -r1.28
*** LocalScope.java	16 Jul 2005 00:11:18 -0000	1.27
--- LocalScope.java	30 Aug 2005 21:16:08 -0000	1.28
***************
*** 5,8 ****
--- 5,10 ----
  
  import net.sourceforge.pmd.util.Applier;
+ import net.sourceforge.pmd.ast.ASTName;
+ import net.sourceforge.pmd.ast.SimpleNode;
  
  import java.util.ArrayList;
***************
*** 18,23 ****
          NameDeclaration decl = findVariableHere(occurrence);
          if (decl != null && !occurrence.isThisOrSuper()) {
!             List nameOccurrences = (List) variableNames.get(decl);
              nameOccurrences.add(occurrence);
          }
          return decl;
--- 20,29 ----
          NameDeclaration decl = findVariableHere(occurrence);
          if (decl != null && !occurrence.isThisOrSuper()) {
!             List nameOccurrences = (List)variableNames.get(decl);
              nameOccurrences.add(occurrence);
+             SimpleNode n = occurrence.getLocation();
+             if (n instanceof ASTName) {
+                 ((ASTName)n).setNameDeclaration(decl);
+             } // TODO what to do with PrimarySuffix case?
          }
          return decl;

Index: AbstractNameDeclaration.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/AbstractNameDeclaration.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -d -r1.11 -r1.12
*** AbstractNameDeclaration.java	9 Jun 2005 00:26:39 -0000	1.11
--- AbstractNameDeclaration.java	30 Aug 2005 21:16:08 -0000	1.12
***************
*** 6,10 ****
  import net.sourceforge.pmd.ast.SimpleNode;
  
! public abstract class AbstractNameDeclaration {
  
      protected SimpleNode node;
--- 6,10 ----
  import net.sourceforge.pmd.ast.SimpleNode;
  
! public abstract class AbstractNameDeclaration implements NameDeclaration{
  
      protected SimpleNode node;

Index: ClassScope.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/ClassScope.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -C2 -d -r1.26 -r1.27
*** ClassScope.java	4 Aug 2005 04:38:53 -0000	1.26
--- ClassScope.java	30 Aug 2005 21:16:08 -0000	1.27
***************
*** 5,8 ****
--- 5,10 ----
  
  import net.sourceforge.pmd.util.Applier;
+ import net.sourceforge.pmd.ast.ASTName;
+ import net.sourceforge.pmd.ast.SimpleNode;
  
  import java.util.ArrayList;
***************
*** 51,54 ****
--- 53,60 ----
              List nameOccurrences = (List) variableNames.get(decl);
              nameOccurrences.add(occurrence);
+             SimpleNode n = occurrence.getLocation();
+             if (n instanceof ASTName) {
+                 ((ASTName)n).setNameDeclaration(decl);
+             } // TODO what to do with PrimarySuffix case?
          }
          return decl;

Index: NameDeclaration.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/symboltable/NameDeclaration.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -C2 -d -r1.22 -r1.23
*** NameDeclaration.java	27 Sep 2004 19:42:51 -0000	1.22
--- NameDeclaration.java	30 Aug 2005 21:16:08 -0000	1.23
***************
*** 4,10 ****
  package net.sourceforge.pmd.symboltable;
  
  public interface NameDeclaration {
      String getImage();
- 
      Scope getScope();
  }
--- 4,12 ----
  package net.sourceforge.pmd.symboltable;
  
+ import net.sourceforge.pmd.ast.SimpleNode;
+ 
  public interface NameDeclaration {
+     SimpleNode getNode();
      String getImage();
      Scope getScope();
  }

Update of /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26248/src/net/sourceforge/pmd/rules

Modified Files:
	StringInstantiation.java 
Log Message:
Fixed bug 695344 - StringInstantiation no longer triggers on the String(byte[]) constructor.

Index: StringInstantiation.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules/StringInstantiation.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** StringInstantiation.java	30 Aug 2005 11:32:22 -0000	1.1
--- StringInstantiation.java	30 Aug 2005 21:16:08 -0000	1.2
***************
*** 2,9 ****
--- 2,13 ----
  
  import net.sourceforge.pmd.AbstractRule;
+ import net.sourceforge.pmd.symboltable.Scope;
+ import net.sourceforge.pmd.symboltable.NameDeclaration;
+ import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
  import net.sourceforge.pmd.ast.ASTAllocationExpression;
  import net.sourceforge.pmd.ast.ASTClassOrInterfaceType;
  import net.sourceforge.pmd.ast.ASTExpression;
  import net.sourceforge.pmd.ast.ASTArrayDimsAndInits;
+ import net.sourceforge.pmd.ast.ASTName;
  
  import java.util.List;
***************
*** 30,34 ****
          }
  
!         addViolation(data, node);
          return data;
      }
--- 34,48 ----
          }
  
!         ASTName name = (ASTName)node.getFirstChildOfType(ASTName.class);
!         if (name == null) { // Literal, i.e., new String("foo")
!             addViolation(data, node);
!             return data;
!         }
! 
!         VariableNameDeclaration nd = (VariableNameDeclaration)name.getNameDeclaration();
!         if (nd.getTypeImage().equals("String")) {
!             addViolation(data, node);
! 
!         }
          return data;
      }

Update of /cvsroot/pmd/pmd/xdocs
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26248/xdocs

Modified Files:
	credits.xml 
Log Message:
Fixed bug 695344 - StringInstantiation no longer triggers on the String(byte[]) constructor.

Index: credits.xml
===================================================================
RCS file: /cvsroot/pmd/pmd/xdocs/credits.xml,v
retrieving revision 1.350
retrieving revision 1.351
diff -C2 -d -r1.350 -r1.351
*** credits.xml	29 Aug 2005 13:17:40 -0000	1.350
--- credits.xml	30 Aug 2005 21:16:08 -0000	1.351
***************
*** 47,50 ****
--- 47,51 ----
          <ul>
  
+             <li>Andrew Taylor - bug report for StringInstantiation</li>
              <li>Jeff Jensen - suggested description attribute in property element</li>
              <li>Andriy Rozeluk - Suggested UnnecessaryCaseChange, bug report for SimplifyConditional, suggested UnnecessaryLocalBeforeReturn, suggestions for improving BooleanInstantiation, UnnecessaryReturn, AvoidDuplicateLiterals RFEs and bug reports, various other RFEs and thoughtful discussions as well</li>

Update of /cvsroot/pmd/pmd/src/net/sourceforge/pmd/ast
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26248/src/net/sourceforge/pmd/ast

Modified Files:
	ASTName.java 
Log Message:
Fixed bug 695344 - StringInstantiation no longer triggers on the String(byte[]) constructor.

Index: ASTName.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/ast/ASTName.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** ASTName.java	27 May 2005 15:46:29 -0000	1.7
--- ASTName.java	30 Aug 2005 21:16:08 -0000	1.8
***************
*** 3,6 ****
--- 3,8 ----
  package net.sourceforge.pmd.ast;
  
+ import net.sourceforge.pmd.symboltable.NameDeclaration;
+ 
  public class ASTName extends SimpleNode {
      public ASTName(int id) {
***************
*** 12,15 ****
--- 14,25 ----
      }
  
+     private NameDeclaration nd;
+     public void setNameDeclaration(NameDeclaration nd) {
+         this.nd = nd;
+     }
+     public NameDeclaration getNameDeclaration() {
+         return this.nd;
+     }
+ 
  
      /**

Update of /cvsroot/pmd/pmd/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26248/etc

Modified Files:
	changelog.txt 
Log Message:
Fixed bug 695344 - StringInstantiation no longer triggers on the String(byte[]) constructor.

Index: changelog.txt
===================================================================
RCS file: /cvsroot/pmd/pmd/etc/changelog.txt,v
retrieving revision 1.538
retrieving revision 1.539
diff -C2 -d -r1.538 -r1.539
*** changelog.txt	30 Aug 2005 11:02:32 -0000	1.538
--- changelog.txt	30 Aug 2005 21:16:08 -0000	1.539
***************
*** 29,32 ****
--- 29,33 ----
  Fixed bug 1251269 - AvoidConcateningNonLiteralsInStringBuffer no longer triggers on StringBuffer constructors like 'new StringBuffer(1 + getFoo());'
  Fixed bug 1244570 - AvoidConcateningNonLiteralsInStringBuffer no longer triggers on certain AST patterns involving local variable declarations inside Statement nodes.
+ Fixed bug 695344 - StringInstantiation no longer triggers on the String(byte[]) constructor.
  Applied patch 1228834 - XPath rules can now use properties to customize rules.  Thanks to Wouter Zelle for another great piece of work!
  Fixed a bug in RuleSetFactory that missed some override cases; thx to Wouter Zelle for the report and a fix.

Hello,

I'm getting unexpected results from the
MissingSerialVersionUID rule.  Some of my classes that
don't implement Serializable, but that implement some
other interface (e.g. an interface I've created), are
being flagged as needing a serialVersionUID. 

I didn't see anything reported on this in the open
issues or in the last few days of the mailing list.
Should I add this issue into the issue tracking
system? 

Brian

Bugs item #1276694, was opened at 2005-08-30 16:46
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=479921&aid=1276694&group_id=56262

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pmd
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Pieter Bloemendaal (pbloemendaal)
Assigned to: Tom Copeland (tomcopeland)
Summary: pmd parse error (but only in case of pmd warnings)

Initial Comment:


I have created a small test set of JDK 5 test code, if I 
run PMD on it, I get the following.

     [java] Buildfile: D:\CQM\inst\jmodules\sandbox5
\build.xml
     [java] pmd-init:
     [java] pmd:
     [java]       [pmd] No problems found!
     [java] BUILD SUCCESSFUL
     [java] Total time: 3 seconds


I have now added some unused variables to some files 
in the test-set ( see CVS diff below )

cvs -z9 -q diff GenericStringArrayListToo.java 
GenericStringArrayList.java (in directory 
D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\)
Index: GenericStringArrayListToo.java
=========================================
==========================
RCS file: /data/cvs/I-
Metricstool/swdeqa/jmodules/sandbox5/src/de/spm/swd
eqa/sandbox/tigercode/GenericStringArrayListToo.java,v
retrieving revision 1.1
diff -r1.1 GenericStringArrayListToo.java
26a27
>     int notUsed;
Index: GenericStringArrayList.java
=========================================
==========================
RCS file: /data/cvs/I-
Metricstool/swdeqa/jmodules/sandbox5/src/de/spm/swd
eqa/sandbox/tigercode/GenericStringArrayList.java,v
retrieving revision 1.4
diff -r1.4 GenericStringArrayList.java
26a27
>     int notUsed;

*****CVS exited normally with code 1*****



javac compiles without problems

Buildfile: .\build.xml
init:
     [echo] javac.source: 1.5
     [echo] javac.target: 1.5
compile:
     [echo] compile-classpath=
    [javac] Compiling 2 source files to 
D:\CQM\inst\jmodules\sandbox5\build
BUILD SUCCESSFUL


If I now run PMD I get the following 

     [java] Buildfile: D:\CQM\inst\jmodules\sandbox5
\build.xml
     [java] pmd-init:
     [java] pmd:
     [java]       [pmd]
     [java]       [pmd] D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\GenericStringArr
ayList.java   27      Avoid unused local variables such 
as 'notUsed'
     [java]       [pmd] D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\GenericStringArr
ayListToo.java        27      Avoid unused local variables 
such as 'notUsed'
     [java]       [pmd] D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\EnhancedForLoo
p.java  
		-       Error while parsing 
D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\EnhancedForLoo
p.java
     [java]       [pmd] D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\EnumType.java 
		-       Error while parsing 
D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\EnumType.java
     [java]       [pmd] D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\StaticImport.java
     
		-       Error while parsing 
D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercodeStaticImport.java
     [java]       [pmd] D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\VarArgs.java  
		-       Error while parsing 
D:\CQM\inst\jmodules\sandbox5
\src\de\spm\swdeqa\sandbox\tigercode\VarArgs.java
     [java] BUILD SUCCESSFUL
     [java] Total time: 3 seconds


I see this with PMD 3.2 , I also see the problem with the 
JDK5 production code that we have,
it seems to be a general problem?

If you're interested, I can send you the test-set that we 
have. 





----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=479921&aid=1276694&group_id=56262

Update of /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15699/src/net/sourceforge/pmd/rules

Added Files:
	StringInstantiation.java 
Log Message:
Converting StringInstantiation to Java so's to make fixing bug 695344 easier.  I hope.

--- NEW FILE: StringInstantiation.java ---
package net.sourceforge.pmd.rules;

import net.sourceforge.pmd.AbstractRule;
import net.sourceforge.pmd.ast.ASTAllocationExpression;
import net.sourceforge.pmd.ast.ASTClassOrInterfaceType;
import net.sourceforge.pmd.ast.ASTExpression;
import net.sourceforge.pmd.ast.ASTArrayDimsAndInits;

import java.util.List;

public class StringInstantiation extends AbstractRule {

    public Object visit(ASTAllocationExpression node, Object data) {
        if (!(node.jjtGetChild(0) instanceof ASTClassOrInterfaceType)) {
            return data;
        }

        ASTClassOrInterfaceType clz = (ASTClassOrInterfaceType)node.jjtGetChild(0);
        if (!clz.getImage().equals("String")) {
            return data;
        }

        List exp = node.findChildrenOfType(ASTExpression.class);
        if (exp.size() >=2 ){
            return data;
        }

        if (node.getFirstChildOfType(ASTArrayDimsAndInits.class) != null) {
            return data;
        }

        addViolation(data, node);
        return data;
    }
}

Update of /cvsroot/pmd/pmd/rulesets
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15699/rulesets

Modified Files:
	strings.xml 
Log Message:
Converting StringInstantiation to Java so's to make fixing bug 695344 easier.  I hope.

Index: strings.xml
===================================================================
RCS file: /cvsroot/pmd/pmd/rulesets/strings.xml,v
retrieving revision 1.27
retrieving revision 1.28
diff -C2 -d -r1.27 -r1.28
*** strings.xml	30 Aug 2005 09:53:39 -0000	1.27
--- strings.xml	30 Aug 2005 11:32:22 -0000	1.28
***************
*** 35,52 ****
      <rule name="StringInstantiation"
          message="Avoid instantiating String objects; this is usually unnecessary."
!         class="net.sourceforge.pmd.rules.XPathRule">
      <description>
  Avoid instantiating String objects; this is usually unnecessary.
      </description>
-        <properties>
-            <property name="xpath">
-                <value>
-                    <![CDATA[
- //AllocationExpression
-  [ClassOrInterfaceType/@Image='String'][count(.//Expression) < 2][not(ArrayDimsAndInits)]
-                     ]]>
-                </value>
-            </property>
-        </properties>
         <priority>2</priority>
      <example>
--- 35,42 ----
      <rule name="StringInstantiation"
          message="Avoid instantiating String objects; this is usually unnecessary."
!         class="net.sourceforge.pmd.rules.StringInstantiation">
      <description>
  Avoid instantiating String objects; this is usually unnecessary.
      </description>
         <priority>2</priority>
      <example>

Bugs item #1114065, was opened at 2005-02-01 10:45
Message generated for change (Settings changed) made by tomcopeland
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=479921&aid=1114065&group_id=56262

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pmd
Group: None
>Status: Pending
Resolution: None
Priority: 5
Submitted By: Benoit Xhenseval (benoitx)
>Assigned to: Tom Copeland (tomcopeland)
Summary: False +: AvoidConcatenatingNonLiteralsInStringBuffer

Initial Comment:
Avoid concatenating non literals in a StringBuffer 
constructor or append()  on line 18 

public String callMe(final int high, final int chunk) {
  final StringBuffer buf = new StringBuffer(high + 
(high/chunk) +1);
....

where high + (high/chunk) +1 is an simple calculation...



----------------------------------------------------------------------

>Comment By: Tom Copeland (tomcopeland)
Date: 2005-08-30 06:22

Message:
Logged In: YES 
user_id=5159

Fixed in CVS, and you can download a new pmd-3.2.jar file here:

http://infoether.com/~tom/pmd-3.2.jar

that contains this fix.

Thanks,

Tom


----------------------------------------------------------------------

Comment By: Tom Copeland (tomcopeland)
Date: 2005-05-26 16:46

Message:
Logged In: YES 
user_id=5159

Assigning to "None" until someone can work on it...

Tom

----------------------------------------------------------------------

Comment By: Miguel Griffa (mikkey)
Date: 2005-02-14 10:19

Message:
Logged In: YES 
user_id=115982

First I was tempted to solve this by checking if they are
primitive, but this would not be a good fix, since the same
should apply to using Integer objects and something like
a.intValue() / b.intValue(), this is certainly more
difficult to catch.

----------------------------------------------------------------------

Comment By: Tom Copeland (tomcopeland)
Date: 2005-02-01 10:51

Message:
Logged In: YES 
user_id=5159

Ah, OK, at least this is just a false positive, not an NPE :-) 

Yup, it's getting confused because it's assuming that those
are Strings, when they're actually primitives.  Hm.  Maybe
we can use the symbol table to trace back to the declarations...

Thanks,

tom

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=479921&aid=1114065&group_id=56262

Update of /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules/design
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12220/src/net/sourceforge/pmd/rules/design

Modified Files:
	CompareObjectsWithEquals.java 
Log Message:
Oops, had broken a test

Index: CompareObjectsWithEquals.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules/design/CompareObjectsWithEquals.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -d -r1.9 -r1.10
*** CompareObjectsWithEquals.java	30 Aug 2005 11:02:32 -0000	1.9
--- CompareObjectsWithEquals.java	30 Aug 2005 11:12:21 -0000	1.10
***************
*** 40,44 ****
          }
  
!         Scope scope = (Scope)node.getScope();
          Map vars = scope.getVariableDeclarations();
          for (Iterator i = vars.keySet().iterator(); i.hasNext();) {
--- 40,49 ----
          }
  
!         check((Scope)node.getScope(), node, data);
!         check(node.getScope().getEnclosingMethodScope(), node, data);
!         return data;
!     }
! 
!     private void check(Scope scope, SimpleNode node, Object ctx) {
          Map vars = scope.getVariableDeclarations();
          for (Iterator i = vars.keySet().iterator(); i.hasNext();) {
***************
*** 53,62 ****
              for (Iterator j = usages.iterator(); j.hasNext();) {
                  if (((NameOccurrence)j.next()).getLocation().jjtGetParent().jjtGetParent().jjtGetParent() == node) {
!                     addViolation(data, node);
!                     return data;
                  }
              }
          }
-         return data;
      }
  }
--- 58,66 ----
              for (Iterator j = usages.iterator(); j.hasNext();) {
                  if (((NameOccurrence)j.next()).getLocation().jjtGetParent().jjtGetParent().jjtGetParent() == node) {
!                     addViolation(ctx, node);
!                     return;
                  }
              }
          }
      }
  }

Update of /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules/design
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12220/regress/test/net/sourceforge/pmd/rules/design

Modified Files:
	CompareObjectsWithEqualsTest.java 
Log Message:
Oops, had broken a test

Index: CompareObjectsWithEqualsTest.java
===================================================================
RCS file: /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules/design/CompareObjectsWithEqualsTest.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** CompareObjectsWithEqualsTest.java	30 Aug 2005 11:02:32 -0000	1.7
--- CompareObjectsWithEqualsTest.java	30 Aug 2005 11:12:21 -0000	1.8
***************
*** 17,21 ****
      public void testAll() {
         runTests(new TestDescriptor[] {
- /*
             new TestDescriptor(TEST1, "simple failure with method params", 1, rule),
             new TestDescriptor(TEST2, "primitives are ok", 0, rule),
--- 17,20 ----
***************
*** 23,27 ****
             new TestDescriptor(TEST4, "missed hit - qualified names.  that's ok, we can't resolve the types yet, so better to skip this for now", 0, rule),
             new TestDescriptor(TEST5, "more qualified name skippage", 0, rule),
- */
             new TestDescriptor(TEST6, "locals", 1, rule),
         });
--- 22,25 ----

Update of /cvsroot/pmd/pmd/etc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9079/etc

Modified Files:
	changelog.txt 
Log Message:
Fixed a bug in CompareObjectsWithEquals; now it catches some local variable cases.

Index: changelog.txt
===================================================================
RCS file: /cvsroot/pmd/pmd/etc/changelog.txt,v
retrieving revision 1.537
retrieving revision 1.538
diff -C2 -d -r1.537 -r1.538
*** changelog.txt	29 Aug 2005 13:17:38 -0000	1.537
--- changelog.txt	30 Aug 2005 11:02:32 -0000	1.538
***************
*** 33,36 ****
--- 33,37 ----
  Fixed a bug in the grammar that didn't allow constructors to have type parameters, which couldn't parse some JDK 1.5 constructs.
  Fixed a bug in ImportFromSamePackage; now it catches the case where a class has an on-demand import for the same package it is in.
+ Fixed a bug in CompareObjectsWithEquals; now it catches some local variable cases.
  Added some new XSLT scripts that create nifty HTML output; thanks to Wouter Zelle for the code.
  Improved UseCorrectExceptionLogging; thx to Wouter Zelle for the new XPath.

Update of /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules/design
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9079/src/net/sourceforge/pmd/rules/design

Modified Files:
	CompareObjectsWithEquals.java 
Log Message:
Fixed a bug in CompareObjectsWithEquals; now it catches some local variable cases.

Index: CompareObjectsWithEquals.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules/design/CompareObjectsWithEquals.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** CompareObjectsWithEquals.java	26 Jul 2005 00:56:11 -0000	1.8
--- CompareObjectsWithEquals.java	30 Aug 2005 11:02:32 -0000	1.9
***************
*** 10,13 ****
--- 10,15 ----
  import net.sourceforge.pmd.symboltable.NameOccurrence;
  import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
+ import net.sourceforge.pmd.symboltable.LocalScope;
+ import net.sourceforge.pmd.symboltable.Scope;
  
  import java.util.Iterator;
***************
*** 37,41 ****
              return data;
          }
!         MethodScope scope = node.getScope().getEnclosingMethodScope();
          Map vars = scope.getVariableDeclarations();
          for (Iterator i = vars.keySet().iterator(); i.hasNext();) {
--- 39,44 ----
              return data;
          }
! 
!         Scope scope = (Scope)node.getScope();
          Map vars = scope.getVariableDeclarations();
          for (Iterator i = vars.keySet().iterator(); i.hasNext();) {

Update of /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules/design
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9079/regress/test/net/sourceforge/pmd/rules/design

Modified Files:
	CompareObjectsWithEqualsTest.java 
Log Message:
Fixed a bug in CompareObjectsWithEquals; now it catches some local variable cases.

Index: CompareObjectsWithEqualsTest.java
===================================================================
RCS file: /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules/design/CompareObjectsWithEqualsTest.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** CompareObjectsWithEqualsTest.java	14 Jul 2005 01:49:55 -0000	1.6
--- CompareObjectsWithEqualsTest.java	30 Aug 2005 11:02:32 -0000	1.7
***************
*** 17,20 ****
--- 17,21 ----
      public void testAll() {
         runTests(new TestDescriptor[] {
+ /*
             new TestDescriptor(TEST1, "simple failure with method params", 1, rule),
             new TestDescriptor(TEST2, "primitives are ok", 0, rule),
***************
*** 22,25 ****
--- 23,28 ----
             new TestDescriptor(TEST4, "missed hit - qualified names.  that's ok, we can't resolve the types yet, so better to skip this for now", 0, rule),
             new TestDescriptor(TEST5, "more qualified name skippage", 0, rule),
+ */
+            new TestDescriptor(TEST6, "locals", 1, rule),
         });
      }
***************
*** 60,62 ****
--- 63,74 ----
      "}";
  
+     private static final String TEST6 =
+     "public class Foo {" + PMD.EOL +
+     " boolean bar() {" + PMD.EOL +
+     "  String a = \"foo\";" + PMD.EOL +
+     "  String b = \"bar\";" + PMD.EOL +
+     "  return a == b;" + PMD.EOL +
+     " }" + PMD.EOL +
+     "}";
+ 
  }

Update of /cvsroot/pmd/pmd/xdocs
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6967/xdocs

Modified Files:
	howtomakearuleset.xml 
Log Message:
Consolidating custom ruleset property docs

Index: howtomakearuleset.xml
===================================================================
RCS file: /cvsroot/pmd/pmd/xdocs/howtomakearuleset.xml,v
retrieving revision 1.15
retrieving revision 1.16
diff -C2 -d -r1.15 -r1.16
*** howtomakearuleset.xml	26 Aug 2005 10:55:48 -0000	1.15
--- howtomakearuleset.xml	30 Aug 2005 10:54:06 -0000	1.16
***************
*** 72,94 ****
  </ruleset>]]></source>
              </subsection>
-             <subsection name="Adjusting rules through properties">
-                 <p>You can adjust settings of certain rules through the &lt;properties&gt; element, like this:</p>
-                 <source><![CDATA[<rule ref="rulesets/coupling.xml/ExcessiveImports">
-   <properties>
-     <property name="minimum" value="20"/>
-   </properties>
- </rule>]]>
-                 </source>
-                 <p>You can also use a value element instead of an attribute, like this:</p>
-                 <source><![CDATA[<rule ref="rulesets/coupling.xml/ExcessiveImports">
-   <properties>
-     <property name="minimum">
-       <value>20</value>
-     </property>
-   </properties>
- </rule>]]></source>
-                 <p>This is mainly used for customizing the XPathRule. This way you can add your own custom
-                 xpath rule to your ruleset without effort.</p>
-             </subsection>
              <subsection name="Reference it in your Ant task">
                  <p>You can specify the full path to your custom ruleset name alongside
--- 72,75 ----

Update of /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29565/src/net/sourceforge/pmd/rules

Modified Files:
	UnnecessaryCaseChange.java 
Log Message:
Added descriptions to other rules with properties

Index: UnnecessaryCaseChange.java
===================================================================
RCS file: /cvsroot/pmd/pmd/src/net/sourceforge/pmd/rules/UnnecessaryCaseChange.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** UnnecessaryCaseChange.java	27 Aug 2005 00:30:07 -0000	1.1
--- UnnecessaryCaseChange.java	30 Aug 2005 09:53:39 -0000	1.2
***************
*** 23,26 ****
--- 23,27 ----
             return data;
          }
+         
  
          ASTName name = (ASTName)prefix.jjtGetChild(0);

Update of /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29565/regress/test/net/sourceforge/pmd/rules

Modified Files:
	UselessAssignmentRuleTest.java 
Log Message:
Added descriptions to other rules with properties

Index: UselessAssignmentRuleTest.java
===================================================================
RCS file: /cvsroot/pmd/pmd/regress/test/net/sourceforge/pmd/rules/UselessAssignmentRuleTest.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** UselessAssignmentRuleTest.java	23 Aug 2005 17:19:23 -0000	1.8
--- UselessAssignmentRuleTest.java	30 Aug 2005 09:53:39 -0000	1.9
***************
*** 12,16 ****
  
      public void setUp() throws RuleSetNotFoundException {
!         rule = findRule("rulesets/scratchpad.xml", "UselessAssignment");
      }
  
--- 12,16 ----
  
      public void setUp() throws RuleSetNotFoundException {
!         rule = findRule("rulesets/controversial.xml", "UselessAssignment");
      }

Update of /cvsroot/pmd/pmd/rulesets
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29565/rulesets

Modified Files:
	controversial.xml coupling.xml design.xml strings.xml 
Log Message:
Added descriptions to other rules with properties

Index: strings.xml
===================================================================
RCS file: /cvsroot/pmd/pmd/rulesets/strings.xml,v
retrieving revision 1.26
retrieving revision 1.27
diff -C2 -d -r1.26 -r1.27
*** strings.xml	27 Aug 2005 00:30:07 -0000	1.26
--- strings.xml	30 Aug 2005 09:53:39 -0000	1.27
***************
*** 16,20 ****
          <priority>3</priority>
     <properties>
!     <property name="threshold" value="4"/>
     </properties>
      <example>
--- 16,20 ----
          <priority>3</priority>
     <properties>
!     <property name="threshold" description="The number of duplicate literals reporting threshold" value="4"/>
     </properties>
      <example>

Index: design.xml
===================================================================
RCS file: /cvsroot/pmd/pmd/rulesets/design.xml,v
retrieving revision 1.85
retrieving revision 1.86
diff -C2 -d -r1.85 -r1.86
*** design.xml	15 Aug 2005 21:28:51 -0000	1.85
--- design.xml	30 Aug 2005 09:53:39 -0000	1.86
***************
*** 122,126 ****
        <priority>3</priority>
     <properties>
!     <property name="problemDepth" value="3"/>
     </properties>
      <example>
--- 122,126 ----
        <priority>3</priority>
     <properties>
!     <property name="problemDepth" description="The if statement depth reporting threshold" value="3"/>
     </properties>
      <example>
***************
*** 170,174 ****
          <priority>3</priority>
          <properties>
!          <property name="minimum" value="10"/>
          </properties>
        <example>
--- 170,174 ----
          <priority>3</priority>
          <properties>
!          <property name="minimum" description="The switch statement ratio reporting threshold" value="10"/>
          </properties>
        <example>

Index: controversial.xml
===================================================================
RCS file: /cvsroot/pmd/pmd/rulesets/controversial.xml,v
retrieving revision 1.36
retrieving revision 1.37
diff -C2 -d -r1.36 -r1.37
*** controversial.xml	5 Aug 2005 16:53:33 -0000	1.36
--- controversial.xml	30 Aug 2005 09:53:39 -0000	1.37
***************
*** 323,326 ****
--- 323,347 ----
          </rule>
  
+     <rule name="UselessAssignment"
+            message="This assignment to ''{0}'' is useless"
+            class="net.sourceforge.pmd.rules.UselessAssignment"
+            dfa="true">
+        <description>
+ This assignment is useless
+        </description>
+          <priority>3</priority>
+        <example>
+    <![CDATA[
+ public class Foo {
+  public void foo() {
+   int x = 2; // useless assignment!
+   x = 5;
+   bar(x);
+  }
+ }
+    ]]>
+        </example>
+      </rule>
+ 
  </ruleset>
  

Index: coupling.xml
===================================================================
RCS file: /cvsroot/pmd/pmd/rulesets/coupling.xml,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** coupling.xml	5 Aug 2005 16:53:33 -0000	1.12
--- coupling.xml	30 Aug 2005 09:53:39 -0000	1.13
***************
*** 16,20 ****
      <priority>3</priority>
      <properties>
!       <property name="threshold" value="20"/>
      </properties>
      <example>
--- 16,20 ----
      <priority>3</priority>
      <properties>
!       <property name="threshold" description="The unique type reporting threshold" value="20"/>
      </properties>
      <example>
***************
*** 48,52 ****
    <priority>3</priority>
    <properties>
!       <property name="minimum" value="30"/>
    </properties>
    <example>
--- 48,52 ----
    <priority>3</priority>
    <properties>
!       <property name="minimum" description="The import count reporting threshold" value="30"/>
    </properties>
    <example>

Update of /cvsroot/pmd/pmd/etc/jsl
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29565/etc/jsl

Modified Files:
	rule-format.jsl 
Log Message:
Added descriptions to other rules with properties

Index: rule-format.jsl
===================================================================
RCS file: /cvsroot/pmd/pmd/etc/jsl/rule-format.jsl,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** rule-format.jsl	29 Aug 2005 13:17:40 -0000	1.5
--- rule-format.jsl	30 Aug 2005 09:53:38 -0000	1.6
***************
*** 65,78 ****
              <j:when test="${hasproperties != 0}">
                  <p>This rule has the following properties:</p>
!                 <j:set trim="true" var="pname">
!                     <x:expr select="./properties/property/@name"/>
!                 </j:set>
!                 <j:set trim="true" var="pvalue">
!                     <x:expr select="./properties/property/@value"/>
!                 </j:set>
!                 <j:set trim="true" var="pdescription">
!                     <x:expr select="./properties/property/@description"/>
!                 </j:set>
!                 <source>Name: ${pname}<br/>Default value: ${pvalue}<br/>Description: ${pdescription}</source>
              </j:when>
          </j:choose>
--- 65,78 ----
              <j:when test="${hasproperties != 0}">
                  <p>This rule has the following properties:</p>
!                 <table><th>Name</th><th>Default value</th><th>Description</th>
!                 <x:set var="props" select="properties/property[@name!='xpath']"/>
!                 <j:forEach var="p" items="${props}">
!                     <tr>
!                     <td>${p.attributeValue("name")}</td>
!                     <td>${p.attributeValue("value")}</td>
!                     <td>${p.attributeValue("description")}</td>
!                     </tr>
!                 </j:forEach>
!                 </table>
              </j:when>
          </j:choose>