On Fri, 21 Nov 2008, Brian Gerkey wrote:
> On Nov 20, 2008, at 1:09 PM, Jonas Bähr wrote:
>> At some point in the player client lib (client_libs/libplayerc/
>> client.c around line 295) a check for AF_INET is performed. For IPv6
>> connections, the client exists with "unsupported internet address
>> family". Is player unable to manage IPv6 connections or is this a
>> legacy check simply to ensure IP based connections?
>> The problem appeared with the example0 on Mac OS X 10.5 "Leopard". On
>> this system, the hardcoded hostname "localhost" resolves to the IPv6
>> address "::1" in the first place, resulting in an AF_INET6 address
>> family which != AF_INET and though preventing the connection.
>> If one changes the example0 to make a connection to "127.0.0.1"
>> instead of "localhost", an IPv4 connection is made an everything works
> I fixed this on trunk by broadening the check to allow both AF_INET and
> AF_INET6 addresses. I verified that it fixes the problem on OS X 10.5.
> Patch is attached.
Be careful with that. As I pointed this months ago, in many places Player
stores resolved address as four-byte integer, so deeper change in Player
structures needs to be done in order to fully support ipv6.