Sorry I am aware of this, I just need time. Swamped etc.
thanks, will reply later
p
On Sun, Aug 17, 2003 at 02:15:53PM -0700, Soren Jacobsen wrote:
> patch-aa is wrong. Do not hard code /bin/ksh, because some systems (like
> my Debian system) don't have it. Instead, use ${SH}, which is defined
> per operating system. This is not possible to do with a patch, so use
> the REPLACE_INTERPRETER code. The following will do it:
>
> REPLACE_INTERPRETER+= bash
> _REPLACE.bash.old= .*/bin/bash
> _REPLACE.bash.new= ${SH}
> _REPLACE_FILES.bash= batch/starter.in
>
> I've not read over the script to ensure that it doesn't have any
> bashisms, but it appears to work on NetBSD and Debian (where /bin/sh is
> bash in 'compatibility' mode)
>
> PLIST should not contain games/armagetron/bin/starter.in.orig and is
> missing @dirrm games/armagetron/music and @dirrm games/armagetron/log.
> I'm not so sure that the log directory should even be created. I don't
> know when it is used, but it remained empty after running the game. You
> might want to browse the source and see what it's used for.
>
> --disable-etc bothers me. From what I can tell, this prevents armagetron
> from reading global configuration files from /etc/armagetron. You should
> make this package honor ${PKG_SYSCONFDIR}. See Packages.txt for more
> information.
>
> The rest looks OK to me.
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
> _______________________________________________
> pkgsrc-wip-review mailing list
> pkgsrc-wip-review@...
> https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
--
poff@...
SDF Public Access UNIX System - http://sdf.lonestar.org
Please do not carbon copy replies to me
|