Helps to attach the patch, sorry.
On Tue, 25 May 2004, Marc Mulcahy wrote:
> Hi Mark, All,
> Sorry, somehow this message got lost in my inbox. I've attached a patch
> which seems to fix the focus/keynav issues in the conversation window for
> I applied this patch, and when using ctrl-page up and ctrl-page down to
> switch tabs, the focus seems to go to the text entry widget in both
> IM and chat windows, which is the desired behavior. I'm a blind guy, so I
> don't use a mouse to switch tabs, so I can't reproduce the behavior people
> are seeing of the focus going to the wrong control when switching tabs.
> I wonder if the behavior is different when using the keyboard than it
> is when using the mouse to switch tabs.
> This patch does the following:
> * Adds tab and shift tab to the "allowable" keys processed by the
> gtkimhtml's window.
> * Removes the "focus" signal handler on the pane -- this handler prevents
> focus from ever leaving the text entry widget.
> I'd really like to get this fixed somehow -- Gaim's nearly impossible to
> use for blind folks, since you can get the focus to anything but the
> text widget with the keyboard. I'm more than happy to hack on this if
> anyone has any suggestions. sorry to be a squeaky wheel on this -- I love
> Gaim and would like to get something workable for blind users (I've been
> using a patched local copy to work around the focus/keynav issues for
> several months).
> On Wed, 24 Mar 2004, Mark Doliner wrote:
> > We should do something about this patch. It's good, but after applying it,
> > when you switch tabs on a conversation window focus is given to the top widget
> > and it needs to be given to the text entry widget.
> > I just tried to fix that for way to long, so I'm going to give up for a little
> > while. I tried messing around with the focus chain, and I made it so the text
> > entry widget is focused first, but then I couldn't get the conversation log to
> > come directly after the text entry box when typing shift+tab.
> > -Mark
> > On Mon, 08 Mar 2004 01:00:17 -0700 (MST), Marc Mulcahy wrote
> > > Hi Nathan,
> > >
> > > Gaim as it exists in CVS is difficult to use, sine although the gtkimhtml
> > > widget is accessible via the keyboard, is isn't focussable. Ths appears
> > > to be for two reasons-- one is that shift-tabs get passed to the gtkimhtml
> > > and then cause the focus to shift back to the entry. This diff
> > > fixes this by adding GDK_ISO_Left_Tab to the list of allowed keys in
> > > the gtkimhtml.
> > >
> > > The other issue is, as we've discussed previously, related to the
> > > fact that the conversation container has a signal handler on it for "focus"
> > > which always puts the focus in the entry. This makes it impossible,
> > > using only the keyboard, to focus anything but the entry. You had mentioned
> > > previously that removing the signal handler for "focus" had some
> > > undesirable side-effect in chat windows. I think it related to switching
> > > tabs. When I switch tabs to a different chat, the focus seems to be
> > > placed in the correct widget for me.
> > >
> > > Could you give me some pointers about what the desired behavior is.
> > > I'd like to implement some code to get this issue fixed, since Gaim
> > > is difficult to use as it stands now.
> > >
> > > This diff removes the focus signal handler on the pane, and adds the
> > > GDK_ISO_Left_Tab key to the allowable keys for gtkimhtml widgets.
> > > I'm successfully using Gaim with this patch and Gnopernicus now.
> > >
> > > Marc
> > --
> > O O Mark Doliner
> > \ | mark@...
> > \ | http://www.kingant.net
> > "There needs to be a better word for weird."