Bugs item #3529605, was opened at 2012-05-24 15:42
Message generated for change (Comment added) made by lem9
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3529605&group_id=23067
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Browser/W3C/JS compatibility
Group: 3.5.1
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Varun Varada (getsnoopy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Trailing Newline after PHP End Tag Causes Malfunction
Initial Comment:
It seems like every single PHP file in the 3.5.1 version has a trailing newline after the PHP end tag, so when libraries are being included, this newline causes the browser to force a text/html type on the resulting page.
This causes the /js/get_images.js.php file to incorrectly send out the text/html content-type header, which renders all of the output JavaScript to be invalid (due to the DOCTYPE tag being assumed by the browser, which is not valid JavaScript, causing a syntax error). Effectively, this whole script does not work and the page has a lot of the functionality compromised.
Please remove these trailing newlines as soon as possible.
----------------------------------------------------------------------
>Comment By: Marc Delisle (lem9)
Date: 2012-05-25 12:11
Message:
What other problem are the newlines causing?
----------------------------------------------------------------------
Comment By: Varun Varada (getsnoopy)
Date: 2012-05-25 11:19
Message:
Although having the newlines is still a problem, it seems like they weren't
causing the issue. The tidy PHP extension seems to have been the culprit,
and removing it resolved the issue.
Thank you for your effort
----------------------------------------------------------------------
Comment By: Marc Delisle (lem9)
Date: 2012-05-25 04:42
Message:
I verified with Firefox 12.0 on Windows XP + Firebug 1.9.2. The
content-type header returned by js/get_images.js.php is
text/javascript; charset=UTF-8
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3529605&group_id=23067
|