[ http://jira.pcgen.org/browse/CODE-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11073#action_11073 ]
Stefan Radermacher commented on CODE-247:
I have traced the error to a change in the class pcgen.core.analysis.BonusAddition. the first line in the applyBonus method change from (5.16.x branch version)
bonusString = target.bonusStringPrefix() + makeBonusString(bonusString, chooseString, aPC);
to (trunk version)
bonusString = makeBonusString(bonusString, chooseString, aPC);
This change was made by Tom in revision 12223 with a comment of "Remove PCLevel field from BONUS (not necessary any more as BONUS objects are stored in Class Level Objects)".
It seems the Parser does not know about this change then...
Can you check this out, please, Tom? I think is has potential to be a showstopper bug.
> Bonus levels for prestige classes saved with error
> Key: CODE-247
> URL: http://jira.pcgen.org/browse/CODE-247
> Project: Code
> Issue Type: Bug
> Components: Character Persistence
> Affects Versions: 5.17.4 (Alpha)
> Reporter: Stefan Radermacher
> Priority: Major
> Attachments: New1.pcg, New2.pcg
> Currently the bonus levels for prestige classes that are created by the ADD:SPELLCASTER tag are not saved correctly. Characters with these kind of prestige classes, once save, can no longer be loaded; loading the pcg triggers a NPE and the misleading "partyFile cannot be loaded" error dialog.
> Steps to recreate:
> Load dataset "3.5 SRD"
> Create new character
> Set any ability scores, except Intelligence at least 13
> Set any alignment
> Add one level of fighter
> Add five level of wizard
> Add any 3rd-level spell
> Add two levels of eldritch knight
> Save and close character
> Load same character again
> Result: NPE and error dialog as described above. Same procedure works as expected in 5.16.4 RC1
> Problem analysis: for prestige classes with ADD:SPELLCASTER tags, the first CLASSABILITIESLEVEL level in the pcg file contains a bracketed SAVES block. This block has changes as follows:
> from pcg saved with trunk version:
> CLASSABILITIESLEVEL:Eldritch Knight=1|HITPOINTS:3|SAVES:[SAVE:BONUS&pipe;PCLEVEL&pipe;WIZARD&pipe;1]|SKILLSGAINED:5|SKILLSREMAINING:5
> from pcg saved with 5.16.4. RC1:
> CLASSABILITIESLEVEL:Eldritch Knight=1|HITPOINTS:3|SAVES:[SAVE:BONUS&pipe;2&pipe;PCLEVEL&pipe;WIZARD&pipe;1]|SKILLSGAINED:5|SKILLSREMAINING:5
> One field, containing the number 2 (presumably the class level at which the additional caster level has been added) has been discarded from the saved string in PCGVer2Creator. The PCGVer2Parser however expects an integer in this field, hits PCLEVEL, thus the NPE.
> I'm not sure if the PCGVer2Creator is right and the PCGVer2Parser is at fault, or vice versa. Probably Tom can clear this up.
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira