On Sun, Feb 21, 2010 at 04:04:12PM +0100, Bart Van Assche wrote:
> On Sun, Feb 21, 2010 at 1:55 PM, Bart Van Assche <bvanassche@...> wrote:
> > On Fri, Feb 19, 2010 at 7:21 PM, Magnus Fromreide <magfr@...:
> >> On Fri, 2010-02-19 at 08:59 +0000, bvassche@... wrote:
> >> > Revision: 18164
> >> >
> >> > Log Message:
> >> > -----------
> >> > Exported netsnmp_parse_args() such that the Net-SNMP applications
> >> > build again when libsnmp is built as a DLL.
> >> It seems that I always forget to do that.
> >> Would there be any interest in adding something along the lines of the
> >> DECL_PUBLIC/DECL_LOCAL macros on http://gcc.gnu.org/wiki/Visibility to
> >> the code and then get rid of the .def file?
> > Such macros area already present in win32/net-snmp/net-snmp-config.h. These
> > macros can be enabled by changing the line /* #undef NETSNMP_USE_DLL */ into
> > #define NETSNMP_USE_DLL 1. This means that the .def file is redundant.
> At least, that's the theory. Apparently there are several symbols exported
> from the DLL that have not been marked with NETSNMP_IMPORT in the Net-SNMP
> header files (e.g. snmp_close(), snmp_log(), ...).
Yes, that's why I wanted to go all the way with hidden symbols in the linux
version - that would give us a chance to catch the errors even if we aren't
building on windows.