Attached patch addresses...
On 08/10/11 10:42, Keith Marshall wrote:
> ... my own testing has revealed a weakness in our mingw-dist
> manifests; specifically:
> <source tarname="foo-%-msys-%-src.tar" />
> is not sufficiently deterministic to identify the name of the source
> tarball -- the compression type is indeterminate. Likewise for:
> <licence tarname="foo-%-msys-%-lic.tar" />
> I think we should fix this, before progressing a roll out. I don't like
> the idea of an heuristic bodge, to guess a missing compression type, so
> we may either include it explicitly, e.g.:
> <source tarname="foo-%-msys-%-src.tar.lzma" />
> <licence tarname="foo-%-msys-%-lic.tar.lzma" />
> or we may exploit an extension I've added to the template substitution
> code, allowing inheritance of the same type as the associated binary:
> <source tarname="foo-%-msys-%-src.tar.%" />
> <licence tarname="foo-%-msys-%-lic.tar.%" />
...this mechanism, i.e. append ".%" to represent compression type, in
all cases where it isn't specified explicitly. (This requires that all
component packages within each individual release, including source,
must be packaged with the same compression type; this probably isn't too
much of a hardship).
This patch also addresses...
> Finally, in addition to this compression type mapping issue, I've also
> identified an anomaly specific to the msys-core package specification;
> the tarname:
> conveys no canonical relationship to the package name, msys-core. (This
> affects the implementation, which I've also added to CVS, of the
> capability to anonymously upgrade all installed packages). The easiest
> work around for this is to add an alias:
> <package name="msys-core" alias="msysCORE">
Okay to commit, and publish?