On Tue, 2011-02-08 at 16:19 -0500, hello@... wrote:
> Hey Stephane,
> I've modified the greeter to use glade instead of the hard coded
> interface in hopes that it would help people further customize their
> theme. I've added options to hide some of the menu item's that I didn't
> want in my environment (language, session, shutdown). It also addresses
> the issue of the window spreading across multiple screens. I posted the
> links in #ltsp on freenode but figured that I would email you as well.
> Vagrantc mentioned that he thought it originally used glade and was
> changed because of performance issues but I don't believe I experienced
> any, nor did I find anything related to glade in the change log
> http://bazaar.launchpad.net/~ltsp-upstream/ltsp/ldm-trunk/changes/ ,
> but perhaps I missed it or was looking in the wrong place. If you think
> others might find it useful perhaps you can incorporate the changes in
> later releases? My updates can be found at:
> greeter.c: http://paste2.org/p/1236307
> greeter.glade: http://paste2.org/p/1236315
> greeter.xml: http://paste2.org/p/1236313
> Best Regards
> Matt Janus
Thanks for the awesome work. Moving to a glade file would definitely
help people customize the greeter.
Something I noticed is that you seem to have based your changes on a
relatively old version of the greeter and introduce quite a few extra
changes (white spaces, trailing white space, ...) making it hard for us
to review and merge into upstream ldm.
Our current code is available using bzr:
bzr get lp:~ltsp-upstream/ltsp/ldm-trunk
I'd really appreciate it if you could make your changes on top of that
and either send us a patch or even better, a bzr branch of your changes.
If you have a Launchpad account, you can simply, do:
bzr commit -m "Some description"
Every-time you do a major change to the code, then when you're done, do:
bzr push lp:~<username>/ltsp/ldm-trunk-glade
To push your changes to Launchpad so we can easily see what got changed
and merge that into our main branch while still keeping information
about every commit you did.
Once again, thanks for the awesome work and please let us know if you
need any additional information.