at the moment I get one difference in bugtests/test392.
I'm still on it.
On 2/28/07, Oti <ohumbel@...> wrote:
> I found 2 occurrences in
> and the comments around there strongly indicate that these are
> precompiled classes.
> On the other hand, there is code in
> where an inner class named _PyInner is added.
> Since inner classes are separated by a $ sign from the surrounding
> class, something ending in $_PyInner.class is very likely to result.
> See also:
> It is almost impossible for me to detect other secret class name endings.
> There is a comment in PathPackageManager saying
> * Figure out if we have a directory a mixture of python and
> * java or just an empty directory (which means Java) or a
> * directory with only Python source (which means Python).
> So, from a high level view, your approach of preventing
> $_PyInner.class from indicating a mixture (leading to java) seems
> Regarding your concerns about really mixing java packages and python
> modules, I believe we should not get too paranoid about that. IMHO
> common sense will prevent people from messing with such a setup.
> I suggest I run the tests with and without your patch, and if I do not
> encounter strange effects, it'll get in.
> Thanks again!
> On 2/28/07, Alan Field <Alan.Field@...> wrote:
> > Oti,
> > Thanks a lot. Finding the debug messages was really a big help. I did not know about them until I found them in the source code, and then checked the registry file. The messages helped to narrow down which method was behaving incorrectly. Good luck finding the other jythonc file extensions. I haven't had any luck so far.
> > The more I think about this, the more I am concerned though. Basically my import was failing because the directory was being flagged as both a Java and Python package. Adding the test for "$_PyInner.class" will fix my situation, but it seems like the import will still fail if I have a Java class in the default package in the same directory as a Python "__init__.py" file. I'll try an experiment to see if this is true, but I think this is a scenario that should work.
> > Thanks,
> > Alan
> > -----Original Message-----
> > From: Oti [mailto:ohumbel@...]
> > Sent: Wednesday, February 28, 2007 3:27 PM
> > To: Alan Field
> > Cc: Charlie Groves; jython users; Jython-Dev
> > Subject: Re: [Jython-users] Problems with import and Jython 2.2 Beta1...
> > Alan,
> > my compliments - great analysis !
> > Unfortunately I do not know enough about jythonc to give a list of possible class file endings. I'll check if I can find the $_PyInner.class somewhere in the code and deduce the rest from it.
> > best wishes,
> > Oti.