Gerwin Klein wrote:
> So you are still seeing differences in the trunk version that I (thought I)
> fixed with my last checkin?
Weird - I didn't realize that you'd made any checkins to the testsuite,
but just now after updating, and checking the svn log, I can see:
---------------------------------------------------------------------
r450 | lsf37 | 2009-02-16 06:50:22 -0500 (Mon, 16 Feb 2009) | 3 lines
port fix for most-negative int literal from 1.4.3 examples
adjust test output
For some reason, I never received the commit notification for this
revision (450), but I got the emails for both the one before and the one
after (449 and 451). If you separately emailed to the dev list about
this commit, I never saw that either.
> My default encoding used to be iso-latin-1 (= iso-8859-1). It is
> possible that it has switched to MacRoman with my last checkins.
Now that I have your trunk fix, and if I add -Dfile.encoding=MacRoman to
the command line when I run the generated Java scanner over
java-1.input, I no longer see any differences with the expected
java-1.output. Whew!
> In a new version of this test suite, we should take care to make it more
> platform independent. That includes annotating which character encoding inputs
> are. The current version was never meant to be released, it was just my personal
> set of test runs. Sorry for all the problems this is causing.
No problem :). Good idea about the char encoding annotation.
Steve
> Steve Rowe wrote:
>> Hi Gerwin,
>>
>> I think some of the differences I'm seeing in the test suite Java
>> testcase have to do with the default file encoding.
>>
>> Here's the output from "java -cp jflex-1.4.3.jar JFlex.Main --info" for me:
>>
>> Java version: 1.4.2_17
>> Runtime name: Java(TM) 2 Runtime Environment, Standard Edition
>> Vendor: Sun Microsystems Inc.
>> VM version: 1.4.2_17-b06
>> VM vendor: Sun Microsystems Inc.
>> VM name: Java HotSpot(TM) Client VM
>> VM info: mixed mode
>> OS name: Windows Vista
>> OS arch: x86
>> OS version: 6.0
>> Encoding: Cp1252
>> JFlex version: 1.4.3
>>
>> What's the default file encoding for you? I can attempt to use that via
>> -Dfile.encoding when I run the Java test case to see if that reduces the
>> differences (I suspect it will).
>>
>> Thanks,
>> Steve
>>
>> Steve Rowe wrote:
>>> Hi Gerwin,
>>>
>>> Have you had a chance to look at the output I sent?
>>>
>>> I also tested on Linux (Sun JDK 1.5.0_15), and got the same failure
>>> result for the java testcase's java-1.input, using both JFlex 1.4.3 and
>>> 1.5.0-SNAPSHOT.
>>>
>>> Here's what I have done to manually run the test:
>>>
>>> PROMPT$ java -cp ~/.m2/repository/de/jflex/jflex/1.4.3/jflex-1.4.3.jar
>>> java.jflex
>>> PROMPT$ javac Java.java
>>> PROMPT$ java -cp . Java java-1.input > new-java-1.output
>>> PROMPT$ diff java-1.output new-java-1.output
>>>
>>> Is that the correct process?
>>>
>>> If so, I'm confused about what's happening - seems like you should be
>>> getting the same results as me.
>>>
>>> Steve
>>>
>>> Steve Rowe wrote:
>>>> Hi Gerwin,
>>>>
>>>> Gerwin Klein wrote:
>>>>> Hi Steve,
>>>>>
>>>>>> I've been trying to track down why the testsuite "java" test case
>>>>>> fails for me under the java5 branch.
>>>>>>
>>>>>> I have not been able to get the testsuite working under the 1.4.3
>>>>>> tag, so instead I manually generated, compiled, and ran the scanner
>>>>>> against the input files in the "java" test case using the JFlex 1.4.3
>>>>>> jar, and I found that for one of the three input files
>>>>>> (java-1.input), 1.4.3 also does not produce the expected result
>>>>>> (java-1.output).
>>>>> That is strange. The test case works for me for 1.4.3 (on MacOS and
>>>>> Linux). Can you send the difference? It could be that there is
>>>>> something platform dependent going on.
>>>> I've attached the (gzip'd) output using the "java" scanner running under
>>>> Windows Vista 64-bit, with java-1.input as the input.
>>>>
>>>> The scanner that produced the attached file was generated using Sun's
>>>> 1.4.2_17 JVM. I compiled and ran the scanner under the same version's
>>>> compiler & JVM.
>>>>
>>>> I tested all permutations of the variables below (under Windows Vista
>>>> 64-bit), and all produced the same output:
>>>>
>>>> - Bash shell under Cygwin vs. Windows cmd.exe
>>>> - Sun 1.4.2_17 (32-bit) JDK vs. Sun's 1.5.0_15 (64-bit) JDK
>>>> - JFlex 1.4.3 vs. JFlex 1.5.0-SNAPSHOT
>>>>
>>>> BTW, to perform the diff, I used both the --strip-trailing-cr and --text
>>>> options to diff, since the output under Windows contains carriage
>>>> returns, and the output from java-1.input makes "diff" think that it's
>>>> binary.
>>>>
>>>> Steve
>>> ------------------------------------------------------------------------------
>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
>>> -Strategies to boost innovation and cut costs with open source participation
>>> -Receive a $600 discount off the registration fee with the source code: SFAD
>>> http://p.sf.net/sfu/XcvMzF8H
>>> _______________________________________________
>>> Jflex-devel mailing list
>>> Jflex-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/jflex-devel
>>>
>>>
>>
>> ------------------------------------------------------------------------------
>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
>> -Strategies to boost innovation and cut costs with open source participation
>> -Receive a $600 discount off the registration fee with the source code: SFAD
>> http://p.sf.net/sfu/XcvMzF8H
>> _______________________________________________
>> Jflex-devel mailing list
>> Jflex-devel@...
>> https://lists.sourceforge.net/lists/listinfo/jflex-devel
>
> ------------------------------------------------------------------------------
> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
> -Strategies to boost innovation and cut costs with open source participation
> -Receive a $600 discount off the registration fee with the source code: SFAD
> http://p.sf.net/sfu/XcvMzF8H
> _______________________________________________
> Jflex-devel mailing list
> Jflex-devel@...
> https://lists.sourceforge.net/lists/listinfo/jflex-devel
>
>
|