Paul Landes wrote:
> I've made a lot of changes that are somewhat drastic. I've folded in
> a good chunk of the outstanding changes I've had. The biggest changes
I've had a quick look at some of this and have some comments/questions...
(BTW for anyone using the new jde-import-preferred-packages, this
variable has been renamed to jde-preferred-packages)
I tried out the new function jde-describe-path but it does not work:
jde-describe-path: Wrong number of arguments: (lambda (target old new) (replace-regexp-in-string old new target)), 4
The java fontlock has a few changes that aren't necessarily improvements:
- import declarations used to visually distinguish between the package
and the type name (using the faces font-lock-constant-face and
font-lock-type-face). Now it's all one face
jde-java-font-lock-package-face, which loses the visual distinction
- probably we need to extend this with an extra face to regain the
distinction.
- Javadocs went from font-lock-doc-face to font-lock-comment-face.
Again, there used to be a visual distinction between the two which
was very useful, but now there isn't. I think this one should be
reverted.
It also undoes the defaults for jde-help-docsets. Is that because
there is then the problem of deciding what libraries to include in the
default list? I think it's good to have some of the popular libraries
in there by default, and it gives a better example for people to then
customize themselves.
jde-exception-goto - I tried it out and it seems to work fine, but
what is the difference between this and the existing jde-run-etrace-*
functions (which include a next/prev functionality)?
There are also the beginnings of refactoring operations, which is cool
(but I don't think htmlize code isn't really refactoring, so should be
moved to another menu).
Cheers,
Len.
|