Home / Browse / JDEE / Mail / Archive

JDEE

Email Archive: jdee-devel (read-only)

2008:	_Jan (29)	_Feb (1)	_Mar (24)	_Apr (3)	_May (22)	_Jun (20)	_Jul (2)	_Aug (6)	_Sep (27)	_Oct (16)	_Nov (66)	_Dec (45)
2009:	_Jan (3)	_Feb	_Mar (5)	_Apr (18)	_May (24)	_Jun	_Jul (4)	_Aug (87)	_Sep (19)	_Oct (16)	_Nov (10)	_Dec (22)
2010:	_Jan (48)	_Feb	_Mar (7)	_Apr (17)	_May (11)	_Jun (13)	_Jul	_Aug	_Sep (2)	_Oct	_Nov (4)	_Dec
2011:	_Jan	_Feb	_Mar (1)	_Apr	_May (1)	_Jun (9)	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec
2012:	_Jan	_Feb	_Mar	_Apr	_May	_Jun	_Jul	_Aug	_Sep (4)	_Oct (3)	_Nov (1)	_Dec
2013:	_Jan	_Feb	_Mar (2)	_Apr (18)	_May (27)	_Jun	_Jul	_Aug	_Sep	_Oct	_Nov	_Dec


S	M	T	W	T	F	S
						1

2	3	4	5	6	7	8
(5)	(3)	(2)		(12)	(2)
9	10	11	12	13	14	15
	(5)	(3)	(29)	(6)		(1)
16	17	18	19	20	21	22
(2)	(1)		(2)	(5)	(7)
23	24	25	26	27	28	29
			(2)
30	31

[jdee-devel] Allow more context in recognizing jde-lib-directory-names (again)

From: Jeff Peck <jpjnk4-jdee@ya...> - 2009-08-26 21:44

Attachments: Message as HTML

I think this patch to jde-expand-classpath makes good sense:
a) it means things named: ".../jarx" or ".../lib2" are not seen as *.jar repositories
    (for backward compatibility, you could use: (list "/lib[^/]*$" "/jar[^/]*$") )
b) it means one can say: "/lib/ext$" *is* a jar repository
as in: '(jde-lib-directory-names '("/lib$" "/jar$" "/lib/ext$"))
which I need and could find no way to express, without including other foo/ext directories...
(and writing a jde-excluded-file-names to remove the extraneous files seems wrong;
 I expect the excluded list to operate on the 'tail' of the filename, not on the upper directories)

patch to jde.el:
:lisp>diff jde.el.~1~ jde.el
527c527
< (defcustom jde-lib-directory-names (list "^lib" "^jar")
---
> (defcustom jde-lib-directory-names (list "/lib$" "/jar$")
1519,1523c1519,1522
<      (let ((dir-name (file-name-nondirectory path)))
<        (member-if 
<         (lambda (lib-name)
<    (string-match lib-name dir-name))
<         jde-lib-directory-names)))
---
>      ;; (2008-08-26: examine whole path name)
>      (member-if 
>         (lambda (lib-name) (string-match lib-name path))
>         jde-lib-directory-names)

[jdee-devel] Allow more context in recognizing jde-lib-directory-names

From: Jeff Peck <jpjnk4-jdee@ya...> - 2009-08-26 21:36

I think this patch to jde-expand-classpath makes 
good sense:
a) it means things named: ".../jarx" or ".../lib2" 
are not seen as *.jar repositories
    (for backward compatibility, 
you could use: (list "/lib[^/]*$" 
"/jar[^/]*$") )
b) it means one can say: "/lib/ext$" *is* a jar 
repository
as in: '(jde-lib-directory-names '("/lib$" "/jar$" 
"/lib/ext$"))
which I need and could find no way to express, 
without including other foo/ext directories...
(and writing a jde-excluded-file-names to remove 
the extraneous files seems wrong;
 I expect the excluded list to operate on the 
'tail' of the filename, not on the upper directories)
 
patch to jde.el:
:lisp>diff jde.el.~1~ jde.el
527c527
< (defcustom jde-lib-directory-names (list "^lib" "^jar")
---
> (defcustom jde-lib-directory-names (list "/lib$" "/jar$")
1519,1523c1519,1522
<   (let ((dir-name (file-name-nondirectory path)))
<     (member-if 
<      (lambda (lib-name)
< (string-match lib-name dir-name))
<      jde-lib-directory-names)))
---
>    ;; (2008-08-26: examine whole 
path name)

>    (member-if 
>       (lambda (lib-name) (string-match lib-name path))
>       jde-lib-directory-names))

Re: [jdee-devel] [jdee-users] Using `define-derived-mode'

From: Paul Landes <landes@ma...> - 2009-08-16 20:20

Ludovic,

Thanks for the stripped paths!  This makes my life easier.

Switching to derived mode is a pretty big change.  Let's save this for
a point release so we don't have too many (big) things changing for a
release.

As mentioned before, please post these patches to:

  jdee-devel@...

and not

  jdee-users@...

The first email is for patches and development discussion.  The latter
is for user questions, feature suggestions and all things related to
users.

Also, it isn't necessary for more than one person to copyright, and
usually undesirable, a source code file per year.

Thanks Ludovic.


Ludovic Courtès writes:
 > Hi,
 > 
 > ludo@... (Ludovic Courtès) writes:
 > 
 > > Is there any reason for not using `define-derived-mode' when defining
 > > `jde-mode'?  (I see code that uses it is commented out.)
 > >
 > > It turns out that not using it can have undesirable side-effects and
 > > lead to "non-deterministic" behavior.
 > >
 > > What happened to me recently is that the first Java file I opened during
 > > my Emacs session was with `C-x C-f' from a Gnus *Group* buffer.
 > > Consequently, `jde-mode-map' inherited Gnus bindings, which, needless to
 > > say, is quite inconvenient.  ;-)
 > 
 > The attached patch (with stripped paths!) fixes that.
 > 
 > Can someone review it?
 > 
 > Thanks,
 > Ludo'.
 > 
 > >From 9e49921cb9a220324c22b55300a85a46f7f917bf Mon Sep 17 00:00:00 2001
 > From: =?utf-8?q?Ludovic=20Court=C3=A8s?= <ludo@...>
 > Date: Fri, 14 Aug 2009 13:04:32 +0200
 > Subject: [PATCH] Use kosher mode definition to make `jde-mode' deterministic.
 > 
 > This makes `jde-mode' actually deterministic.  Previous method had it
 > depend on the mode current when it was called.  See
 > http://thread.gmane.org/gmane.emacs.jdee.user/196 for a discussion.
 > 
 > * jde/lisp/jde.el (jde-mode): Now defined using `define-derived-mode'.
 >   (jde-mode-internal): New, from former `jde-mode'.  Remove low-level
 >   mode bit fiddling.  Add `easy-menu-define' call for GNU Emacs.
 > ---
 >  jde/lisp/jde.el |   41 +++++++++++++++--------------------------
 >  1 files changed, 15 insertions(+), 26 deletions(-)
 > 
 > diff --git a/jde/lisp/jde.el b/jde/lisp/jde.el
 > index 28b31e5..0a79adb 100644
 > --- jde/lisp/jde.el
 > +++ jde/lisp/jde.el
 > @@ -7,6 +7,7 @@
 >  
 >  ;; Copyright (C) 1997-2008 Paul Kinnucan.
 >  ;; Copyright (C) 2009 by Paul Landes
 > +;; Copyright (C) 2009 Ludovic Courtès
 >  
 >  ;; GNU Emacs is free software; you can redistribute it and/or modify
 >  ;; it under the terms of the GNU General Public License as published by
 > @@ -828,35 +829,20 @@ This command invokes the function defined by `jde-build-function'."
 >    (interactive)
 >    (call-interactively (car jde-build-function)))
 >  
 > -; (define-derived-mode
 > -;   jde-mode java-mode "JDE"
 > -;   "Major mode for developing Java applications and applets.
 > -;   \\{jde-mode-map}"
 > -;   (jde-mode-internal)
 > -; )
 > -
 > -;; The following is the expansion of the above macro.
 > -;; We include the expansion to permit automatic
 > -;; loading of the JDE.
 > -(derived-mode-init-mode-variables 'jde-mode)
 > -(put 'jde-mode 'derived-mode-parent 'java-mode)
 > -
 >  ;;;###autoload
 > -(defun jde-mode ()
 > +(define-derived-mode
 > +  jde-mode java-mode "JDE"
 >    "Major mode for developing Java applications and applets.
 > +
 >  \\{jde-mode-map}"
 > -  (interactive)
 > +  (jde-mode-internal))
 > +
 > +
 > +(defun jde-mode-internal ()
 > +  "Initialization of `jde-mode'."
 >    (condition-case err
 >        (progn
 >  	(jde-check-versions)
 > -	(java-mode)
 > -	(if (get 'java-mode 'special)
 > -	    (put 'jde-mode 'special t))
 > -	(setq major-mode 'jde-mode)
 > -	(setq mode-name "JDE")
 > -	(derived-mode-set-keymap 'jde-mode)
 > -	(derived-mode-set-syntax-table 'jde-mode)
 > -	(derived-mode-set-abbrev-table 'jde-mode)
 >  
 >  	;; Define buffer-local variables.
 >  	(make-local-variable 'jde-project-name)
 > @@ -892,9 +878,12 @@ This command invokes the function defined by `jde-build-function'."
 >  	(unless (member 'jde-clean-up-after-jde kill-buffer-hook)
 >  	  (add-hook 'kill-buffer-hook 'jde-clean-up-after-jde))
 >  
 > -	(when jde-xemacsp
 > -	  (require 'jde-xemacs)
 > -	  (jde-insert-menu-in-xemacs-menubar))
 > +	(if jde-xemacsp
 > +	    (progn
 > +	      (require 'jde-xemacs)
 > +	      (jde-insert-menu-in-xemacs-menubar))
 > +	  (easy-menu-define jde-menu jde-mode-map "JDE"
 > +	    jde-menu-definition))
 >  
 >  	;; Define underscore as a word constituent. This is needed
 >  	;; to support coding styles the begin fields with an underscore.
 > -- 
 > 1.6.1.3
 > 
 > ------------------------------------------------------------------------------
 > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
 > trial. Simplify your report design, integration and deployment - and focus on 
 > what you do best, core application coding. Discover what's new with 
 > Crystal Reports now.  http://p.sf.net/sfu/bobj-july_______________________________________________
 > jdee-users mailing list
 > jdee-users@...
 > https://lists.sourceforge.net/lists/listinfo/jdee-users


-- 
Paul Landes
landes@...

Re: [jdee-devel] [jdee-users] Using `define-derived-mode'

From: <ludo@gn...> - 2009-08-17 07:59

Hello Paul,

Paul Landes <landes@...> writes:

> Switching to derived mode is a pretty big change.  Let's save this for
> a point release so we don't have too many (big) things changing for a
> release.

It looked to me that there were very few changes in the source code.
The diffstat says this:

  jde/lisp/jde.el |   41 +++++++++++++++--------------------------
  1 files changed, 15 insertions(+), 26 deletions(-)

But more importantly, I think it's an important bug-fix.  See the
original bug report at http://thread.gmane.org/gmane.emacs.jdee.user/196 .
I believe it makes it hard to use JDE for anyone non-elisp savvy, and
it's a significant annoyance anyway.

What do you think?  Did you ever hit this problem?

> As mentioned before, please post these patches to:
>
>   jdee-devel@...

Oops, right.  Sorry about this.

> Also, it isn't necessary for more than one person to copyright, and
> usually undesirable, a source code file per year.

Per copyright laws, anyone contributing something "legally significant"
is a copyright holder.  Copyright lines like this list copyright
holders, so it sounds right to me to add such lines for all contributors
(see, for example, source files in the Linux kernel:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=kernel/audit.h;h=208687be4f30c8a2ddb432e3c1b8594fb85d2e8e;hb=894ef820b10d77e2d6d717342fc408bdd9825139 ).

(I initially spotted this because my ~/.emacs contains
"(add-hook 'write-file-functions 'copyright-update)".)

Thanks,
Ludo'.

Re: [jdee-devel] [jdee-users] Using `define-derived-mode'

From: Paul Landes <landes@ma...> - 2009-08-21 04:15

Ludovic Courtès writes:
 > Hello Paul,
 > 
 > Paul Landes <landes@...> writes:
 > 
 > > Switching to derived mode is a pretty big change.  Let's save this for
 > > a point release so we don't have too many (big) things changing for a
 > > release.
 > 
 > It looked to me that there were very few changes in the source code.
 > The diffstat says this:
 > 
 >   jde/lisp/jde.el |   41 +++++++++++++++--------------------------
 >   1 files changed, 15 insertions(+), 26 deletions(-)

Not in terms of lines, but in terms of using a completely different
method to create the mode.

 > But more importantly, I think it's an important bug-fix.  See the
 > original bug report at http://thread.gmane.org/gmane.emacs.jdee.user/196 .
 > I believe it makes it hard to use JDE for anyone non-elisp savvy, and
 > it's a significant annoyance anyway.
 > 
 > What do you think?  Did you ever hit this problem?

I haven't, but you're missing my point.  I'm not saying I think it
shouldn't go in but that we make a release just for this to nail down
issues related to switching to it.

 > > Also, it isn't necessary for more than one person to copyright, and
 > > usually undesirable, a source code file per year.
 > 
 > Per copyright laws, anyone contributing something "legally significant"
 > is a copyright holder.  Copyright lines like this list copyright
 > holders, so it sounds right to me to add such lines for all contributors
 > (see, for example, source files in the Linux kernel:
 > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=kernel/audit.h;h=208687be4f30c8a2ddb432e3c1b8594fb85d2e8e;hb=894ef820b10d77e2d6d717342fc408bdd9825139 ).

If we added a copyright for everyone that contributed patches, we'd
have source code files that were more comments than code.  I think
it's more than sufficient for one contributor to put the copyright if
it ever went to court--which is highly unlikely.

 > (I initially spotted this because my ~/.emacs contains
 > "(add-hook 'write-file-functions 'copyright-update)".)

You might want to remove that for this project.

-- 
Paul Landes
landes@...

Re: [jdee-devel] [jdee-users] Using `define-derived-mode'

From: <ludo@gn...> - 2009-08-21 08:53

Hi Paul,

Paul Landes <landes@...> writes:

> Ludovic Courtès writes:

[...]

>  > But more importantly, I think it's an important bug-fix.  See the
>  > original bug report at http://thread.gmane.org/gmane.emacs.jdee.user/196 .
>  > I believe it makes it hard to use JDE for anyone non-elisp savvy, and
>  > it's a significant annoyance anyway.
>  > 
>  > What do you think?  Did you ever hit this problem?
>
> I haven't, but you're missing my point.  I'm not saying I think it
> shouldn't go in but that we make a release just for this to nail down
> issues related to switching to it.

Well, you're the release manager I guess.  ;-)

As a user I'd be really happy if it was integrated ASAP, though, because
it fixes a serious bug for me.  I found it easy to test it, which is why
I thought it could be applied in the 2.4.0 branch.

Thanks,
Ludo'.

[jdee-devel] execute bit removed

From: Daniel Flesner <danimal@ag...> - 2009-08-20 15:00

can someone turn the execute bit back on on the jtags scripts.

    svn propset executable true lisp/jtags*

thanks,

[jdee-devel] execute bit removed

From: Paul Landes <landes@ma...> - 2009-08-21 04:42

Done, sorry for the annoyance and thanks for finding this.

Daniel Flesner writes:
 > 
 > can someone turn the execute bit back on on the jtags scripts.
 > 
 >     svn propset executable true lisp/jtags*
 > 
 > thanks,
 > 
 > ------------------------------------------------------------------------------
 > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
 > trial. Simplify your report design, integration and deployment - and focus on 
 > what you do best, core application coding. Discover what's new with 
 > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
 > _______________________________________________
 > jdee-devel mailing list
 > jdee-devel@...
 > https://lists.sourceforge.net/lists/listinfo/jdee-devel


-- 
Paul Landes
landes@...

Re: [jdee-devel] execute bit removed

From: Daniel Flesner <danimal@ag...> - 2009-08-21 06:48

np, and thanks for all the hard work.

Paul Landes <landes@...> writes:

> Done, sorry for the annoyance and thanks for finding this.
>
> Daniel Flesner writes:
>  > 
>  > can someone turn the execute bit back on on the jtags scripts.
>  > 
>  >     svn propset executable true lisp/jtags*
>  > 
>  > thanks,
>  > 
>  > ------------------------------------------------------------------------------
>  > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
>  > trial. Simplify your report design, integration and deployment - and focus on 
>  > what you do best, core application coding. Discover what's new with 
>  > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>  > _______________________________________________
>  > jdee-devel mailing list
>  > jdee-devel@...
>  > https://lists.sourceforge.net/lists/listinfo/jdee-devel

[jdee-devel] Can't find bsh.jar in build/

From: Daniel Clemente <dcl441-bugs@ya...> - 2009-08-19 12:54

Hi,
  I'm very confused with JDEE installation (latest 2.4 from SVN). After too much fighting I can run „ant build“ without errors, and this has created a new directory build/ which contains classes/ config/ and lisp/

  Now I got this error when trying to browse to a class: 

Debugger entered--Lisp error: (error "Specified BeanShell jar filed does not exist: /home/dc/.emacs.d/jde-2.4-svn/build/java/lib/bsh.jar")

  Here I see a problem: there is no directory build/java. There is a java/ directory, but it is at the same level as build/
  Therefore:
- 1. either JDEE should look for bsh.jar in the correct path, /home/dc/.emacs.d/jde-2.4-svn/java/lib/bsh.jar
- 2. or java/ should be copied to build/
- 3. or something else is failing for me

  I'd prefer the first solution. I already have set 'bsh-jar to the correct path, but it isn't taken into account.
  This behaviour comes probably from this code, which should use bsh-jar:


(defmethod initialize-instance ((this jde-bsh) &rest fields)
  "Constructor for the JDEE BeanShell instance."
  (call-next-method)
  (let* ((jde-java-directory
	  (concat
	   (jde-find-jde-data-directory)
	   "java/")))

    (oset this bsh-cmd-dir (expand-file-name "bsh-commands" jde-java-directory))
    (oset this checkstyle-jar  (expand-file-name "lib/checkstyle-all.jar" jde-java-directory))
    (oset this regexp-jar (expand-file-name "lib/jakarta-regexp.jar" jde-java-directory))
    (oset this jde-classes-dir (expand-file-name "classes" jde-java-directory))
    (oset this jde-jar (expand-file-name "lib/jde.jar" jde-java-directory))
→→→ (oset this jar  (expand-file-name "lib/bsh.jar" jde-java-directory))
    (oset-default 'jde-bsh the-bsh this)))


-- Daniel

Re: [jdee-devel] Can't find bsh.jar in build/

From: Len Trigg

Daniel Clemente wrote:
>   I'm very confused with JDEE installation (latest 2.4 from SVN). After too much fighting I can run „ant build“ without errors, and this has created a new directory build/ which contains classes/ config/ and lisp/

You need to run ant dist, and point your emacs at the version of files
that are created there.

I agree that it is confusing. The current doc/install.html does
suggest that running from the build directory should be possible, but
as you note, things are not in the correct places - I have amended the
docs for the time being.

Cheers,
Len.

Re: [jdee-devel] Can't find bsh.jar in build/

From: Daniel Clemente <dcl441-bugs@ya...> - 2009-08-20 10:24

> You need to run ant dist, and point your emacs at the
> version of files
> that are created there.
> 
Thanks. The default="dist" in build.xml also helps.

Re: [jdee-devel] Can't find bsh.jar in build/

From: Paul Landes <landes@ma...> - 2009-08-21 04:35

Pointing `load-path' to the dist/lisp directory is more for
developers.  The more typical usage is `ant install', which uses the
more conventional `./configure ; make ; make install' approach.  This
copies the ant/dist dir to ${prefix.dir}.  Put this property in
build.properties or ~/.jdee.properties.


Len Trigg writes:
 > Daniel Clemente wrote:
 > >   I'm very confused with JDEE installation (latest 2.4 from SVN). After too much fighting I can run ?ant build? without errors, and this has created a new directory build/ which contains classes/ config/ and lisp/
 > 
 > You need to run ant dist, and point your emacs at the version of files
 > that are created there.
 > 
 > I agree that it is confusing. The current doc/install.html does
 > suggest that running from the build directory should be possible, but
 > as you note, things are not in the correct places - I have amended the
 > docs for the time being.
 > 
 > Cheers,
 > Len.
 > 
 > ------------------------------------------------------------------------------
 > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
 > trial. Simplify your report design, integration and deployment - and focus on 
 > what you do best, core application coding. Discover what's new with 
 > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
 > _______________________________________________
 > jdee-devel mailing list
 > jdee-devel@...
 > https://lists.sourceforge.net/lists/listinfo/jdee-devel


-- 
Paul Landes
landes@...

Re: [jdee-devel] Can't find bsh.jar in build/

From: Paul Landes <landes@ma...> - 2009-08-21 04:40

Changing the actual build.xml file isn't the normal use case, if I
understand what you mean here.  That is you don't want to change the
default at the project attribute level of the build.xml.  Rather you
want to do:


$ ant dist

The target is the first parameter to ant.

Daniel Clemente writes:
 > 
 > > You need to run ant dist, and point your emacs at the
 > > version of files
 > > that are created there.
 > > 
 > Thanks. The default="dist" in build.xml also helps.
 > 
 > 
 > 
 > 
 >       
 > 
 > ------------------------------------------------------------------------------
 > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
 > trial. Simplify your report design, integration and deployment - and focus on 
 > what you do best, core application coding. Discover what's new with 
 > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
 > _______________________________________________
 > jdee-devel mailing list
 > jdee-devel@...
 > https://lists.sourceforge.net/lists/listinfo/jdee-devel


-- 
Paul Landes
landes@...