jcommander-tracker-notifications Mailing List for jCommander

Bugs item #3176737, was opened at 2011-02-09 20:09
Message generated for change (Tracker Item Submitted) made by leeif
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=3176737&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: leeif (leeif)
Assigned to: Nobody/Anonymous (nobody)
Summary: CVS not working

Initial Comment:
CVS not working

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=3176737&group_id=35271

Feature Requests item #1563276, was opened at 2006-09-22 05:44
Message generated for change (Comment added) made by sky_halud
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413698&aid=1563276&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: File Panel
Group: 0.7.5
Status: Open
Resolution: Accepted
Priority: 6
Private: No
Submitted By: demesne (demesne)
Assigned to: Nobody/Anonymous (nobody)
Summary: Address bar and Auto-completion

Initial Comment:
It would be good if there were an address bar and
auto-completion at the top of each pane, for quicker
access to directories and files.

----------------------------------------------------------------------

>Comment By: Robert Enyedi (sky_halud)
Date: 2010-05-16 07:08

Message:
Thodin, I think that's a good idea. Having seen a similar functionality in
Total Commander, the JDT UI functionality seems superior. Do you want to
trye an "extraction" from JDT?

----------------------------------------------------------------------

Comment By: mantrid (thodin)
Date: 2010-05-10 21:36

Message:
How about adding a breadcrumb instead - just like one in JDT? we could rip
it from org.eclipse.jdt.ui plugin at
org.eclipse.jdt.internal.ui.javaeditor.breadcrumb

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2006-09-22 10:16

Message:
Logged In: YES 
user_id=940779

The additional features required are:
- make the existing address bar editable;
- add a listener for the ENTER key plus a "Go" button for
opening the manually entered directory;
- provide autocompletion based on the directory structure.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413698&aid=1563276&group_id=35271

Feature Requests item #1563276, was opened at 2006-09-22 04:44
Message generated for change (Comment added) made by thodin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413698&aid=1563276&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: File Panel
Group: 0.7.5
Status: Open
Resolution: Accepted
Priority: 6
Private: No
Submitted By: demesne (demesne)
Assigned to: Nobody/Anonymous (nobody)
Summary: Address bar and Auto-completion

Initial Comment:
It would be good if there were an address bar and
auto-completion at the top of each pane, for quicker
access to directories and files.

----------------------------------------------------------------------

Comment By: mantrid (thodin)
Date: 2010-05-10 20:36

Message:
How about adding a breadcrumb instead - just like one in JDT? we could rip
it from org.eclipse.jdt.ui plugin at
org.eclipse.jdt.internal.ui.javaeditor.breadcrumb

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2006-09-22 09:16

Message:
Logged In: YES 
user_id=940779

The additional features required are:
- make the existing address bar editable;
- add a listener for the ENTER key plus a "Go" button for
opening the manually entered directory;
- provide autocompletion based on the directory structure.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413698&aid=1563276&group_id=35271

Bugs item #1461466, was opened at 2006-03-30 18:54
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1461466&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tab or Panel Issues
Group: 0.7.0
Status: Open
>Resolution: Duplicate
Priority: 7
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Dan Corneanu (corneanu_dan)
Summary: [win32] null pointer exception in System Volume Information

Initial Comment:
If folder "System Volume Information" is accessed a
null pointer exception comes up, and OK, close, cancel
does not work.

Only known workaround is to kill the application
through task manager. See attached image.

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-08 11:29

Message:
This is a duplicate of #1720501

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2006-03-30 19:02

Message:
Logged In: YES 
user_id=940779

That's a nasty one. I'll try to reproduce and fix it ASAP.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1461466&group_id=35271

Bugs item #1720501, was opened at 2007-05-17 08:42
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: VFS
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Dan Corneanu (corneanu_dan)
Summary: NullPointerException on selection of protected directory

Initial Comment:
An internal error occurred during: "Retrieving contents for directory file:///C:/System Volume Information".

Occurre when I select this directory on Windows XP Pro

NullPointerException on class VfsManagerExtension
Method: hasChildDirectories (ligne 215)

currentParent.getChildren(); return null in this case
so replacing
>>if(children.length > 0) {
by
<<if(children != null) {
must fix it

PS: The 'Multiple Error Dialog' appears many times because each times the dialog is close, there is a retry to read the directory...

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-03-07 14:37

Message:
Robert,
would it be OK to merge the changes on the branch into the HEAD ?

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-08 11:21

Message:
The first version of the fix can be found in the ID_1720501 branch. I have
added support for the callers of doRefresh() to be notified of the result
of the execution.

Why do we need FileTableControl.doRefresh() do it's job in 2 steps? Can't
we move the content of syncExec() in the Job's run() method? The result
will be the same but the code would be much clear and dealing with
exceptions would be much easier.

Can anybody review my changes please ?

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-22 13:43

Message:
I can confirm the bug, but I get a a NullPointerException in method
FileControlModel.getContent(). The javadoc for FileObject.getChildren()
says it never returns Null. It seems that the vfs implementation we are
using returns null if you get an "access denied" from the os. I have made a
test with the last release of vfs and the getChildren() method now throws a
FileNotFolderException. 

1. One solution would be to switch to the last release of vfs.
2. The other solution would be to guard all calls to
FileObjec.getChildren() (13 occurrences) with a test for null.

Can one of the project's admins decide which way is better?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Bugs item #1461466, was opened at 2006-03-30 18:54
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1461466&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tab or Panel Issues
Group: 0.7.0
Status: Open
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Dan Corneanu (corneanu_dan)
Summary: [win32] null pointer exception in System Volume Information

Initial Comment:
If folder "System Volume Information" is accessed a
null pointer exception comes up, and OK, close, cancel
does not work.

Only known workaround is to kill the application
through task manager. See attached image.

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-08 11:29

Message:
This is a duplicate of #1720501

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2006-03-30 19:02

Message:
Logged In: YES 
user_id=940779

That's a nasty one. I'll try to reproduce and fix it ASAP.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1461466&group_id=35271

Bugs item #2932702, was opened at 2010-01-15 11:35
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Jcommander (other)
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
>Assigned to: Dan Corneanu (corneanu_dan)
Summary: Functional tests

Initial Comment:
There are no functional tests present in the project. 
I would very much wish to have these kind of test and have them automated.
Possible approaches: SWTBot, TPTP's Automated GUI Recorder, 
GUITAR - http://guitar.sourceforge.net/
abbot - http://abbot.sourceforge.net/doc/overview.shtml


----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-30 15:18

Message:
Hi,
I have added a test to model the "Copy file" use case. In the
beforeClass()method I prepare a temporary file system (thanks to apaches
VFS capabilities) and unpack the content of the "jcmd functional testing
resources.zip". Later, the tests can use this file system as their fixture.
In the afterClass() method, I just close the VFS manager which results in
removing the temporary file system from the disk. This set-up gives us a
proper isolated test environment. We can debate if the test fixture should
be set up and teared down before/after each test or is it acceptable to set
it up before the first test and tear it down after the last one.
Please have a look and let me know what you think. Yes, some parts of the
test, like searching for a cell in the table, are a little bit complicated,
but I think we can factor them out.
SWTBot tests seem to fail if you click on the JCommander window during a
test run.
There is an interesting tool in SWTBot called swtspy. You can use it to
inspect the GUI structure and get an idea how to get to a given widget. If
you want to run the tool on JCommander you have to:
- add the org.eclipse.swtbot.eclipse.spy plugin to your launch
configuration. 
- start JCommander
- add the "Eclipse Spy" view to your perspective
- toogle eclipsespy capture on/off by using "Ctrl - Shift"

Best regards,
Dan.

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-18 10:39

Message:
Hi,
I have added a new project with SWTBot based tests. The name of the
project is org.jcommander.ui.tests, you can find it in CVS in the plugins
folder. It is a simple plugin project. Currently it only has a single test
case, to demonstrate how SWTBot can be used. You can run the test using the
JCommanderUITest.launch launcher fount in the root of the project.

For now the test has a hard coded path "C:\" but this will change in the
future.

In the future we can configure the test fixture to use an InMemory VFS for
the tests, to run identical on all platforms. I think apache's VFS supports
this. We can populate the file system with the same structure before each
test is run. What do you think about this approach?

While playing with the first SWTBot test I've found a bug in the 
FileControlModel.java. There is a concurrent access/modification bug in 
the update()/getContent() methods resulting in an
IndexOutOfBoundsException. Please run the test and let me know if it also
happens to you. I'll fill a bug report for this.

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2010-01-15 15:51

Message:
This would be a warmly welcomed addition to the project. I've heard good
things about SWTBot, but it might be too basic. I've had some contact with
TPTP when attempting to profile a Web application, about 1 year ago, and it
seemed overly complex and slow. But it might have changed. Looking forward
to see your ideas about this topic.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Bugs item #2989862, was opened at 2010-04-20 15:07
Message generated for change (Comment added) made by sky_halud
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989862&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bookmark Control
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
>Assigned to: Dan Corneanu (corneanu_dan)
Summary: Bookmarks not visible

Initial Comment:
On Ubuntu 9.10 with GTK, the bookmark's texts are not visible.
The popup menu's position is wrong also.

(Test with Ubuntu 9.10 running inside VMWare)

----------------------------------------------------------------------

>Comment By: Robert Enyedi (sky_halud)
Date: 2010-04-20 20:11

Message:
I just did that. SourceForge has some weird rules about user rights. You
are now also a tracker admin.

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-04-20 15:10

Message:
Robert, can you please change the project's settings so I am listed in the
"Assigned:" combo-box on the bug reporting form?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989862&group_id=35271

Bugs item #2989862, was opened at 2010-04-20 15:07
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989862&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bookmark Control
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bookmarks not visible

Initial Comment:
On Ubuntu 9.10 with GTK, the bookmark's texts are not visible.
The popup menu's position is wrong also.

(Test with Ubuntu 9.10 running inside VMWare)

----------------------------------------------------------------------

>Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-04-20 15:10

Message:
Robert, can you please change the project's settings so I am listed in the
"Assigned:" combo-box on the bug reporting form?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989862&group_id=35271

Bugs item #2989862, was opened at 2010-04-20 15:07
Message generated for change (Tracker Item Submitted) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989862&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bookmark Control
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bookmarks not visible

Initial Comment:
On Ubuntu 9.10 with GTK, the bookmark's texts are not visible.
The popup menu's position is wrong also.

(Test with Ubuntu 9.10 running inside VMWare)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989862&group_id=35271

Bugs item #2989235, was opened at 2010-04-19 12:09
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989235&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bookmark Control
Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bookmarks not saved

Initial Comment:
New bookmarks added to QuickDirs are not saved.
On windows I get an FileNotFoundException

[main] java.io.FileNotFoundException: \Documents and Settings\cdan\jcommander.jcmdbmk (The system cannot find the path specified) - (BookmarksFileSystem.java:95)
java.io.FileNotFoundException: \Documents and Settings\cdan\jcommander.jcmdbmk (The system cannot find the path specified)
	at java.io.FileOutputStream.open(Native Method)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:179)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:70)
	at org.jcommander.phileas.bookmarks.BookmarksFileSystem.save(BookmarksFileSystem.java:89)
	at org.jcommander.phileas.bookmarks.BookmarksFileObject.setValue(BookmarksFileObject.java:247)
	at org.jcommander.ui.filepanel.bookmarks.BookmarkComposite$2.widgetSelected(BookmarkComposite.java:94)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3910)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3503)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.jcommander.ui.app.PlatformRunnable$JCMDApplicationEntryPoint.startup(PlatformRunnable.java:114)
	at org.jcommander.ui.app.singleton.SingletonAppLauncher.startingFirstInstance(SingletonAppLauncher.java:76)
	at org.jcommander.ui.app.PlatformRunnable.start(PlatformRunnable.java:51)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1287)

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-04-19 13:28

Message:
Fixed in Branch VER_0_7_2

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989235&group_id=35271

Bugs item #2989235, was opened at 2010-04-19 12:09
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989235&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bookmark Control
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bookmarks not saved

Initial Comment:
New bookmarks added to QuickDirs are not saved.
On windows I get an FileNotFoundException

[main] java.io.FileNotFoundException: \Documents and Settings\cdan\jcommander.jcmdbmk (The system cannot find the path specified) - (BookmarksFileSystem.java:95)
java.io.FileNotFoundException: \Documents and Settings\cdan\jcommander.jcmdbmk (The system cannot find the path specified)
	at java.io.FileOutputStream.open(Native Method)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:179)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:70)
	at org.jcommander.phileas.bookmarks.BookmarksFileSystem.save(BookmarksFileSystem.java:89)
	at org.jcommander.phileas.bookmarks.BookmarksFileObject.setValue(BookmarksFileObject.java:247)
	at org.jcommander.ui.filepanel.bookmarks.BookmarkComposite$2.widgetSelected(BookmarkComposite.java:94)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3910)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3503)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.jcommander.ui.app.PlatformRunnable$JCMDApplicationEntryPoint.startup(PlatformRunnable.java:114)
	at org.jcommander.ui.app.singleton.SingletonAppLauncher.startingFirstInstance(SingletonAppLauncher.java:76)
	at org.jcommander.ui.app.PlatformRunnable.start(PlatformRunnable.java:51)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1287)

----------------------------------------------------------------------

>Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-04-19 13:28

Message:
Fixed in Branch VER_0_7_2

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989235&group_id=35271

Bugs item #2989235, was opened at 2010-04-19 12:09
Message generated for change (Tracker Item Submitted) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989235&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bookmark Control
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bookmarks not saved

Initial Comment:
New bookmarks added to QuickDirs are not saved.
On windows I get an FileNotFoundException

[main] java.io.FileNotFoundException: \Documents and Settings\cdan\jcommander.jcmdbmk (The system cannot find the path specified) - (BookmarksFileSystem.java:95)
java.io.FileNotFoundException: \Documents and Settings\cdan\jcommander.jcmdbmk (The system cannot find the path specified)
	at java.io.FileOutputStream.open(Native Method)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:179)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:70)
	at org.jcommander.phileas.bookmarks.BookmarksFileSystem.save(BookmarksFileSystem.java:89)
	at org.jcommander.phileas.bookmarks.BookmarksFileObject.setValue(BookmarksFileObject.java:247)
	at org.jcommander.ui.filepanel.bookmarks.BookmarkComposite$2.widgetSelected(BookmarkComposite.java:94)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3910)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3503)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.jcommander.ui.app.PlatformRunnable$JCMDApplicationEntryPoint.startup(PlatformRunnable.java:114)
	at org.jcommander.ui.app.singleton.SingletonAppLauncher.startingFirstInstance(SingletonAppLauncher.java:76)
	at org.jcommander.ui.app.PlatformRunnable.start(PlatformRunnable.java:51)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1287)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2989235&group_id=35271

Bugs item #1720501, was opened at 2007-05-17 08:42
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: VFS
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: NullPointerException on selection of protected directory

Initial Comment:
An internal error occurred during: "Retrieving contents for directory file:///C:/System Volume Information".

Occurre when I select this directory on Windows XP Pro

NullPointerException on class VfsManagerExtension
Method: hasChildDirectories (ligne 215)

currentParent.getChildren(); return null in this case
so replacing
>>if(children.length > 0) {
by
<<if(children != null) {
must fix it

PS: The 'Multiple Error Dialog' appears many times because each times the dialog is close, there is a retry to read the directory...

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-03-07 14:37

Message:
Robert,
would it be OK to merge the changes on the branch into the HEAD ?

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-08 11:21

Message:
The first version of the fix can be found in the ID_1720501 branch. I have
added support for the callers of doRefresh() to be notified of the result
of the execution.

Why do we need FileTableControl.doRefresh() do it's job in 2 steps? Can't
we move the content of syncExec() in the Job's run() method? The result
will be the same but the code would be much clear and dealing with
exceptions would be much easier.

Can anybody review my changes please ?

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-22 13:43

Message:
I can confirm the bug, but I get a a NullPointerException in method
FileControlModel.getContent(). The javadoc for FileObject.getChildren()
says it never returns Null. It seems that the vfs implementation we are
using returns null if you get an "access denied" from the os. I have made a
test with the last release of vfs and the getChildren() method now throws a
FileNotFolderException. 

1. One solution would be to switch to the last release of vfs.
2. The other solution would be to guard all calls to
FileObjec.getChildren() (13 occurrences) with a test for null.

Can one of the project's admins decide which way is better?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Bugs item #1461466, was opened at 2006-03-30 18:54
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1461466&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tab or Panel Issues
Group: 0.7.0
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: [win32] null pointer exception in System Volume Information

Initial Comment:
If folder "System Volume Information" is accessed a
null pointer exception comes up, and OK, close, cancel
does not work.

Only known workaround is to kill the application
through task manager. See attached image.

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-08 11:29

Message:
This is a duplicate of #1720501

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2006-03-30 19:02

Message:
Logged In: YES 
user_id=940779

That's a nasty one. I'll try to reproduce and fix it ASAP.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1461466&group_id=35271

Bugs item #1720501, was opened at 2007-05-17 08:42
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: VFS
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: NullPointerException on selection of protected directory

Initial Comment:
An internal error occurred during: "Retrieving contents for directory file:///C:/System Volume Information".

Occurre when I select this directory on Windows XP Pro

NullPointerException on class VfsManagerExtension
Method: hasChildDirectories (ligne 215)

currentParent.getChildren(); return null in this case
so replacing
>>if(children.length > 0) {
by
<<if(children != null) {
must fix it

PS: The 'Multiple Error Dialog' appears many times because each times the dialog is close, there is a retry to read the directory...

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-08 11:21

Message:
The first version of the fix can be found in the ID_1720501 branch. I have
added support for the callers of doRefresh() to be notified of the result
of the execution.

Why do we need FileTableControl.doRefresh() do it's job in 2 steps? Can't
we move the content of syncExec() in the Job's run() method? The result
will be the same but the code would be much clear and dealing with
exceptions would be much easier.

Can anybody review my changes please ?

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-22 13:43

Message:
I can confirm the bug, but I get a a NullPointerException in method
FileControlModel.getContent(). The javadoc for FileObject.getChildren()
says it never returns Null. It seems that the vfs implementation we are
using returns null if you get an "access denied" from the os. I have made a
test with the last release of vfs and the getChildren() method now throws a
FileNotFolderException. 

1. One solution would be to switch to the last release of vfs.
2. The other solution would be to guard all calls to
FileObjec.getChildren() (13 occurrences) with a test for null.

Can one of the project's admins decide which way is better?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Bugs item #2936161, was opened at 2010-01-21 11:24
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User Interface
Group: None
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: NullPointerException or IndexOutOfBoundsException

Initial Comment:
Sometimes when changing the root of one of the panels, I get a NullPointerException or IndexOutOfBoundsException.
The exception is thrown from the FileControlModel.update() method. It seems to be a concurrent access problem. The class FileControlModel has 3 attributes that are related to each other and are used as shared resources: contents, sortedDetails, actualContents. The class is not thread safe and chances are that somehow the 
update() and getContent() step on each others foot.

There is a test in JCommanderUITest.fileControlModelUpdateException that sometimes reproduces the problem.
The stacktrace is:

org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
	at org.eclipse.swt.SWT.error(SWT.java:3884)
	at org.eclipse.swt.SWT.error(SWT.java:3799)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:137)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.jcommander.ui.app.PlatformRunnable$JCMDApplicationEntryPoint.startup(PlatformRunnable.java:114)
	at org.jcommander.ui.app.singleton.SingletonAppLauncher.startingFirstInstance(SingletonAppLauncher.java:76)
	at org.jcommander.ui.app.PlatformRunnable.start(PlatformRunnable.java:51)
	at org.eclipse.swtbot.eclipse.core.UITestApplication.start(UITestApplication.java:56)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
Caused by: java.lang.NullPointerException
	at org.jcommander.ui.filepanel.comparators.TableComparator.compare(TableComparator.java:36)
	at org.jcommander.ui.filepanel.controls.FileTableControl.getSorted(FileTableControl.java:406)
	at org.jcommander.ui.filepanel.model.FileControlModel.update(FileControlModel.java:609)
	at org.jcommander.ui.filepanel.controls.FileTableControl$9.run(FileTableControl.java:616)
	at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:155)
	at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
	... 26 more

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-07 19:45

Message:
I have renamed method getContent( ) to readContentFromFS() because the name
was misleading.

The FileControlModel class is not thread safe. I have checked the call
hierarchy for its methods and I have concluded that all methods, except
readContentFromFS(), are called from within the UI thread so it should be
no problem with them. The only problem was the interaction between
readContentFromFS() and update() methods. I have changed the code in
update() not to rely on the fact that actualContents stays unchanged until
the end of the method execution. This should fix the bug.

Robert, can you please have a look and confirm that my assumption
regarding the call hierarchy is correct?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Bugs item #2936161, was opened at 2010-01-21 11:24
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User Interface
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: NullPointerException or IndexOutOfBoundsException

Initial Comment:
Sometimes when changing the root of one of the panels, I get a NullPointerException or IndexOutOfBoundsException.
The exception is thrown from the FileControlModel.update() method. It seems to be a concurrent access problem. The class FileControlModel has 3 attributes that are related to each other and are used as shared resources: contents, sortedDetails, actualContents. The class is not thread safe and chances are that somehow the 
update() and getContent() step on each others foot.

There is a test in JCommanderUITest.fileControlModelUpdateException that sometimes reproduces the problem.
The stacktrace is:

org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
	at org.eclipse.swt.SWT.error(SWT.java:3884)
	at org.eclipse.swt.SWT.error(SWT.java:3799)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:137)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.jcommander.ui.app.PlatformRunnable$JCMDApplicationEntryPoint.startup(PlatformRunnable.java:114)
	at org.jcommander.ui.app.singleton.SingletonAppLauncher.startingFirstInstance(SingletonAppLauncher.java:76)
	at org.jcommander.ui.app.PlatformRunnable.start(PlatformRunnable.java:51)
	at org.eclipse.swtbot.eclipse.core.UITestApplication.start(UITestApplication.java:56)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
Caused by: java.lang.NullPointerException
	at org.jcommander.ui.filepanel.comparators.TableComparator.compare(TableComparator.java:36)
	at org.jcommander.ui.filepanel.controls.FileTableControl.getSorted(FileTableControl.java:406)
	at org.jcommander.ui.filepanel.model.FileControlModel.update(FileControlModel.java:609)
	at org.jcommander.ui.filepanel.controls.FileTableControl$9.run(FileTableControl.java:616)
	at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:155)
	at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
	... 26 more

----------------------------------------------------------------------

>Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-02-07 19:45

Message:
I have renamed method getContent( ) to readContentFromFS() because the name
was misleading.

The FileControlModel class is not thread safe. I have checked the call
hierarchy for its methods and I have concluded that all methods, except
readContentFromFS(), are called from within the UI thread so it should be
no problem with them. The only problem was the interaction between
readContentFromFS() and update() methods. I have changed the code in
update() not to rely on the fact that actualContents stays unchanged until
the end of the method execution. This should fix the bug.

Robert, can you please have a look and confirm that my assumption
regarding the call hierarchy is correct?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Bugs item #2936161, was opened at 2010-01-21 11:24
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User Interface
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: NullPointerException or IndexOutOfBoundsException

Initial Comment:
Sometimes when changing the root of one of the panels, I get a NullPointerException or IndexOutOfBoundsException.
The exception is thrown from the FileControlModel.update() method. It seems to be a concurrent access problem. The class FileControlModel has 3 attributes that are related to each other and are used as shared resources: contents, sortedDetails, actualContents. The class is not thread safe and chances are that somehow the 
update() and getContent() step on each others foot.

There is a test in JCommanderUITest.fileControlModelUpdateException that sometimes reproduces the problem.
The stacktrace is:

org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
	at org.eclipse.swt.SWT.error(SWT.java:3884)
	at org.eclipse.swt.SWT.error(SWT.java:3799)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:137)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.jcommander.ui.app.PlatformRunnable$JCMDApplicationEntryPoint.startup(PlatformRunnable.java:114)
	at org.jcommander.ui.app.singleton.SingletonAppLauncher.startingFirstInstance(SingletonAppLauncher.java:76)
	at org.jcommander.ui.app.PlatformRunnable.start(PlatformRunnable.java:51)
	at org.eclipse.swtbot.eclipse.core.UITestApplication.start(UITestApplication.java:56)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
Caused by: java.lang.NullPointerException
	at org.jcommander.ui.filepanel.comparators.TableComparator.compare(TableComparator.java:36)
	at org.jcommander.ui.filepanel.controls.FileTableControl.getSorted(FileTableControl.java:406)
	at org.jcommander.ui.filepanel.model.FileControlModel.update(FileControlModel.java:609)
	at org.jcommander.ui.filepanel.controls.FileTableControl$9.run(FileTableControl.java:616)
	at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:155)
	at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
	... 26 more

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Bugs item #2932702, was opened at 2010-01-15 11:35
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Jcommander (other)
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Functional tests

Initial Comment:
There are no functional tests present in the project. 
I would very much wish to have these kind of test and have them automated.
Possible approaches: SWTBot, TPTP's Automated GUI Recorder, 
GUITAR - http://guitar.sourceforge.net/
abbot - http://abbot.sourceforge.net/doc/overview.shtml


----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-30 15:18

Message:
Hi,
I have added a test to model the "Copy file" use case. In the
beforeClass()method I prepare a temporary file system (thanks to apaches
VFS capabilities) and unpack the content of the "jcmd functional testing
resources.zip". Later, the tests can use this file system as their fixture.
In the afterClass() method, I just close the VFS manager which results in
removing the temporary file system from the disk. This set-up gives us a
proper isolated test environment. We can debate if the test fixture should
be set up and teared down before/after each test or is it acceptable to set
it up before the first test and tear it down after the last one.
Please have a look and let me know what you think. Yes, some parts of the
test, like searching for a cell in the table, are a little bit complicated,
but I think we can factor them out.
SWTBot tests seem to fail if you click on the JCommander window during a
test run.
There is an interesting tool in SWTBot called swtspy. You can use it to
inspect the GUI structure and get an idea how to get to a given widget. If
you want to run the tool on JCommander you have to:
- add the org.eclipse.swtbot.eclipse.spy plugin to your launch
configuration. 
- start JCommander
- add the "Eclipse Spy" view to your perspective
- toogle eclipsespy capture on/off by using "Ctrl - Shift"

Best regards,
Dan.

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-18 10:39

Message:
Hi,
I have added a new project with SWTBot based tests. The name of the
project is org.jcommander.ui.tests, you can find it in CVS in the plugins
folder. It is a simple plugin project. Currently it only has a single test
case, to demonstrate how SWTBot can be used. You can run the test using the
JCommanderUITest.launch launcher fount in the root of the project.

For now the test has a hard coded path "C:\" but this will change in the
future.

In the future we can configure the test fixture to use an InMemory VFS for
the tests, to run identical on all platforms. I think apache's VFS supports
this. We can populate the file system with the same structure before each
test is run. What do you think about this approach?

While playing with the first SWTBot test I've found a bug in the 
FileControlModel.java. There is a concurrent access/modification bug in 
the update()/getContent() methods resulting in an
IndexOutOfBoundsException. Please run the test and let me know if it also
happens to you. I'll fill a bug report for this.

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2010-01-15 15:51

Message:
This would be a warmly welcomed addition to the project. I've heard good
things about SWTBot, but it might be too basic. I've had some contact with
TPTP when attempting to profile a Web application, about 1 year ago, and it
seemed overly complex and slow. But it might have changed. Looking forward
to see your ideas about this topic.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Bugs item #1720501, was opened at 2007-05-17 08:42
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: VFS
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: NullPointerException on selection of protected directory

Initial Comment:
An internal error occurred during: "Retrieving contents for directory file:///C:/System Volume Information".

Occurre when I select this directory on Windows XP Pro

NullPointerException on class VfsManagerExtension
Method: hasChildDirectories (ligne 215)

currentParent.getChildren(); return null in this case
so replacing
>>if(children.length > 0) {
by
<<if(children != null) {
must fix it

PS: The 'Multiple Error Dialog' appears many times because each times the dialog is close, there is a retry to read the directory...

----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-22 13:43

Message:
I can confirm the bug, but I get a a NullPointerException in method
FileControlModel.getContent(). The javadoc for FileObject.getChildren()
says it never returns Null. It seems that the vfs implementation we are
using returns null if you get an "access denied" from the os. I have made a
test with the last release of vfs and the getChildren() method now throws a
FileNotFolderException. 

1. One solution would be to switch to the last release of vfs.
2. The other solution would be to guard all calls to
FileObjec.getChildren() (13 occurrences) with a test for null.

Can one of the project's admins decide which way is better?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=1720501&group_id=35271

Bugs item #2936161, was opened at 2010-01-21 11:24
Message generated for change (Tracker Item Submitted) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User Interface
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: NullPointerException or IndexOutOfBoundsException

Initial Comment:
Sometimes when changing the root of one of the panels, I get a NullPointerException or IndexOutOfBoundsException.
The exception is thrown from the FileControlModel.update() method. It seems to be a concurrent access problem. The class FileControlModel has 3 attributes that are related to each other and are used as shared resources: contents, sortedDetails, actualContents. The class is not thread safe and chances are that somehow the 
update() and getContent() step on each others foot.

There is a test in JCommanderUITest.fileControlModelUpdateException that sometimes reproduces the problem.
The stacktrace is:

org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
	at org.eclipse.swt.SWT.error(SWT.java:3884)
	at org.eclipse.swt.SWT.error(SWT.java:3799)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:137)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.jcommander.ui.app.PlatformRunnable$JCMDApplicationEntryPoint.startup(PlatformRunnable.java:114)
	at org.jcommander.ui.app.singleton.SingletonAppLauncher.startingFirstInstance(SingletonAppLauncher.java:76)
	at org.jcommander.ui.app.PlatformRunnable.start(PlatformRunnable.java:51)
	at org.eclipse.swtbot.eclipse.core.UITestApplication.start(UITestApplication.java:56)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
Caused by: java.lang.NullPointerException
	at org.jcommander.ui.filepanel.comparators.TableComparator.compare(TableComparator.java:36)
	at org.jcommander.ui.filepanel.controls.FileTableControl.getSorted(FileTableControl.java:406)
	at org.jcommander.ui.filepanel.model.FileControlModel.update(FileControlModel.java:609)
	at org.jcommander.ui.filepanel.controls.FileTableControl$9.run(FileTableControl.java:616)
	at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:155)
	at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
	... 26 more

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2936161&group_id=35271

Bugs item #2932702, was opened at 2010-01-15 11:35
Message generated for change (Comment added) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Jcommander (other)
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Functional tests

Initial Comment:
There are no functional tests present in the project. 
I would very much wish to have these kind of test and have them automated.
Possible approaches: SWTBot, TPTP's Automated GUI Recorder, 
GUITAR - http://guitar.sourceforge.net/
abbot - http://abbot.sourceforge.net/doc/overview.shtml


----------------------------------------------------------------------

Comment By: Dan Corneanu (corneanu_dan)
Date: 2010-01-18 10:39

Message:
Hi,
I have added a new project with SWTBot based tests. The name of the
project is org.jcommander.ui.tests, you can find it in CVS in the plugins
folder. It is a simple plugin project. Currently it only has a single test
case, to demonstrate how SWTBot can be used. You can run the test using the
JCommanderUITest.launch launcher fount in the root of the project.

For now the test has a hard coded path "C:\" but this will change in the
future.

In the future we can configure the test fixture to use an InMemory VFS for
the tests, to run identical on all platforms. I think apache's VFS supports
this. We can populate the file system with the same structure before each
test is run. What do you think about this approach?

While playing with the first SWTBot test I've found a bug in the 
FileControlModel.java. There is a concurrent access/modification bug in 
the update()/getContent() methods resulting in an
IndexOutOfBoundsException. Please run the test and let me know if it also
happens to you. I'll fill a bug report for this.

----------------------------------------------------------------------

Comment By: Robert Enyedi (sky_halud)
Date: 2010-01-15 15:51

Message:
This would be a warmly welcomed addition to the project. I've heard good
things about SWTBot, but it might be too basic. I've had some contact with
TPTP when attempting to profile a Web application, about 1 year ago, and it
seemed overly complex and slow. But it might have changed. Looking forward
to see your ideas about this topic.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Bugs item #2932702, was opened at 2010-01-15 11:35
Message generated for change (Comment added) made by sky_halud
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Jcommander (other)
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Functional tests

Initial Comment:
There are no functional tests present in the project. 
I would very much wish to have these kind of test and have them automated.
Possible approaches: SWTBot, TPTP's Automated GUI Recorder, 
GUITAR - http://guitar.sourceforge.net/
abbot - http://abbot.sourceforge.net/doc/overview.shtml


----------------------------------------------------------------------

>Comment By: Robert Enyedi (sky_halud)
Date: 2010-01-15 15:51

Message:
This would be a warmly welcomed addition to the project. I've heard good
things about SWTBot, but it might be too basic. I've had some contact with
TPTP when attempting to profile a Web application, about 1 year ago, and it
seemed overly complex and slow. But it might have changed. Looking forward
to see your ideas about this topic.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Bugs item #2932702, was opened at 2010-01-15 11:35
Message generated for change (Settings changed) made by corneanu_dan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Jcommander (other)
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dan Corneanu (corneanu_dan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Functional tests

Initial Comment:
There are no functional tests present in the project. 
I would very much wish to have these kind of test and have them automated.
Possible approaches: SWTBot, TPTP's Automated GUI Recorder, 
GUITAR - http://guitar.sourceforge.net/
abbot - http://abbot.sourceforge.net/doc/overview.shtml


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=413695&aid=2932702&group_id=35271