Oops: I think pre1 and pre2 both segfault on 'insmod' (unless you have
CONFIG_DEBUG_PAGEALLOC turned on.. which most people don't). I left
a debugging flag on in my slab caches because I thought it was harmless.
The fix is in CVS, and I'll release 'pre3' as soon as I hear this fixes
the problem.
If you want to test it, I've posted the fix below.
Sorry about that,
Geoff
===================================================================
RCS file: /cvsroot/ifp-driver/linux-filesystem/fs/iriver/inode.c,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- ifp-driver/linux-filesystem/fs/iriver/inode.c 2004/09/14
15:04:32 1.18
+++ ifp-driver/linux-filesystem/fs/iriver/inode.c 2004/09/15
18:19:08 1.19
@@ -1,6 +1,6 @@
/*
* IRiver ifp filesystem driver for Linux
- * Revision : $Id: inode.c,v 1.18 2004/09/14 15:04:32 oakhamg Exp $
+ * Revision : $Id: inode.c,v 1.19 2004/09/15 18:19:08 oakhamg Exp $
*
* Copyright (C) 2004 Geoff Oakham <oakhamg@...>
*/
@@ -1795,13 +1795,11 @@
{
iriver_inode_cachep = kmem_cache_create("iriver_inode_cachep",
sizeof(struct iriver_inode_info), 0,
- SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|SLAB_POISON|SLAB_RED_ZONE
- , init_once, destroy_twice);
+ SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT, init_once, destroy_twice);
iriver_buffer_cachep = kmem_cache_create("iriver_buffer_cachep",
0x0400, 0,
- SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|SLAB_POISON|SLAB_RED_ZONE
- , NULL, NULL);
+ SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT, NULL, NULL);
if (iriver_inode_cachep == NULL)
return -ENOMEM;
|