On Tue, Mar 2, 2010 at 11:52 AM, Romain LE DISEZ <romain.g3@...:
> Hi Andy,
>
> > A big sorry about the delay. I have more time for Gallery development
> again and I'd like to get this task completed, if you're still up for it.
>
> No problem. I still want to remove the maximum of dependencies to MySQL, so
> let's go! :-)
>
>
> > What's the status of your fork regarding PG compatibility?
>
> As of today, the upgrade to Kohanna 2.4 stopped me because I didn't take
> time to investigate the options to add PgSQL support to K2.4. There is [1]
> but I didn't look at it yet.
>
> As mentionned in ticket #924, there is four columns that need to be renamed
> :
> - caches.key
> - messages.key
> - incoming_translations.key
> - outgoing_translations.key
>
> I already commited :
> - caches.key -> caches.cache_key
> - messages.key -> messages.label
>
>
> > What's the easiest way for me to merge your changes? Do you have a list
> of commits which I should merge?
>
> I have some commits ready to be merged, but it was a long (long) time ago.
> I resolved a lot of conflict during the pasts months so it will probably be
> difficult for you to cherrypick my commits. I propose a patch (attached to
> this mail). It's not the best way because it renames two columns at a time,
> but it's the easiest.
>
> Now that you're back in this task, I will continue with *_translations.key
>
Just a short note on *_translations.key:
Let's just change the DB column names, *not* the l10n client / server API
message format (modules/gallery/helpers/l10n_client.php) or the JavaScript
code / AJAX format
(modules/gallery/helpers/l10n_client.php,
modules/gallery/helpers/l10n_client.php,
modules/gallery/js/l10n_client.js).
>
> > And for quality assurance:
> > What is your method to identify keywords that need to be changed, and
> what's your method to identify what php source code needs to be changed?
>
> To identify the keywords, you can read my mail of 25th of July 2009, there
> is the tests I ran to check compatibility of the keywords.
>
> To find the PHP code to update, there is no magic trick. I start by
> grep'ing through the code for the keyword to rename :
> $ grep -RHn [^_]key application/ index.php installer/ lib/ modules/ themes/
>
> I eliminate the lines that are clearly not to be updated (mainly JS & CSS).
> Then, I read the code to understand what it do. Finally I run units tests
> and do some tests on my dev installation (add/remove photos, create/delete
> albums/users/comments/...)
>
>
> > What about gallery3-contrib, do we need to change any code there too?
>
> Honestly, I didn't look at all. IMHO, a developper who create a module must
> maintain it, we just have to announce the changes (ML, forums). What is the
> official position of the Gallery team about this ? Surely, I will follow it.
>
Sounds good, thanks!
- Andy
>
>
> Greetings.
>
> [1] http://dev.kohanaphp.com/projects/pgsql
>
> --
> Romain LE DISEZ
>
|
