Hmm... I don't know what your implementation looks like, but this seems like it
might not be such a good idea.
Are you syncing the tree contents across all open windows after every change?
What happens when you drag items from one editor to another? (Feel free to
ignore me if you've already considered these issues). At first glance, it just
seems like there are many places for bad side effects to creep in - effects
that could be avoided by simply not allowing the docked widget to be edited in
the first place. I'd vote to just display the tree in the docked widget and
leave the editing to the editor. Although, since you're the one doing the work
here, I suppose I don't have a really major objection. ;)
And on a related note... I haven't been keeping real close tabs on the recent
changes, but I think the last time I looked, the docked history was a fixed
size widget. This is no good, especially for those with lower res displays.
IMHO, an hpaned solution would be better. At the very least, there should be
some way to adjust the width of the docked widget.
--- Ricardo Fernández Pascual <ric@...> wrote:
> I have made changes to allow editing bookmarks with several editors
> at the same time. This may sound quite stupid, but we need it if we want
> docked bookmarks editors (wich can be in several windows and opened at
> the same time than the main editor) and if we want to make the temp
> bookmarks part of the main bookmarks tree.
> This changes are a bit dangerous to commit just before a new
> release, so haven't commited them (and they are not 100% finished ;-) ).
> So, my question is: weren't we going to release yesterday? what
> happened? are we going to release soon? can I commit this potentially
> dangerous changes now?
> MattA: The main reason why I wan't to commit this is to let you (and the
> rest of the worls) test it with the docked bookmarks editor. If you
> wan't me to send a patch, you just have to tell me.
> Also, with this changes, is now a goot idea to move the temp
> bookmarks as a subcategory of the main bookmarks (like autobookmarks).
> Actually, I'm not sure if everything will work correctly now until we
> move it.
> There are still a few things that I want to change, but seems to
> work here...
> Ricardo Fernández Pascual
> Murcia. España.
> Galeon-devel mailing list
Do You Yahoo!?
Yahoo! Auctions - buy the things you want at great prices