cscope

Hans-Bernhard Broeker wrote:

>On Wed, 30 Jun 2004, Neil Horman wrote:
>
>  
>
>>Hey all!  This is a feature that I've been working on for cscope, which 
>>add a search option to the interface, allowing you to specifically 
>>search for all asignments to a symbol.  I've done a reasonable amount of 
>>testing on it (put it into general production use on my system for ~8 
>>months now), and found no particular problems.  Reviews, comments or 
>>suggestions welcome. 
>>    
>>
>
>My objections to this patch have been twofold:
>
>*) -q mode wasn't supported.  You say it now is... if so, fine.
>  
>
Yes, I did some testing with my patch, and it seems to operate just fine.

>*) It interferes with that mysterious 'samuel' editor integration.
>   I've never seen 'samuel', but I'm not sure we can just go and
>   deliberately kill that feature.  So, a roll-call: anybody using
>   'samuel', or willing to speak up for it?
>
>  
>
Thank you, I had been meaning to ask about this...

Neil

> >*) It interferes with that mysterious 'samuel' editor integration.
> >   I've never seen 'samuel', but I'm not sure we can just go and
> >   deliberately kill that feature.  So, a roll-call: anybody using
> >   'samuel', or willing to speak up for it?

I googled around for it ("samuel editor unix":  just "samuel editor"
turns up a lot of people named Samuel who are editors...), and there's
really nothing.  The closest I've seen is the 'sam' editor, which was
used in the 1980s by various luminaries at Bell Labs, including Ken
Thompson.  The fact that cscope is from the same time period at Bell
Labs makes me suspect that 'samuel' is some 'sam' offshoot.  But no one
seems to be using it, so perhaps we ought to nuke the support for it
(it's better to remove it entirely than keep it around in a broken
state, no?).  That's my vote.

--
Jason Duell             Future Technologies Group
<jcduell@...>       Computational Research Division
Tel: +1-510-495-2354    Lawrence Berkeley National Laboratory




		
__________________________________
Do you Yahoo!?
Yahoo! Mail - 50x more storage than other providers!
http://promotions.yahoo.com/new_mail

Jason Duell wrote:

>>>*) It interferes with that mysterious 'samuel' editor integration.
>>>  I've never seen 'samuel', but I'm not sure we can just go and
>>>  deliberately kill that feature.  So, a roll-call: anybody using
>>>  'samuel', or willing to speak up for it?
>>>      
>>>
>
>I googled around for it ("samuel editor unix":  just "samuel editor"
>turns up a lot of people named Samuel who are editors...), and there's
>really nothing.  The closest I've seen is the 'sam' editor, which was
>used in the 1980s by various luminaries at Bell Labs, including Ken
>Thompson.  The fact that cscope is from the same time period at Bell
>Labs makes me suspect that 'samuel' is some 'sam' offshoot.  But no one
>seems to be using it, so perhaps we ought to nuke the support for it
>(it's better to remove it entirely than keep it around in a broken
>state, no?).  That's my vote.
>
>  
>
If that is indeed what it is, Then I can get behind that.

>--
>Jason Duell             Future Technologies Group
><jcduell@...>       Computational Research Division
>Tel: +1-510-495-2354    Lawrence Berkeley National Laboratory
>
>
>
>
>		
>__________________________________
>Do you Yahoo!?
>Yahoo! Mail - 50x more storage than other providers!
>http://promotions.yahoo.com/new_mail
>
>
>-------------------------------------------------------
>This SF.Net email sponsored by Black Hat Briefings & Training.
>Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
>digital self defense, top technical experts, no vendor pitches, 
>unmatched networking opportunities. Visit http://www.blackhat.com
>_______________________________________________
>Cscope-devel mailing list
>Cscope-devel@...
>https://lists.sourceforge.net/lists/listinfo/cscope-devel
>
>  
>

Bugs item #977865, was opened at 2004-06-23 00:56
Message generated for change (Comment added) made by broeker
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=977865&group_id=4664

Category: C lexer/parser
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: paul cannon (paulcannon)
Assigned to: Hans-Bernhard Broeker (broeker)
Summary: quotes handling broken

Initial Comment:
This was found by rjr, who prefers not to post public
info about himself when submitting bugs.  Hence I'm
submitting for him; correspondence may go through me.

------
cscope has a bug in handling filenames with quotes in
"cscope.files" files.

The following data file demonstrates the problem

"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/Ufs/Windows/WindowsCreateSharedFolderPermissions.py"
"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/util/nfsd.py"
"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/util/windows_networking_subsys.py"
"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/Ufsrpc/UIInternal.py"
"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/Ufsrpc/UILogStream.py"
"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/Ufsrpc/UIWindows.py"
"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/IsilonUI/Launch.py"
"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/patches/WDGValidator.py"
"/home/anon/cvs/stuff/src/include/arpa/nameser.h"
"/home/anon/cvs/stuff/src/include/arpa/ftp.h"
"/home/anon/cvs/stuff/src/include/arpa/inet.h"
"/home/anon/cvs/stuff/src/include/arpa/nameser_compat.h"
"/home/anon/cvs/stuff/src/include/arpa/telnet.h"
"/home/anon/cvs/stuff/src/include/arpa/tftp.h"
"/home/anon/cvs/stuff/src/include/a.out.h"
"/home/anon/cvs/stuff/src/include/ar.h"
"/home/anon/cvs/stuff/src/include/assert.h"
"/home/anon/cvs/stuff/src/include/bitstring.h"
"/home/anon/cvs/stuff/src/include/complex.h"
"/home/anon/cvs/stuff/src/include/ctype.h"
"/home/anon/cvs/stuff/src/include/db.h"
"/home/anon/cvs/stuff/src/include/dirent.h"
"/home/anon/cvs/stuff/src/include/disktab.h"
"/home/anon/cvs/stuff/src/include/dlfcn.h"
"/home/anon/cvs/stuff/src/include/elf-hints.h"
"/home/anon/cvs/stuff/src/include/elf.h"
"/home/anon/cvs/stuff/src/include/err.h"

Basically what happens is

"/home/anon/cvs/stuff/src/mycode/scripts/cmd_webui/Ufs/Windows/WindowsCreateSharedFolderPermissions.py"

gets into the buffer 'line' and then a pointer
('point_in_line') gets set to the current location in
the line. The code notes that this line has quotes on
it so it tries to remove them, but in the process it
moves the point_in_line pointer to the location of the
closing quotation mark. However, at the end of the
sscanf() loop we again update the point_in_line pointer
to +length_of_name. This ends up pointing off into a
random location in 'line' (fortunately, this buffer is
quite large).

Later on we read in a shorter string. For example

"/home/anon/cvs/stuff/src/include/ar.h"

We again remove the quotes and increment, but on the
second increment we end up pointing at a portion of the
old long string and on the next pass at sscanf(), we
end up with something like

point_in_line = erPermissions.py"

which is not a valid file, resulting in

"cscope: cannot find file erPermissions.py""

I've attached a patch, but I've only tested it with my
own dataset.
------

----------------------------------------------------------------------

>Comment By: Hans-Bernhard Broeker (broeker)
Date: 2004-06-23 17:43

Message:
Logged In: YES 
user_id=27517

Thanks for this very usable bug report.  Your analysis
stopped just one step short of the real fix: point_in_line
should simply not be moved at all by the code fragment
handling "quoted file names".
I'm checking in my own fix right away...


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=977865&group_id=4664

Bugs item #976622, was opened at 2004-06-21 12:04
Message generated for change (Comment added) made by broeker
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=976622&group_id=4664

Category: Curses interface
Group: None
>Status: Pending
>Resolution: Duplicate
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Hans-Bernhard Broeker (broeker)
Summary: cscope's `-C' option causes strange keyboard input

Initial Comment:
Using the `-C' option to do case-insensitive symbol
lookup causes strange characters to be used. A detailed
description of the problem is given below.

I'm using cscope to work on the FreeBSD Kernel sources &
proceed as follows :
------------------------------------------
1 - Generate list of files.
      find /usr/src/sys/ -type f -name
"*\.[cChHsSlLyY]" -print > ./FreeBSD_KernelSourceFiles.txt

2 - Start cscope, specifiying
      * usage of an inverted database (-q)
      * Kernel Sources (-k)
      * Case-Insensitive search (-C), and
      * the file list generated above.
      cscope -q -k -C -i FreeBSD_KernelSourceFiles.txt

      cscope starts up, the database is built & the curses
      interface is presented.

3 - Examine Source Code, say function ether_poll(), in file
      </usr/src/sys/kern/kern_poll.c>.
      When typing the `_' character, the characters `^?' 
      appear  in place of `_'.

      Also, the entire upper row of keys with numbers
      produces  unexpected characters.
------------------------------------------

  However, I am able to use cscope without any problems if
it is invoked without the `-C' option.

  Since this is a very useful option, especially when
symbol
names are mixed-case, this problem is quite severely
limiting.

Other relevant info :
- I'm using cscope version 15.5 and have seen this with
   15.3 also.
- The terminal I'm using is xterm, with the following
version
    XFree86 4.2.99.903(174)
- The shell I'm using is GNU bash,
   version 2.05b.0(1)-release  (i386-portbld-freebsd4.8)
- The curses libraries on the system have the following
   `what' strings :
   -----------------------------------
   $ what /usr/lib/libcurses*
   /usr/lib/libcurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   $ 
   $ what /usr/lib/libncurses*
   /usr/lib/libncurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so.5:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
  $
-----------------------------------
- The Operating System I'm using is
    FreeBSD 4.10-RELEASE #0

Looking forward to a resolution of this problem.


----------------------------------------------------------------------

>Comment By: Hans-Bernhard Broeker (broeker)
Date: 2004-06-21 13:39

Message:
Logged In: YES 
user_id=27517

That's almost certainly the known bug in cscope's override
for ancient
BSD's failure to correctly implement tolower() and
toupper().  It's fixed in the CVS source since 2004-02-05.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=976622&group_id=4664

Bugs item #977977, was opened at 2004-06-22 22:36
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=977977&group_id=4664

Category: Curses interface
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: cscope's `-C' option causes strange keyboard input

Initial Comment:
Using the `-C' option to do case-insensitive symbol
lookup causes strange characters to be used. A detailed
description of the problem is given below.

I'm using cscope to work on the FreeBSD Kernel sources &
proceed as follows :
------------------------------------------
1 - Generate list of files.
      find /usr/src/sys/ -type f -name
"*\.[cChHsSlLyY]" -print > ./FreeBSD_KernelSourceFiles.txt

2 - Start cscope, specifiying
      * usage of an inverted database (-q)
      * Kernel Sources (-k)
      * Case-Insensitive search (-C), and
      * the file list generated above.
      cscope -q -k -C -i FreeBSD_KernelSourceFiles.txt

      cscope starts up, the database is built & the curses
      interface is presented.

3 - Examine Source Code, say function ether_poll(), in file
      </usr/src/sys/kern/kern_poll.c>.
      When typing the `_' character, the characters `^?' 
      appear  in place of `_'.

      Also, the entire upper row of keys with numbers
      produces  unexpected characters.
------------------------------------------

  However, I am able to use cscope without any problems if
it is invoked without the `-C' option.

  Since this is a very useful option, especially when
symbol
names are mixed-case, this problem is quite severely
limiting.

Other relevant info :
- I'm using cscope version 15.5 and have seen this with
   15.3 also.
- The terminal I'm using is xterm, with the following
version
    XFree86 4.2.99.903(174)
- The shell I'm using is GNU bash,
   version 2.05b.0(1)-release  (i386-portbld-freebsd4.8)
- The curses libraries on the system have the following
   `what' strings :
   -----------------------------------
   $ what /usr/lib/libcurses*
   /usr/lib/libcurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   $ 
   $ what /usr/lib/libncurses*
   /usr/lib/libncurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so.5:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
  $
-----------------------------------
- The Operating System I'm using is
    FreeBSD 4.10-RELEASE #0

Looking forward to a resolution of this problem.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=977977&group_id=4664

Bugs item #977977, was opened at 2004-06-23 07:36
Message generated for change (Comment added) made by broeker
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=977977&group_id=4664

Category: Curses interface
Group: None
>Status: Closed
>Resolution: Duplicate
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: cscope's `-C' option causes strange keyboard input

Initial Comment:
Using the `-C' option to do case-insensitive symbol
lookup causes strange characters to be used. A detailed
description of the problem is given below.

I'm using cscope to work on the FreeBSD Kernel sources &
proceed as follows :
------------------------------------------
1 - Generate list of files.
      find /usr/src/sys/ -type f -name
"*\.[cChHsSlLyY]" -print > ./FreeBSD_KernelSourceFiles.txt

2 - Start cscope, specifiying
      * usage of an inverted database (-q)
      * Kernel Sources (-k)
      * Case-Insensitive search (-C), and
      * the file list generated above.
      cscope -q -k -C -i FreeBSD_KernelSourceFiles.txt

      cscope starts up, the database is built & the curses
      interface is presented.

3 - Examine Source Code, say function ether_poll(), in file
      </usr/src/sys/kern/kern_poll.c>.
      When typing the `_' character, the characters `^?' 
      appear  in place of `_'.

      Also, the entire upper row of keys with numbers
      produces  unexpected characters.
------------------------------------------

  However, I am able to use cscope without any problems if
it is invoked without the `-C' option.

  Since this is a very useful option, especially when
symbol
names are mixed-case, this problem is quite severely
limiting.

Other relevant info :
- I'm using cscope version 15.5 and have seen this with
   15.3 also.
- The terminal I'm using is xterm, with the following
version
    XFree86 4.2.99.903(174)
- The shell I'm using is GNU bash,
   version 2.05b.0(1)-release  (i386-portbld-freebsd4.8)
- The curses libraries on the system have the following
   `what' strings :
   -----------------------------------
   $ what /usr/lib/libcurses*
   /usr/lib/libcurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   $ 
   $ what /usr/lib/libncurses*
   /usr/lib/libncurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so.5:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
  $
-----------------------------------
- The Operating System I'm using is
    FreeBSD 4.10-RELEASE #0

Looking forward to a resolution of this problem.


----------------------------------------------------------------------

>Comment By: Hans-Bernhard Broeker (broeker)
Date: 2004-06-23 15:07

Message:
Logged In: YES 
user_id=27517

This is a re-post of a report I already replied to
(#976622), which see.

Closing this one as a duplicate.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=977977&group_id=4664

Bugs item #976622, was opened at 2004-06-21 12:04
Message generated for change (Settings changed) made by broeker
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=976622&group_id=4664

Category: Curses interface
Group: None
>Status: Open
Resolution: Duplicate
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Hans-Bernhard Broeker (broeker)
Summary: cscope's `-C' option causes strange keyboard input

Initial Comment:
Using the `-C' option to do case-insensitive symbol
lookup causes strange characters to be used. A detailed
description of the problem is given below.

I'm using cscope to work on the FreeBSD Kernel sources &
proceed as follows :
------------------------------------------
1 - Generate list of files.
      find /usr/src/sys/ -type f -name
"*\.[cChHsSlLyY]" -print > ./FreeBSD_KernelSourceFiles.txt

2 - Start cscope, specifiying
      * usage of an inverted database (-q)
      * Kernel Sources (-k)
      * Case-Insensitive search (-C), and
      * the file list generated above.
      cscope -q -k -C -i FreeBSD_KernelSourceFiles.txt

      cscope starts up, the database is built & the curses
      interface is presented.

3 - Examine Source Code, say function ether_poll(), in file
      </usr/src/sys/kern/kern_poll.c>.
      When typing the `_' character, the characters `^?' 
      appear  in place of `_'.

      Also, the entire upper row of keys with numbers
      produces  unexpected characters.
------------------------------------------

  However, I am able to use cscope without any problems if
it is invoked without the `-C' option.

  Since this is a very useful option, especially when
symbol
names are mixed-case, this problem is quite severely
limiting.

Other relevant info :
- I'm using cscope version 15.5 and have seen this with
   15.3 also.
- The terminal I'm using is xterm, with the following
version
    XFree86 4.2.99.903(174)
- The shell I'm using is GNU bash,
   version 2.05b.0(1)-release  (i386-portbld-freebsd4.8)
- The curses libraries on the system have the following
   `what' strings :
   -----------------------------------
   $ what /usr/lib/libcurses*
   /usr/lib/libcurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libcurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   $ 
   $ what /usr/lib/libncurses*
   /usr/lib/libncurses.a:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses.so.5:
           termcap.c       8.1 (Berkeley) 6/4/93
   /usr/lib/libncurses_p.a:
           termcap.c       8.1 (Berkeley) 6/4/93
  $
-----------------------------------
- The Operating System I'm using is
    FreeBSD 4.10-RELEASE #0

Looking forward to a resolution of this problem.


----------------------------------------------------------------------

Comment By: Hans-Bernhard Broeker (broeker)
Date: 2004-06-21 13:39

Message:
Logged In: YES 
user_id=27517

That's almost certainly the known bug in cscope's override
for ancient
BSD's failure to correctly implement tolower() and
toupper().  It's fixed in the CVS source since 2004-02-05.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=976622&group_id=4664

Bugs item #964789, was opened at 2004-06-02 06:43
Message generated for change (Comment added) made by yugami
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=964789&group_id=4664

Category: C lexer/parser
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Marc Britten (yugami)
Assigned to: Hans-Bernhard Broeker (broeker)
Summary: See's incorrect function call 

Initial Comment:
the attached file contains source from a C++ header
file which cscope mis parses.

It sees the function list, which is defined after the
inline function Close, as being called from Close.

----------------------------------------------------------------------

>Comment By: Marc Britten (yugami)
Date: 2004-06-02 06:44

Message:
Logged In: YES 
user_id=354

Apparently i only thought about checking the box to do the
upload

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104664&aid=964789&group_id=4664